Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NewValue checks to be properly recursive #79

Merged
merged 5 commits into from
Apr 21, 2021
Merged

Fix NewValue checks to be properly recursive #79

merged 5 commits into from
Apr 21, 2021

Commits on Apr 20, 2021

  1. [wip] Support nested dynamics in NewValue

    @paultyng @paddycarver
    paultyng authored and paddycarver committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    ae7f3b5 View commit details
    Browse the repository at this point in the history

  2. Fix NewValue checks to be properly recursive. 

    Fix the checks that NewValue runs to ensure that a value can be used
with a Type to properly handle DynamicPseudoTypes nested in complex
types. Builds on and supersedes #76.

Should we make this part of the behavior for `.Is`? My gut says "no",
because `Is` is supposed to be about checking whether a type is
semantically similar, not that it can be used as another type. Maybe we
want a `Fulfills` method, similar to Is, that does this? I don't know
that this behavior needs to be exported, though...

Fixes a bug in #74 that would panic for complex types containing
DynamicPseudoTypes.
    @paddycarver
    paddycarver committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    883294a View commit details
    Browse the repository at this point in the history

  3. Fix typo.

    @paddycarver
    paddycarver committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    307938c View commit details
    Browse the repository at this point in the history

  4. Add Object-with-Dynamic-attr test for NewValue 

    Add a test to exercise the object-with-a-dynamic-attribute logic we
fixed.
    @paddycarver
    paddycarver committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    5d94cb3 View commit details
    Browse the repository at this point in the history

  5. Add more tests. 

    Add tests for all the complex types, and make sure types that require
elements be the same type get only elements of the same exact type.
    @paddycarver
    paddycarver committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    aa0b18a View commit details
    Browse the repository at this point in the history