Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Remove ResourceServerWithMoveResourceState Checks/Assertions #219

Closed
bflad opened this issue Jan 26, 2024 · 1 comment · Fixed by #238
Closed

all: Remove ResourceServerWithMoveResourceState Checks/Assertions #219

bflad opened this issue Jan 26, 2024 · 1 comment · Fixed by #238
Labels
enhancement New feature or request
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Jan 26, 2024

terraform-plugin-mux version

v0.14.0 (not yet released)

Description

This issue is a corollary to hashicorp/terraform-plugin-go#363, where there will be two separate releases for MoveResourceState RPC support. When the terraform-plugin-go dependency is updated to require MoveResourceState in ResourceServer implementations, the temporary ResourceServerWithMoveResourceState checks in this codebase should be removed.

Proposal

Remove type assertions against tfprotov5.ResourceServerWithMoveResourceState and tfprotov6.ResourceServerWithMoveResourceState directly, in preference of using the updated ProviderServer directly.

References

Copy link

github-actions bot commented Jun 8, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
1 participant