all: Remove type assertions for Function and MoveResourceState RPC implementations #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
approved these changes
May 8, 2024
There was a problem hiding this comment.
❤️ Thanks for doing this! Looks good to me 🚀
I'm not sure if this warrants a changelog
I don't think so personally -- the Go module already requires terraform-plugin-go v0.23.0 so downstream consumers cannot get into a situation that we need to announce that minimum version requirement. 👍
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #210
Closes #219
With the release of
terraform-plugin-gov0.23.0, theFunctionServerinterface andMoveResourceStatemethod are now required. This PR removes the temporary type assertions.I'm not sure if this warrants a changelog, but happy to add a
NOTEif we think it's helpful.