Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/schema: Update to protocol version 5.4 and enable GetProviderSchemaOptional server capability #1235

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 25, 2023

Closes #1234

go.mod Outdated Show resolved Hide resolved
@bflad bflad marked this pull request as ready for review August 30, 2023 19:44
@bflad bflad requested a review from a team as a code owner August 30, 2023 19:44
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀 🎸 🐰

Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

bflad added a commit to hashicorp/terraform-plugin-go that referenced this pull request Sep 6, 2023
…data RPC and GetProviderSchemaOptional server capability (#311)

Reference: #310

Protocol upgrades that impose new RPCs will either require:

- The `tfprotov5.ProviderServer`/`tfprotov6.ProviderServer` interface to require a new method
- Or, new "optional" interfaces be implemented (let's make up `ProviderServerWithGetMetadata` in this case)

terraform-plugin-go is a low level abstraction which is designed to _directly implement_ the protocol rather than introduce its own abstractions. Most provider developers will directly interface with higher level Go modules, such as terraform-plugin-sdk and terraform-plugin-framework. Except for advanced provider development using this Go module directly, this type of low level "breaking" change will be hidden by also upgrading those Go modules at the same time:

- hashicorp/terraform-plugin-sdk#1235
- hashicorp/terraform-plugin-framework#829
- hashicorp/terraform-plugin-mux#186

Therefore the change is implemented on the existing interface.
@bflad bflad force-pushed the bflad/getproviderschema-optional branch from 6cfc53b to 37f98f5 Compare September 6, 2023 15:30
@bflad bflad merged commit d419eaa into main Sep 6, 2023
@bflad bflad deleted the bflad/getproviderschema-optional branch September 6, 2023 16:44
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates for Protocol Version 5.4
3 participants