Add more hash outputs of archive content #165
Conversation
Per hashicorp/terraform-provider-local#137 this brings the provider up to feature parity with all of Terraform's built-in file-reading functions The following outputs are added to `data_archive_file`: * `output_sha256` - SHA256 checksum of archive content. * `output_sha512` - SHA512 checksum of archive content. * `output_base64sha512` - Base64 encoded SHA512 checksum of archive content.
|
hi @zachwhaley thank you for the PR! The team is strongly focused on some project work for the next few weeks, but I'm adding it to our board to review when we have some free cycles. |
|
@bookshelfdave Any updates? |
|
@zachwhaley folks are back from PTO next week and we'll take a look then. |
|
Hello @zachwhaley - my apologies for the delay in getting these reviewed. Our team synced up with the Terraform Core engineers and discussed this PR. As currently implemented, users will need to apply changes twice on updates before they are realized in downstream resources/outputs/etc. This issue can be solved by using a CustomizeDiff, so the plan also sees the expected value changes, which in turn any references can also see those value changes at the same time. However, both local and archive providers are scheduled to be migrated to the Terraform Plugin Framework this quarter, and we have a strong preference to implement this feature using attribute plan modifiers with the framework. For now, we are going to hold off on bringing these changes in. Our plan is to reevaluate this once the migration to the plugin framework is complete. |
|
Thanks @bookshelfdave ! Is there anything I can follow to know when these changes are being worked on or completed? |
@zachwhaley the issue for tracking migration to the Terraform Plugin Framework is #112 |
|
@bendbennett I've pulled in the latest changes from the main branch. Let me know if there are any other changes I need to make. Thanks! |
|
Thanks @zachwhaley, we'll review this shortly. |
There was a problem hiding this comment.
LGTM @zachwhaley
Could you update the tests for the archive resource in same way that you have done for the data source?
@bendbennett Sure thing! I hadn't updated the tests because that resource is deprecated. I only updated the source code because the builds were failing. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Per hashicorp/terraform-provider-local#137 this brings the provider up to feature parity with all of Terraform's built-in file-reading functions
The following outputs are added to
data_archive_file:output_sha256- SHA256 checksum of archive content.output_sha512- SHA512 checksum of archive content.output_base64sha512- Base64 encoded SHA512 checksum of archive content.