Merge pull request #35760 from Jebaseelanravi/b-add-s3arn-attr

Add s3_bucket_arn to codeartifact domain resource
hashicorp · Feb 12, 2024 · 6969230 · 6969230
2 parents 068b74f + 9459b5a
commit 6969230
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 0 deletions.
diff --git a/.changelog/35760.txt b/.changelog/35760.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_codeartifact_domain: Add `s3_bucket_arn` attribute
+```
diff --git a/internal/service/codeartifact/domain.go b/internal/service/codeartifact/domain.go
@@ -72,6 +72,10 @@ func resourceDomain() *schema.Resource {
 				Type:     schema.TypeInt,
 				Computed: true,
 			},
+			"s3_bucket_arn": {
+				Type:     schema.TypeString,
+				Computed: true,
+			},
 			names.AttrTags:    tftags.TagsSchema(),
 			names.AttrTagsAll: tftags.TagsSchemaComputed(),
 		},
@@ -135,6 +139,7 @@ func resourceDomainRead(ctx context.Context, d *schema.ResourceData, meta interf
 	d.Set("encryption_key", domain.EncryptionKey)
 	d.Set("owner", domain.Owner)
 	d.Set("repository_count", domain.RepositoryCount)
+	d.Set("s3_bucket_arn", domain.S3BucketArn)
 
 	return diags
 }

diff --git a/internal/service/codeartifact/domain_test.go b/internal/service/codeartifact/domain_test.go
@@ -38,6 +38,7 @@ func testAccDomain_basic(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "domain", rName),
 					resource.TestCheckResourceAttr(resourceName, "asset_size_bytes", "0"),
 					resource.TestCheckResourceAttr(resourceName, "repository_count", "0"),
+					resource.TestCheckResourceAttrSet(resourceName, "s3_bucket_arn"),
 					resource.TestCheckResourceAttrSet(resourceName, "created_time"),
 					resource.TestCheckResourceAttrPair(resourceName, "encryption_key", "aws_kms_key.test", "arn"),
 					acctest.CheckResourceAttrAccountID(resourceName, "owner"),
@@ -73,6 +74,7 @@ func testAccDomain_defaultEncryptionKey(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "domain", rName),
 					resource.TestCheckResourceAttr(resourceName, "asset_size_bytes", "0"),
 					resource.TestCheckResourceAttr(resourceName, "repository_count", "0"),
+					resource.TestCheckResourceAttrSet(resourceName, "s3_bucket_arn"),
 					resource.TestCheckResourceAttrSet(resourceName, "created_time"),
 					acctest.CheckResourceAttrAccountID(resourceName, "owner"),
 				),

diff --git a/website/docs/r/codeartifact_domain.html.markdown b/website/docs/r/codeartifact_domain.html.markdown
@@ -34,6 +34,7 @@ This resource exports the following attributes in addition to the arguments abov
 * `arn` - The ARN of the Domain.
 * `owner` - The AWS account ID that owns the domain.
 * `repository_count` - The number of repositories in the domain.
+* `s3_bucket_arn` - The ARN of the Amazon S3 bucket that is used to store package assets in the domain.
 * `created_time` - A timestamp that represents the date and time the domain was created in [RFC3339 format](https://tools.ietf.org/html/rfc3339#section-5.8).
 * `asset_size_bytes` - The total size of all assets in the domain.
 * `tags_all` - A map of tags assigned to the resource, including those inherited from the provider [`default_tags` configuration block](https://registry.terraform.io/providers/hashicorp/aws/latest/docs#default_tags-configuration-block).