resource/aws_mq_broker: validate user password length range

aws/resource_aws_mq_broker.go

@@ -140,9 +140,10 @@ func resourceAwsMqBroker() *schema.Resource {
 							Optional: true,
 						},
 						"password": {
-							Type:      schema.TypeString,
-							Required:  true,
-							Sensitive: true,
+							Type:         schema.TypeString,
+							Required:     true,
+							Sensitive:    true,
+							ValidateFunc: validateStringLengthRange(12, 250),
 						},
 						"username": {
 							Type:     schema.TypeString,

aws/validators.go

@@ -317,6 +317,17 @@ func validateMaxLength(length int) schema.SchemaValidateFunc {
 	}
 }
 
+func validateStringLengthRange(min, max int) schema.SchemaValidateFunc {
+	return func(v interface{}, k string) (ws []string, errors []error) {
+		value := v.(string)
+		if len(value) < min || len(value) > max {
+			errors = append(errors, fmt.Errorf(
+				"%q must be %d to %d characters long. provided string length: %d", k, min, max, len(value)))
+		}
+		return
+	}
+}
+
 func validateIntegerInRange(min, max int) schema.SchemaValidateFunc {
 	return func(v interface{}, k string) (ws []string, errors []error) {
 		value := v.(int)

aws/validators_test.go

@@ -778,6 +778,26 @@ func TestValidateIntegerInRange(t *testing.T) {
 	}
 }
 
+func TestValidateStringLengthRange(t *testing.T) {
+	min := 7
+	max := 11
+	validStrings := []string{"1234567", "1234567890", "12345678901"}
+	for _, v := range validStrings {
+		_, errors := validateStringLengthRange(min, max)(v, "name")
+		if len(errors) != 0 {
+			t.Fatalf("length of %q %d should be in range [%d, %d]: %q", v, len(v), min, max, errors)
+		}
+	}
+
+	invalidStrings := []string{"123456", "123456789012"}
+	for _, v := range invalidStrings {
+		_, errors := validateStringLengthRange(min, max)(v, "name")
+		if len(errors) == 0 {
+			t.Fatalf("length of %q %d should be outside range [%d, %d]", v, len(v), min, max)
+		}
+	}
+}
+
 func TestResourceAWSElastiCacheClusterIdValidation(t *testing.T) {
 	cases := []struct {
 		Value    string

website/docs/r/mq_broker.html.markdown

@@ -81,7 +81,7 @@ The following arguments are supported:
 
 * `console_access` - (Optional) Whether to enable access to the the [ActiveMQ Web Console](http://activemq.apache.org/web-console.html) for the user.
 * `groups` - (Optional) The list of groups (20 maximum) to which the ActiveMQ user belongs.
-* `password` - (Required) The password of the user.
+* `password` - (Required) The password of the user, must be 12 to 250 characters long.
 * `username` - (Required) The username of the user.
 
 ## Attributes Reference