Merge pull request #39454 from mumoumit/f-fix-vpce-test

Add fix for OpenSearch Serverless VPCE test

.changelog/39454.txt

@@ -0,0 +1,11 @@
+```release-note:bug
+resource/aws_opensearchserverless_vpc_endpoint: Change `name` and `vpc_id` to [ForceNew](https://developer.hashicorp.com/terraform/plugin/sdkv2/schemas/schema-behaviors#forcenew)
+```
+
+```release-note:bug
+resource/aws_opensearchserverless_vpc_endpoint: Correctly set `security_group_ids`. This requires a call to the EC2 `DescribeVpcEndpoints` API
+```
+
+```release-note:bug
+data-source/aws_opensearchserverless_vpc_endpoint: Correctly set `security_group_ids`. This requires a call to the EC2 `DescribeVpcEndpoints` API
+```

internal/service/opensearchserverless/exports_test.go

@@ -10,7 +10,7 @@ var (
 	ResourceLifecyclePolicy = newResourceLifecyclePolicy
 	ResourceSecurityConfig  = newResourceSecurityConfig
 	ResourceSecurityPolicy  = newResourceSecurityPolicy
-	ResourceVPCEndpoint     = newResourceVPCEndpoint
+	ResourceVPCEndpoint     = newVPCEndpointResource
 
 	FindAccessPolicyByNameAndType    = findAccessPolicyByNameAndType
 	FindCollectionByID               = findCollectionByID

internal/service/opensearchserverless/find.go

@@ -141,31 +141,6 @@ func findSecurityPolicyByNameAndType(ctx context.Context, conn *opensearchserver
 	return out.SecurityPolicyDetail, nil
 }
 
-func findVPCEndpointByID(ctx context.Context, conn *opensearchserverless.Client, id string) (*types.VpcEndpointDetail, error) {
-	in := &opensearchserverless.BatchGetVpcEndpointInput{
-		Ids: []string{id},
-	}
-	out, err := conn.BatchGetVpcEndpoint(ctx, in)
-
-	if err != nil {
-		var nfe *types.ResourceNotFoundException
-		if errors.As(err, &nfe) {
-			return nil, &retry.NotFoundError{
-				LastError:   err,
-				LastRequest: in,
-			}
-		}
-
-		return nil, err
-	}
-
-	if out == nil || out.VpcEndpointDetails == nil || len(out.VpcEndpointDetails) == 0 {
-		return nil, tfresource.NewEmptyResultError(in)
-	}
-
-	return &out.VpcEndpointDetails[0], nil
-}
-
 func findLifecyclePolicyByNameAndType(ctx context.Context, conn *opensearchserverless.Client, name, policyType string) (*types.LifecyclePolicyDetail, error) {
 	in := &opensearchserverless.BatchGetLifecyclePolicyInput{
 		Identifiers: []types.LifecyclePolicyIdentifier{