provider: Bump Go version to 1.15 and standardize on .go-version file…

… for GitHub Actions workflows (#16557) Reference: https://github.com/hashicorp/terraform-provider-aws/blob/master/docs/MAINTAINING.md#go-default-version-update
hashicorp · Dec 15, 2020 · acf1efa · acf1efa
1 parent b6ac60a
commit acf1efa
Show file tree

Hide file tree

Showing 12 changed files with 48 additions and 15 deletions.
diff --git a/.github/workflows/acctest-terraform-lint.yml b/.github/workflows/acctest-terraform-lint.yml
@@ -7,19 +7,21 @@ on:
   pull_request:
     paths:
       - .github/workflows/acctest-terraform-lint.yml
+      - .go-version
       - aws/*_test.go
       - scripts/validate-terraform.sh
       - tools/go.mod
 
 env:
-  GO_VERSION: "1.15"
   GO111MODULE: on
 
 jobs:
   terrafmt:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      # See also: https://github.com/actions/setup-go/pull/62
+      - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ env.GO_VERSION }}
@@ -48,9 +50,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      # See also: https://github.com/actions/setup-go/pull/62
+      - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
       - uses: actions/setup-go@v2
         with:
-          go-version: ${{ env.GO_VERSION }}
+          go-version: ${{ steps.go-version.outputs.content }}
       - uses: actions/cache@v2
         continue-on-error: true
         timeout-minutes: 2

diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml
@@ -6,11 +6,11 @@ on:
       - 'release/**'
   pull_request:
     paths:
+      - .go-version
       - CHANGELOG.md
   pull_request_target:
 
 env:
-  GO_VERSION: "1.14"
   GO111MODULE: on
 
 jobs:
@@ -58,6 +58,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      # See also: https://github.com/actions/setup-go/pull/62
+      - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ env.GO_VERSION }}

diff --git a/.github/workflows/dependencies.yml b/.github/workflows/dependencies.yml
@@ -7,9 +7,6 @@ on:
       - 'release/**'
   pull_request_target:
 
-env:
-  GO_VERSION: "1.14"
-
 jobs:
   changes:
     if: github.event_name == 'pull_request_target' && !contains(fromJSON('["anGie44", "bflad", "breathingdust", "dependabot[bot]", "DrFaust92", "ewbankkit", "gdavison", "maryelizbeth", "YakDriver"]'), github.actor)
@@ -64,6 +61,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      # See also: https://github.com/actions/setup-go/pull/62
+      - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ env.GO_VERSION }}

diff --git a/.github/workflows/documentation.yml b/.github/workflows/documentation.yml
@@ -8,10 +8,10 @@ on:
       - .markdownlinkcheck.json
       - .markdownlint.yml
       - .github/workflows/documentation.yml
+      - .go-version
       - docs/**
 
 env:
-  GO_VERSION: "1.14"
   GO111MODULE: on
 
 jobs:
@@ -38,6 +38,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      # See also: https://github.com/actions/setup-go/pull/62
+      - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ env.GO_VERSION }}

diff --git a/.github/workflows/examples.yml b/.github/workflows/examples.yml
@@ -6,11 +6,11 @@ on:
   pull_request:
     paths:
       - .github/workflows/examples.yml
+      - .go-version
       - examples/**
       - tools/go.mod
 
 env:
-  GO_VERSION: "1.15"
   AWS_DEFAULT_REGION: us-west-2
 
 jobs:
@@ -28,6 +28,8 @@ jobs:
       with:
         path: ~/go/pkg/mod
         key: ${{ runner.os }}-go-pkg-mod-${{ hashFiles('go.sum') }}
+    # See also: https://github.com/actions/setup-go/pull/62
+    - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
     - uses: actions/setup-go@v2
       with:
         go-version: ${{ env.GO_VERSION }}

diff --git a/.github/workflows/snapshot.yml b/.github/workflows/snapshot.yml
@@ -6,14 +6,15 @@ on:
   workflow_dispatch:
 
 env:
-  GO_VERSION: "1.14"
   GO111MODULE: on
 
 jobs:
   goreleaser:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      # See also: https://github.com/actions/setup-go/pull/62
+      - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ env.GO_VERSION }}

diff --git a/.github/workflows/terraform_provider.yml b/.github/workflows/terraform_provider.yml
@@ -8,6 +8,7 @@ on:
   pull_request:
     paths:
       - .github/workflows/terraform_provider.yml
+      - .go-version
       - .golangci.yml
       - .goreleaser.yml
       - .semgrep.yml
@@ -26,7 +27,6 @@ on:
 
 env:
   AWS_DEFAULT_REGION: us-west-2
-  GO_VERSION: "1.14"
   GO111MODULE: on
   TERRAFORM_VERSION: "0.12.25"
 
@@ -36,6 +36,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
+    # See also: https://github.com/actions/setup-go/pull/62
+    - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
     - uses: actions/setup-go@v2
       with:
         go-version: ${{ env.GO_VERSION }}
@@ -62,6 +64,8 @@ jobs:
       with:
         path: terraform-plugin-dir
         key: ${{ runner.os }}-terraform-plugin-dir-${{ hashFiles('go.sum') }}-${{ hashFiles('aws/**') }}
+    # See also: https://github.com/actions/setup-go/pull/62
+    - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
     - if: steps.cache-terraform-plugin-dir.outputs.cache-hit != 'true' || steps.cache-terraform-plugin-dir.outcome == 'failure'
       uses: actions/setup-go@v2
       with:
@@ -126,6 +130,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
+    # See also: https://github.com/actions/setup-go/pull/62
+    - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
     - uses: actions/setup-go@v2
       with:
         go-version: ${{ env.GO_VERSION }}
@@ -155,6 +161,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
+    # See also: https://github.com/actions/setup-go/pull/62
+    - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
     - uses: actions/setup-go@v2
       with:
         go-version: ${{ env.GO_VERSION }}
@@ -186,6 +194,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
+    # See also: https://github.com/actions/setup-go/pull/62
+    - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
     - uses: actions/setup-go@v2
       with:
         go-version: ${{ env.GO_VERSION }}
@@ -212,6 +222,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
+    # See also: https://github.com/actions/setup-go/pull/62
+    - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
     - uses: actions/setup-go@v2
       with:
         go-version: ${{ env.GO_VERSION }}
@@ -240,6 +252,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
+    # See also: https://github.com/actions/setup-go/pull/62
+    - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
     - uses: actions/setup-go@v2
       with:
         go-version: ${{ env.GO_VERSION }}
@@ -267,6 +281,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      # See also: https://github.com/actions/setup-go/pull/62
+      - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ env.GO_VERSION }}
@@ -300,6 +316,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
+    # See also: https://github.com/actions/setup-go/pull/62
+    - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
     - uses: actions/setup-go@v2
       with:
         go-version: ${{ env.GO_VERSION }}

diff --git a/.github/workflows/website.yml b/.github/workflows/website.yml
@@ -10,13 +10,13 @@ on:
   pull_request:
     paths:
       - .github/workflows/website.yml
+      - .go-version
       - .markdownlinkcheck.json
       - .markdownlint.yml
       - website/docs/**
       - tools/go.mod
 
 env:
-  GO_VERSION: "1.14"
   GO111MODULE: on
 
 jobs:
@@ -52,6 +52,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      # See also: https://github.com/actions/setup-go/pull/62
+      - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ env.GO_VERSION }}
@@ -67,6 +69,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      # See also: https://github.com/actions/setup-go/pull/62
+      - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ env.GO_VERSION }}
@@ -82,6 +86,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      # See also: https://github.com/actions/setup-go/pull/62
+      - run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
       - uses: actions/setup-go@v2
         with:
           go-version: ${{ env.GO_VERSION }}

diff --git a/.go-version b/.go-version
@@ -1 +1 @@
-1.14.5
+1.15.5
diff --git a/docs/DEVELOPMENT.md b/docs/DEVELOPMENT.md
@@ -3,7 +3,7 @@
 ## Requirements
 
 - [Terraform](https://www.terraform.io/downloads.html) 0.12.26+ (to run acceptance tests)
-- [Go](https://golang.org/doc/install) 1.14 (to build the provider plugin)
+- [Go](https://golang.org/doc/install) 1.15 (to build the provider plugin)
 
 ## Quick Start
 

diff --git a/docs/MAINTAINING.md b/docs/MAINTAINING.md
@@ -88,7 +88,6 @@ Ensure that the following steps are tracked within the issue and completed withi
 - Verify `goreleaser build --snapshot` succeeds for all currently supported architectures
 - Verify `goenv` support for the new version
 - Update `docs/DEVELOPMENT.md`
-- Update `.github/workflows/*.yml`
 - Update `.go-version`
 - Update `CHANGELOG.md` detailing the update and mention any notes practitioners need to be aware of.
 

diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/terraform-providers/terraform-provider-aws
 
-go 1.14
+go 1.15
 
 require (
 	github.com/aws/aws-sdk-go v1.36.7