Merge pull request #39489 from silvaalbert/f-codeconnections

add codeconnections service
hashicorp · Sep 26, 2024 · c3c97be · c3c97be
2 parents 92ffb48 + f896769
commit c3c97be
Show file tree

Hide file tree

Showing 24 changed files with 1,703 additions and 826 deletions.
diff --git a/.ci/.semgrep-service-name0.yml b/.ci/.semgrep-service-name0.yml
@@ -3533,6 +3533,67 @@ rules:
           patterns:
             - pattern-regex: "(?i)CodeCommit"
     severity: WARNING
+  - id: codeconnections-in-func-name
+    languages:
+      - go
+    message: Do not use "CodeConnections" in func name inside codeconnections package
+    paths:
+      include:
+        - internal/service/codeconnections
+      exclude:
+        - internal/service/codeconnections/list_pages_gen.go
+    patterns:
+      - pattern: func $NAME( ... )
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)CodeConnections"
+      - focus-metavariable: $NAME
+      - pattern-not: func $NAME($T *testing.T)
+    severity: WARNING
+  - id: codeconnections-in-test-name
+    languages:
+      - go
+    message: Include "CodeConnections" in test name
+    paths:
+      include:
+        - internal/service/codeconnections/*_test.go
+    patterns:
+      - pattern: func $NAME( ... )
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-not-regex: "^TestAccCodeConnections"
+            - pattern-regex: ^TestAcc.*
+    severity: WARNING
+  - id: codeconnections-in-const-name
+    languages:
+      - go
+    message: Do not use "CodeConnections" in const name inside codeconnections package
+    paths:
+      include:
+        - internal/service/codeconnections
+    patterns:
+      - pattern: const $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)CodeConnections"
+    severity: WARNING
+  - id: codeconnections-in-var-name
+    languages:
+      - go
+    message: Do not use "CodeConnections" in var name inside codeconnections package
+    paths:
+      include:
+        - internal/service/codeconnections
+    patterns:
+      - pattern: var $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)CodeConnections"
+    severity: WARNING
   - id: codedeploy-in-func-name
     languages:
       - go
@@ -4221,51 +4282,3 @@ rules:
           patterns:
             - pattern-regex: "(?i)ConfigService"
     severity: WARNING
-  - id: configservice-in-var-name
-    languages:
-      - go
-    message: Do not use "ConfigService" in var name inside configservice package
-    paths:
-      include:
-        - internal/service/configservice
-    patterns:
-      - pattern: var $NAME = ...
-      - metavariable-pattern:
-          metavariable: $NAME
-          patterns:
-            - pattern-regex: "(?i)ConfigService"
-    severity: WARNING
-  - id: connect-in-func-name
-    languages:
-      - go
-    message: Do not use "Connect" in func name inside connect package
-    paths:
-      include:
-        - internal/service/connect
-      exclude:
-        - internal/service/connect/list_pages_gen.go
-    patterns:
-      - pattern: func $NAME( ... )
-      - metavariable-pattern:
-          metavariable: $NAME
-          patterns:
-            - pattern-regex: "(?i)Connect"
-            - pattern-not-regex: .*uickConnect.*
-      - focus-metavariable: $NAME
-      - pattern-not: func $NAME($T *testing.T)
-    severity: WARNING
-  - id: connect-in-test-name
-    languages:
-      - go
-    message: Include "Connect" in test name
-    paths:
-      include:
-        - internal/service/connect/*_test.go
-    patterns:
-      - pattern: func $NAME( ... )
-      - metavariable-pattern:
-          metavariable: $NAME
-          patterns:
-            - pattern-not-regex: "^TestAccConnect"
-            - pattern-regex: ^TestAcc.*
-    severity: WARNING
diff --git a/.ci/.semgrep-service-name1.yml b/.ci/.semgrep-service-name1.yml
@@ -1,5 +1,53 @@
 # Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
 rules:
+  - id: configservice-in-var-name
+    languages:
+      - go
+    message: Do not use "ConfigService" in var name inside configservice package
+    paths:
+      include:
+        - internal/service/configservice
+    patterns:
+      - pattern: var $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)ConfigService"
+    severity: WARNING
+  - id: connect-in-func-name
+    languages:
+      - go
+    message: Do not use "Connect" in func name inside connect package
+    paths:
+      include:
+        - internal/service/connect
+      exclude:
+        - internal/service/connect/list_pages_gen.go
+    patterns:
+      - pattern: func $NAME( ... )
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)Connect"
+            - pattern-not-regex: .*uickConnect.*
+      - focus-metavariable: $NAME
+      - pattern-not: func $NAME($T *testing.T)
+    severity: WARNING
+  - id: connect-in-test-name
+    languages:
+      - go
+    message: Include "Connect" in test name
+    paths:
+      include:
+        - internal/service/connect/*_test.go
+    patterns:
+      - pattern: func $NAME( ... )
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-not-regex: "^TestAccConnect"
+            - pattern-regex: ^TestAcc.*
+    severity: WARNING
   - id: connect-in-const-name
     languages:
       - go
@@ -4229,35 +4277,3 @@ rules:
           patterns:
             - pattern-regex: "(?i)IoT"
     severity: WARNING
-  - id: iot-in-var-name
-    languages:
-      - go
-    message: Do not use "IoT" in var name inside iot package
-    paths:
-      include:
-        - internal/service/iot
-    patterns:
-      - pattern: var $NAME = ...
-      - metavariable-pattern:
-          metavariable: $NAME
-          patterns:
-            - pattern-regex: "(?i)IoT"
-    severity: WARNING
-  - id: iotanalytics-in-func-name
-    languages:
-      - go
-    message: Do not use "IoTAnalytics" in func name inside iotanalytics package
-    paths:
-      include:
-        - internal/service/iotanalytics
-      exclude:
-        - internal/service/iotanalytics/list_pages_gen.go
-    patterns:
-      - pattern: func $NAME( ... )
-      - metavariable-pattern:
-          metavariable: $NAME
-          patterns:
-            - pattern-regex: "(?i)IoTAnalytics"
-      - focus-metavariable: $NAME
-      - pattern-not: func $NAME($T *testing.T)
-    severity: WARNING
diff --git a/.ci/.semgrep-service-name2.yml b/.ci/.semgrep-service-name2.yml
@@ -1,5 +1,37 @@
 # Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
 rules:
+  - id: iot-in-var-name
+    languages:
+      - go
+    message: Do not use "IoT" in var name inside iot package
+    paths:
+      include:
+        - internal/service/iot
+    patterns:
+      - pattern: var $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)IoT"
+    severity: WARNING
+  - id: iotanalytics-in-func-name
+    languages:
+      - go
+    message: Do not use "IoTAnalytics" in func name inside iotanalytics package
+    paths:
+      include:
+        - internal/service/iotanalytics
+      exclude:
+        - internal/service/iotanalytics/list_pages_gen.go
+    patterns:
+      - pattern: func $NAME( ... )
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)IoTAnalytics"
+      - focus-metavariable: $NAME
+      - pattern-not: func $NAME($T *testing.T)
+    severity: WARNING
   - id: iotanalytics-in-test-name
     languages:
       - go
@@ -4248,17 +4280,3 @@ rules:
       - focus-metavariable: $NAME
       - pattern-not: func $NAME($T *testing.T)
     severity: WARNING
-  - id: recyclebin-in-const-name
-    languages:
-      - go
-    message: Do not use "recyclebin" in const name inside rbin package
-    paths:
-      include:
-        - internal/service/rbin
-    patterns:
-      - pattern: const $NAME = ...
-      - metavariable-pattern:
-          metavariable: $NAME
-          patterns:
-            - pattern-regex: "(?i)recyclebin"
-    severity: WARNING
diff --git a/.ci/.semgrep-service-name3.yml b/.ci/.semgrep-service-name3.yml
@@ -1,5 +1,19 @@
 # Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
 rules:
+  - id: recyclebin-in-const-name
+    languages:
+      - go
+    message: Do not use "recyclebin" in const name inside rbin package
+    paths:
+      include:
+        - internal/service/rbin
+    patterns:
+      - pattern: const $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)recyclebin"
+    severity: WARNING
   - id: recyclebin-in-var-name
     languages:
       - go

diff --git a/.ci/semgrep/migrate/context.yml b/.ci/semgrep/migrate/context.yml
@@ -28,6 +28,7 @@ rules:
       - pattern-not: conn.Handlers.$X(...)
       - pattern-not: conn.Handlers.$X.$Y(...)
       - pattern-not: conn.Options()
+      - pattern-not: codeconnections_sdkv2.$API()
       - pattern-not: codestarconnections_sdkv2.$API()
       - pattern-not: connect_sdkv2.$API()
       - pattern-not: connectcases_sdkv2.$API()

diff --git a/.github/labeler-issue-triage.yml b/.github/labeler-issue-triage.yml
@@ -153,6 +153,8 @@ service/codecatalyst:
   - '((\*|-)\s*`?|(data|resource)\s+"?)aws_codecatalyst_'
 service/codecommit:
   - '((\*|-)\s*`?|(data|resource)\s+"?)aws_codecommit_'
+service/codeconnections:
+  - '((\*|-)\s*`?|(data|resource)\s+"?)aws_codeconnections_'
 service/codeguruprofiler:
   - '((\*|-)\s*`?|(data|resource)\s+"?)aws_codeguruprofiler_'
 service/codegurureviewer:

diff --git a/.github/labeler-pr-triage.yml b/.github/labeler-pr-triage.yml
@@ -495,6 +495,12 @@ service/codecommit:
           - any-glob-to-any-file:
               - 'internal/service/codecommit/**/*'
               - 'website/**/codecommit_*'
+service/codeconnections:
+  - any:
+      - changed-files:
+          - any-glob-to-any-file:
+              - 'internal/service/codeconnections/**/*'
+              - 'website/**/codeconnections_*'
 service/codeguruprofiler:
   - any:
       - changed-files:

diff --git a/.teamcity/components/generated/services_all.kt b/.teamcity/components/generated/services_all.kt
@@ -49,6 +49,7 @@ val services = mapOf(
     "codebuild" to ServiceSpec("CodeBuild"),
     "codecatalyst" to ServiceSpec("CodeCatalyst"),
     "codecommit" to ServiceSpec("CodeCommit"),
+    "codeconnections" to ServiceSpec("CodeConnections"),
     "codeguruprofiler" to ServiceSpec("CodeGuru Profiler"),
     "codegurureviewer" to ServiceSpec("CodeGuru Reviewer"),
     "codepipeline" to ServiceSpec("CodePipeline"),