Merge pull request #17382 from borancar/main

Fix data source aws_vpc_peering_connections

.changelog/17382.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+data-source/aws_vpc_peering_connections: Return empty array instead of error when no connections found.
+```

internal/service/ec2/vpc_peering_connections_data_source.go

@@ -47,8 +47,8 @@ func dataSourceVPCPeeringConnectionsRead(d *schema.ResourceData, meta interface{
 	if err != nil {
 		return err
 	}
-	if resp == nil || len(resp.VpcPeeringConnections) == 0 {
-		return fmt.Errorf("no matching VPC peering connections found")
+	if resp == nil {
+		return fmt.Errorf("error reading EC2 VPC Peering Connections: empty response")
 	}
 
 	var ids []string

internal/service/ec2/vpc_peering_connections_data_source_test.go

@@ -24,6 +24,22 @@ func TestAccEC2VPCPeeringConnectionsDataSource_basic(t *testing.T) {
 	})
 }
 
+func TestAccEC2VPCPeeringConnectionsDataSource_NoMatches(t *testing.T) {
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { acctest.PreCheck(t) },
+		ErrorCheck:        acctest.ErrorCheck(t, ec2.EndpointsID),
+		ProviderFactories: acctest.ProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccVPCPeeringConnectionsDataSourceConfig_NoMatches,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("data.aws_vpc_peering_connections.test", "ids.#", "0"),
+				),
+			},
+		},
+	})
+}
+
 const testAccVPCPeeringConnectionsDataSourceConfig = `
 resource "aws_vpc" "foo" {
   cidr_block = "10.1.0.0/16"
@@ -81,3 +97,11 @@ data "aws_vpc_peering_connections" "test_by_filters" {
   }
 }
 `
+
+const testAccVPCPeeringConnectionsDataSourceConfig_NoMatches = `
+data "aws_vpc_peering_connections" "test" {
+  tags = {
+    Name = "Non-Existent"
+  }
+}
+`