Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_appmesh_route,r/aws_appmesh_virtual_node,r/aws_appmesh_virtual_router: Support gRPC and HTTP/2 services #11669

Merged
merged 13 commits into from
Oct 1, 2020
Merged

r/aws_appmesh_route,r/aws_appmesh_virtual_node,r/aws_appmesh_virtual_router: Support gRPC and HTTP/2 services #11669

merged 13 commits into from
Oct 1, 2020

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 19, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10803.
Relates: #14601.

Release note for CHANGELOG:

resource/aws_appmesh_route: Add `grpc_route` and `http2_route` attributes to support gRPC and HTTP/2 services
resource/aws_appmesh_virtual_node: Add `grpc` and `http2` as valid values for the `protocol` attribute
resource/aws_appmesh_virtual_router: Add `grpc` and `http2` as valid values for the `protocol` attribute

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/Route/grpcRoute
=== RUN   TestAccAWSAppmesh/Route/http2Route
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh (539.34s)
    --- PASS: TestAccAWSAppmesh/Route (429.82s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (51.69s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (49.77s)
        --- PASS: TestAccAWSAppmesh/Route/tags (73.48s)
        --- PASS: TestAccAWSAppmesh/Route/grpcRoute (50.72s)
        --- PASS: TestAccAWSAppmesh/Route/http2Route (50.98s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (51.27s)
        --- PASS: TestAccAWSAppmesh/Route/httpRetryPolicy (50.96s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (50.94s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (109.53s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (45.55s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (63.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	539.379s

Includes changes from #10402 and #11660.

@ewbankkit ewbankkit requested a review from a team January 19, 2020 23:56
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jan 19, 2020
@ewbankkit ewbankkit changed the title [WIP] r/aws_appmesh_route: Support gRPC and HTTP/2 services r/aws_appmesh_route: Support gRPC and HTTP/2 services Jan 20, 2020
@ewbankkit
Copy link
Contributor Author

Removed WIP.
Ready for review.

@ewbankkit
Copy link
Contributor Author

Rebased to remove merge conflicts.
Re-ran acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/Route/grpcRoute
=== RUN   TestAccAWSAppmesh/Route/http2Route
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh (536.64s)
    --- PASS: TestAccAWSAppmesh/Route (427.21s)
        --- PASS: TestAccAWSAppmesh/Route/httpRetryPolicy (51.00s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (50.84s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (50.68s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (50.89s)
        --- PASS: TestAccAWSAppmesh/Route/tags (71.32s)
        --- PASS: TestAccAWSAppmesh/Route/grpcRoute (50.65s)
        --- PASS: TestAccAWSAppmesh/Route/http2Route (50.99s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (50.84s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (109.44s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (45.38s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (64.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	536.686s

@ewbankkit
Copy link
Contributor Author

Rebased.
Re-ran acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/ -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/Route/grpcRoute
=== RUN   TestAccAWSAppmesh/Route/http2Route
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh (537.75s)
    --- PASS: TestAccAWSAppmesh/Route (428.52s)
        --- PASS: TestAccAWSAppmesh/Route/tags (72.36s)
        --- PASS: TestAccAWSAppmesh/Route/grpcRoute (51.04s)
        --- PASS: TestAccAWSAppmesh/Route/http2Route (51.50s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (51.06s)
        --- PASS: TestAccAWSAppmesh/Route/httpRetryPolicy (51.69s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (51.24s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (49.93s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (49.70s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (109.23s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (45.68s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (63.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	537.783s

@ewbankkit ewbankkit mentioned this pull request Mar 25, 2020
Closed
This was referenced Apr 9, 2020
Closed
Closed
@AdamDM
Copy link

AdamDM commented Apr 16, 2020

I couldn't get this working until I added the changes from this to it ece07d6

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Apr 16, 2020 •
edited
Loading

@AdamDM Thanks; I'll merge #12744 into this PR if the author is OK with that.

@stijndehaes
Copy link
Contributor

@AdamDM Thanks; I'll merge #12744 into this PR if the author is OK with that.

go ahead!

@ewbankkit
Copy link
Contributor Author

Incorporated changes from #12744 and modified tests for aws_appmesh_virtual_router gRPC and HTTP/2 protocols:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/Route/grpcRoute
=== RUN   TestAccAWSAppmesh/Route/http2Route
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh/Route/httpRoute
--- PASS: TestAccAWSAppmesh (536.98s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (109.52s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (64.84s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (44.67s)
    --- PASS: TestAccAWSAppmesh/Route (427.47s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (50.77s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (50.70s)
        --- PASS: TestAccAWSAppmesh/Route/tags (71.37s)
        --- PASS: TestAccAWSAppmesh/Route/grpcRoute (50.81s)
        --- PASS: TestAccAWSAppmesh/Route/http2Route (51.67s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (50.53s)
        --- PASS: TestAccAWSAppmesh/Route/httpRetryPolicy (51.11s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (50.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	537.033s

@ewbankkit

This comment has been minimized.

Sign in to view
@ewbankkit ewbankkit mentioned this pull request May 18, 2020
Closed
@ewbankkit
Copy link
Contributor Author

ewbankkit commented May 21, 2020 •
edited
Loading

Rebase to remove merge conflicts.

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh/VirtualNode/'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode/ -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/basic
=== RUN   TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh/VirtualNode/logging
=== RUN   TestAccAWSAppmesh/VirtualNode/tags
--- PASS: TestAccAWSAppmesh (301.77s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (301.77s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (28.09s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery (117.55s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/listenerHealthChecks (45.81s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/logging (45.58s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/tags (64.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	301.825s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh/Route/'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/ -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/grpcRoute
=== RUN   TestAccAWSAppmesh/Route/http2Route
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh (536.28s)
    --- PASS: TestAccAWSAppmesh/Route (427.64s)
        --- PASS: TestAccAWSAppmesh/Route/grpcRoute (52.28s)
        --- PASS: TestAccAWSAppmesh/Route/http2Route (51.36s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (50.85s)
        --- PASS: TestAccAWSAppmesh/Route/httpRetryPolicy (50.92s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (50.68s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (50.25s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (50.50s)
        --- PASS: TestAccAWSAppmesh/Route/tags (70.81s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (108.64s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (45.45s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (63.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	536.334s

@ewbankkit
Copy link
Contributor Author

Rebased to remove merge conflicts.
Use new TypeSet acceptance check tests routines - #13556.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh/Route/'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/ -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/Route/grpcRoute
=== RUN   TestAccAWSAppmesh/Route/http2Route
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh (609.10s)
    --- PASS: TestAccAWSAppmesh/Route (497.03s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (51.51s)
        --- PASS: TestAccAWSAppmesh/Route/httpRetryPolicy (51.39s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (71.47s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (52.58s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (72.59s)
        --- PASS: TestAccAWSAppmesh/Route/tags (73.42s)
        --- PASS: TestAccAWSAppmesh/Route/grpcRoute (72.79s)
        --- PASS: TestAccAWSAppmesh/Route/http2Route (51.28s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (112.07s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (46.21s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (65.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	609.171s

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 26, 2020
@ewbankkit ewbankkit changed the title r/aws_appmesh_route: Support gRPC and HTTP/2 services r/aws_appmesh_route,r/aws_appmesh_virtual_router: Support gRPC and HTTP/2 services Sep 17, 2020
@ewbankkit ewbankkit changed the title r/aws_appmesh_route,r/aws_appmesh_virtual_router: Support gRPC and HTTP/2 services r/aws_appmesh_route,r/aws_appmesh_virtual_node,r/aws_appmesh_virtual_router: Support gRPC and HTTP/2 services Sep 17, 2020
@ewbankkit
Copy link
Contributor Author

Rebased and fixed merge conflicts.
Re-ran acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualService
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualService/tags
=== RUN   TestAccAWSAppmesh_serial/Mesh
=== RUN   TestAccAWSAppmesh_serial/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh_serial/Mesh/tags
=== RUN   TestAccAWSAppmesh_serial/Mesh/basic
--- PASS: TestAccAWSAppmesh_serial (928.20s)
    --- PASS: TestAccAWSAppmesh_serial/Route (374.85s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (55.29s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (38.22s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (54.46s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (55.72s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (54.41s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (39.10s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (39.54s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (38.12s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (244.71s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (48.78s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (21.49s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (105.94s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (34.63s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (33.89s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (82.30s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (34.00s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (48.31s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualService (128.49s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (39.65s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (34.58s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (54.26s)
    --- PASS: TestAccAWSAppmesh_serial/Mesh (97.85s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (38.36s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (42.28s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (17.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	928.243s

ewbankkit and others added 13 commits September 30, 2020 20:48
@ewbankkit
r/aws_appmesh_route: Add support for retry policies.
0d18fcb
@ewbankkit
r/aws_appmesh_route: Add support for retry policies.
872f98d
@ewbankkit
r/aws_appmesh_route: Support gRPC and HTTP/2 services.
794115c
@stijndehaes @ewbankkit
Support new grpc, http2 port protocols for app mesh virtual router
402f353
@ewbankkit
r/aws_appmesh_virtual_router: Test gRPC and HTTP/2 listener protocols.
8e6d4d5
@ewbankkit
r/aws_appmesh_virtual_node: Add gRPC and HTTP/2 listener protocols.
3a9bae4 
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh/VirtualNode/'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode/ -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/basic
=== RUN   TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh/VirtualNode/logging
=== RUN   TestAccAWSAppmesh/VirtualNode/tags
--- PASS: TestAccAWSAppmesh (299.07s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (299.07s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (27.62s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery (117.22s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/listenerHealthChecks (46.57s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/logging (44.16s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/tags (63.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	299.124s
@ewbankkit
r/aws_appmesh_route: Correct acceptance tests after removing custom h…
cb70df6 
…ash functions.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh/Route/'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/ -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/grpcRoute
=== RUN   TestAccAWSAppmesh/Route/http2Route
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh (536.28s)
    --- PASS: TestAccAWSAppmesh/Route (427.64s)
        --- PASS: TestAccAWSAppmesh/Route/grpcRoute (52.28s)
        --- PASS: TestAccAWSAppmesh/Route/http2Route (51.36s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (50.85s)
        --- PASS: TestAccAWSAppmesh/Route/httpRetryPolicy (50.92s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (50.68s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (50.25s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (50.50s)
        --- PASS: TestAccAWSAppmesh/Route/tags (70.81s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (108.64s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (45.45s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (63.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	536.334s
@ewbankkit
r/aws_appmesh_route: Correct acceptance tests after merge of hashicor…
9499bb0 
…p#13539.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh/Route/'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/ -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/Route/grpcRoute
=== RUN   TestAccAWSAppmesh/Route/http2Route
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh (599.58s)
    --- PASS: TestAccAWSAppmesh/Route (489.49s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (51.90s)
        --- PASS: TestAccAWSAppmesh/Route/httpRetryPolicy (51.97s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (70.76s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (50.99s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (70.80s)
        --- PASS: TestAccAWSAppmesh/Route/tags (71.10s)
        --- PASS: TestAccAWSAppmesh/Route/grpcRoute (70.84s)
        --- PASS: TestAccAWSAppmesh/Route/http2Route (51.12s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (110.09s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (45.51s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (64.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	599.643s
@ewbankkit
r/aws_appmesh_route: Modify acceptance tests for hashicorp#13556.
3330750
@ewbankkit
r/aws_appmesh_route: Update resource testing and documentation to 0.1…
79a3d85 
…2 syntax.
@ewbankkit
r/aws_appmesh_virtual_node: Use '_Values()' (hashicorp#14601).
1053fb6 
r/aws_appmesh_virtual_router: Use '_Values()' (hashicorp#14601).

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh/Route/'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/ -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh_serial (445.49s)
    --- PASS: TestAccAWSAppmesh_serial/Route (365.54s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (53.92s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (54.25s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (53.66s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (37.42s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (37.67s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (37.44s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (53.63s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (37.54s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (79.94s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (32.84s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (47.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	445.526s
@ewbankkit
Remove duplicate example in aws_appmesh_route documentation.
c010e5a
@ewbankkit
r/aws_appmesh_route: Additional checks for 'mesh_owner' and 'resource…
db690d1 
…_owner'.
@ewbankkit
Copy link
Contributor Author

Rebased and fixed merge conflicts.
Re-ran acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Mesh
=== RUN   TestAccAWSAppmesh_serial/Mesh/basic
=== RUN   TestAccAWSAppmesh_serial/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh_serial/Mesh/tags
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm
    resource_aws_appmesh_virtual_node_test.go:597: [INFO] Got non-empty plan, as expected
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tls
    resource_aws_appmesh_virtual_node_test.go:389: [INFO] Got non-empty plan, as expected
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualService
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualService/tags
--- PASS: TestAccAWSAppmesh_serial (1156.81s)
    --- PASS: TestAccAWSAppmesh_serial/Mesh (98.18s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (17.66s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (38.11s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (42.41s)
    --- PASS: TestAccAWSAppmesh_serial/Route (380.74s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (55.65s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (57.21s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (56.46s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (39.04s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (39.05s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (39.11s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (55.02s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (39.19s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (467.13s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (34.01s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm (61.38s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (34.46s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (34.85s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (49.70s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (19.70s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile (34.36s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (106.55s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tls (92.11s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (82.12s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (33.36s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (48.76s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualService (128.64s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (38.92s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (34.40s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (55.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1156.854s

DrFaust92
DrFaust92 suggested changes Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

-- FAIL: TestAccAWSAppmesh_serial (2467.58s)
    --- PASS: TestAccAWSAppmesh_serial/Mesh (224.73s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (37.86s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (84.46s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (102.41s)
    --- FAIL: TestAccAWSAppmesh_serial/Route (909.10s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (120.83s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (123.10s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (83.29s)
        --- FAIL: TestAccAWSAppmesh_serial/Route/httpHeader (178.07s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (84.45s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (116.27s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (84.94s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (118.15s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (880.74s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (44.14s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm (118.09s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (156.77s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (73.40s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (71.28s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile (71.14s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (72.02s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tls (164.08s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (109.82s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (171.58s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (69.37s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (102.20s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualService (281.44s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (83.29s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (79.41s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (118.74s)

    --- PASS: TestAccAWSAppmesh_serial/Route (92.54s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (92.54s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s)
PASS

DrFaust92
DrFaust92 approved these changes Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breathingdust
Copy link
Member

breathingdust commented Oct 1, 2020 •
edited
Loading

LGTM! 🚀 Thanks @ewbankkit

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualService
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualService/tags
=== RUN   TestAccAWSAppmesh_serial/Mesh
=== RUN   TestAccAWSAppmesh_serial/Mesh/basic
=== RUN   TestAccAWSAppmesh_serial/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh_serial/Mesh/tags
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tls
    resource_aws_appmesh_virtual_node_test.go:389: [INFO] Got non-empty plan, as expected
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm
    resource_aws_appmesh_virtual_node_test.go:597: [INFO] Got non-empty plan, as expected
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh_serial (988.89s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualService (101.84s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (30.52s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (28.39s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (42.92s)
    --- PASS: TestAccAWSAppmesh_serial/Mesh (86.38s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (15.75s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (34.19s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (36.44s)
    --- PASS: TestAccAWSAppmesh_serial/Route (307.72s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (30.49s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (47.05s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (45.78s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (46.29s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (31.43s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (31.99s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (30.46s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (44.23s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (425.87s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (28.81s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (28.53s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tls (68.26s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (44.89s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (16.63s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyAcm (58.80s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/clientPolicyFile (27.63s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (121.88s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (30.44s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (67.08s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (27.03s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (40.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	990.820s

@breathingdust breathingdust added this to the v3.9.0 milestone Oct 1, 2020
@breathingdust breathingdust merged commit 1e93dff into hashicorp:master Oct 1, 2020
breathingdust added a commit that referenced this pull request Oct 1, 2020
@breathingdust
Update CHANGELOG for #11669
8a462cc
@ewbankkit ewbankkit deleted the issue-10803 branch October 1, 2020 16:37
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/appmesh Issues and PRs that pertain to the appmesh service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

AWS App Mesh now supports HTTP2 and gRPC services
5 participants
@ewbankkit @AdamDM @stijndehaes @breathingdust @DrFaust92