Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_appmesh_route: Add support for HTTP header-based routing and route priorities #10402

Merged
merged 1 commit into from
Feb 20, 2020
Merged

r/aws_appmesh_route: Add support for HTTP header-based routing and route priorities #10402

merged 1 commit into from
Feb 20, 2020

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9802.
Replaces #9803, #9964.

Release note for CHANGELOG:

resource/aws_appmesh_route: Add `priority` and `header` attributes to support route priorities and HTTP header-based routing

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
go: finding github.com/terraform-providers/terraform-provider-tls v2.1.1+incompatible
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh/VirtualService
=== RUN   TestAccAWSAppmesh/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh/VirtualService/virtualRouter
=== RUN   TestAccAWSAppmesh/VirtualService/tags
=== RUN   TestAccAWSAppmesh/Mesh
=== RUN   TestAccAWSAppmesh/Mesh/basic
=== RUN   TestAccAWSAppmesh/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh/Mesh/tags
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/basic
=== RUN   TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh/VirtualNode/logging
=== RUN   TestAccAWSAppmesh/VirtualNode/tags
--- PASS: TestAccAWSAppmesh (752.19s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (83.46s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (34.89s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (48.57s)
    --- PASS: TestAccAWSAppmesh/VirtualService (130.40s)
        --- PASS: TestAccAWSAppmesh/VirtualService/virtualNode (39.33s)
        --- PASS: TestAccAWSAppmesh/VirtualService/virtualRouter (36.55s)
        --- PASS: TestAccAWSAppmesh/VirtualService/tags (54.52s)
    --- PASS: TestAccAWSAppmesh/Mesh (95.06s)
        --- PASS: TestAccAWSAppmesh/Mesh/basic (17.70s)
        --- PASS: TestAccAWSAppmesh/Mesh/egressFilter (36.11s)
        --- PASS: TestAccAWSAppmesh/Mesh/tags (41.25s)
    --- PASS: TestAccAWSAppmesh/Route (198.89s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (39.47s)
        --- PASS: TestAccAWSAppmesh/Route/tags (40.73s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (39.52s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (39.84s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (39.34s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (244.38s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (20.96s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery (106.20s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/listenerHealthChecks (34.43s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/logging (34.27s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/tags (48.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	752.208s

@ewbankkit ewbankkit requested a review from a team October 6, 2019 22:19
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 6, 2019
@ewbankkit
Copy link
Contributor Author

Reduced the number of diffs compared to #9964.

@ewbankkit
Copy link
Contributor Author

Rebased and verified that all the checks go green after #10460 was merged.
Re-ran acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/logging
=== RUN   TestAccAWSAppmesh/VirtualNode/tags
=== RUN   TestAccAWSAppmesh/VirtualNode/basic
=== RUN   TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh/VirtualService
=== RUN   TestAccAWSAppmesh/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh/VirtualService/virtualRouter
=== RUN   TestAccAWSAppmesh/VirtualService/tags
=== RUN   TestAccAWSAppmesh/Mesh
=== RUN   TestAccAWSAppmesh/Mesh/tags
=== RUN   TestAccAWSAppmesh/Mesh/basic
=== RUN   TestAccAWSAppmesh/Mesh/egressFilter
--- PASS: TestAccAWSAppmesh (785.10s)
    --- PASS: TestAccAWSAppmesh/Route (206.48s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (40.94s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (41.20s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (41.25s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (40.65s)
        --- PASS: TestAccAWSAppmesh/Route/tags (42.44s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (253.94s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/logging (35.05s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/tags (51.60s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (21.84s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery (109.58s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/listenerHealthChecks (35.87s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (87.73s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (36.98s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (50.75s)
    --- PASS: TestAccAWSAppmesh/VirtualService (136.31s)
        --- PASS: TestAccAWSAppmesh/VirtualService/virtualNode (41.36s)
        --- PASS: TestAccAWSAppmesh/VirtualService/virtualRouter (38.43s)
        --- PASS: TestAccAWSAppmesh/VirtualService/tags (56.53s)
    --- PASS: TestAccAWSAppmesh/Mesh (100.65s)
        --- PASS: TestAccAWSAppmesh/Mesh/tags (43.62s)
        --- PASS: TestAccAWSAppmesh/Mesh/basic (18.44s)
        --- PASS: TestAccAWSAppmesh/Mesh/egressFilter (38.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	785.178s

@ewbankkit ewbankkit force-pushed the issue-9802-MkIII branch 2 times, most recently from 38f98a0 to d879319 Compare December 17, 2019 22:13
@ewbankkit
Copy link
Contributor Author

Rebased to remove merge conflict.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh/Route'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
--- PASS: TestAccAWSAppmesh (389.52s)
    --- PASS: TestAccAWSAppmesh/Route (277.76s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (52.25s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (50.64s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (50.72s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (51.38s)
        --- PASS: TestAccAWSAppmesh/Route/tags (72.78s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (111.76s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (65.13s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (46.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	389.599s

@ewbankkit
Copy link
Contributor Author

Rebased to master and re-ran acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh/VirtualService
=== RUN   TestAccAWSAppmesh/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh/VirtualService/virtualRouter
=== RUN   TestAccAWSAppmesh/VirtualService/tags
=== RUN   TestAccAWSAppmesh/Mesh
=== RUN   TestAccAWSAppmesh/Mesh/basic
=== RUN   TestAccAWSAppmesh/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh/Mesh/tags
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/basic
=== RUN   TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh/VirtualNode/logging
=== RUN   TestAccAWSAppmesh/VirtualNode/tags
--- PASS: TestAccAWSAppmesh (987.03s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (111.16s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (46.45s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (64.71s)
    --- PASS: TestAccAWSAppmesh/VirtualService (168.49s)
        --- PASS: TestAccAWSAppmesh/VirtualService/virtualNode (50.00s)
        --- PASS: TestAccAWSAppmesh/VirtualService/virtualRouter (47.86s)
        --- PASS: TestAccAWSAppmesh/VirtualService/tags (70.61s)
    --- PASS: TestAccAWSAppmesh/Mesh (131.64s)
        --- PASS: TestAccAWSAppmesh/Mesh/basic (24.31s)
        --- PASS: TestAccAWSAppmesh/Mesh/egressFilter (51.09s)
        --- PASS: TestAccAWSAppmesh/Mesh/tags (56.23s)
    --- PASS: TestAccAWSAppmesh/Route (273.84s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (50.79s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (50.79s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (50.57s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (50.93s)
        --- PASS: TestAccAWSAppmesh/Route/tags (70.77s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (301.89s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (27.91s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery (117.34s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/listenerHealthChecks (45.37s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/logging (47.19s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/tags (64.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	987.080s

This was referenced Jan 18, 2020
Merged
Merged
gdavison
gdavison approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSAppmesh (335.07s)
--- PASS: TestAccAWSAppmesh/Mesh (40.49s)
--- PASS: TestAccAWSAppmesh/Mesh/basic (8.01s)
--- PASS: TestAccAWSAppmesh/Mesh/egressFilter (15.61s)
--- PASS: TestAccAWSAppmesh/Mesh/tags (16.87s)
--- PASS: TestAccAWSAppmesh/Route (71.28s)
--- PASS: TestAccAWSAppmesh/Route/routePriority (12.98s)
--- PASS: TestAccAWSAppmesh/Route/tags (18.48s)
--- PASS: TestAccAWSAppmesh/Route/httpHeader (13.41s)
--- PASS: TestAccAWSAppmesh/Route/httpRoute (13.19s)
--- PASS: TestAccAWSAppmesh/Route/tcpRoute (13.22s)
--- PASS: TestAccAWSAppmesh/VirtualNode (149.98s)
--- PASS: TestAccAWSAppmesh/VirtualNode/basic (7.57s)
--- PASS: TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery (98.65s)
--- PASS: TestAccAWSAppmesh/VirtualNode/listenerHealthChecks (13.21s)
--- PASS: TestAccAWSAppmesh/VirtualNode/logging (12.71s)
--- PASS: TestAccAWSAppmesh/VirtualNode/tags (17.85s)
--- PASS: TestAccAWSAppmesh/VirtualRouter (30.14s)
--- PASS: TestAccAWSAppmesh/VirtualRouter/basic (12.61s)
--- PASS: TestAccAWSAppmesh/VirtualRouter/tags (17.53s)
--- PASS: TestAccAWSAppmesh/VirtualService (43.18s)
--- PASS: TestAccAWSAppmesh/VirtualService/virtualNode (12.93s)
--- PASS: TestAccAWSAppmesh/VirtualService/virtualRouter (12.18s)
--- PASS: TestAccAWSAppmesh/VirtualService/tags (18.07s)

@gdavison gdavison added this to the v2.50.0 milestone Feb 18, 2020
@gdavison gdavison merged commit b5052bf into hashicorp:master Feb 20, 2020
gdavison added a commit that referenced this pull request Feb 20, 2020
@gdavison
Update CHANGELOG for #10402
461e925
@ewbankkit ewbankkit deleted the issue-9802-MkIII branch February 20, 2020 16:44
@ghost
Copy link

ghost commented Feb 21, 2020

This has been released in version 2.50.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/appmesh Issues and PRs that pertain to the appmesh service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.50.0
Development

Successfully merging this pull request may close these issues.

AWS App Mesh HTTP-header-based routing and route priorities
2 participants
@ewbankkit @gdavison