r/aws_route53_resolver_rule: Correct handling for single dot ('.') domain names

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14730.

I verified that no Route 53 Hosted Zones can be created for the . domain, so this won't affect any base aws_route53_ resources.

Release note for CHANGELOG:

resource/aws_route53_resolver_rule: Correct handling of single dot `.` domain names

Output from acceptance testing:

$ go test ./aws -v -run TestTrimTrailingPeriod
=== RUN   TestTrimTrailingPeriod
--- PASS: TestTrimTrailingPeriod (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.037s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsRoute53ResolverRule_justDotDomainName\|TestAccAwsRoute53ResolverRule_trailingDotDomainName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsRoute53ResolverRule_justDotDomainName\|TestAccAwsRoute53ResolverRule_trailingDotDomainName -timeout 120m
=== RUN   TestAccAwsRoute53ResolverRule_justDotDomainName
=== PAUSE TestAccAwsRoute53ResolverRule_justDotDomainName
=== RUN   TestAccAwsRoute53ResolverRule_trailingDotDomainName
=== PAUSE TestAccAwsRoute53ResolverRule_trailingDotDomainName
=== CONT  TestAccAwsRoute53ResolverRule_justDotDomainName
=== CONT  TestAccAwsRoute53ResolverRule_trailingDotDomainName
--- PASS: TestAccAwsRoute53ResolverRule_justDotDomainName (40.75s)
--- PASS: TestAccAwsRoute53ResolverRule_trailingDotDomainName (40.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.793s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsRoute53ResolverRule_basic' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsRoute53ResolverRule_basic -timeout 120m
=== RUN   TestAccAwsRoute53ResolverRule_basic
=== PAUSE TestAccAwsRoute53ResolverRule_basic
=== CONT  TestAccAwsRoute53ResolverRule_basic
--- PASS: TestAccAwsRoute53ResolverRule_basic (38.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	38.949s

[DrFaust92]

--- PASS: TestAccAwsRoute53ResolverRule_basic (70.74s)
--- PASS: TestAccAwsRoute53ResolverRule_justDotDomainName (69.65s)
--- PASS: TestAccAwsRoute53ResolverRule_trailingDotDomainName (70.00s)

[bflad]

Looks good to me 🚀

Output from acceptance testing:

--- PASS: TestAccAwsRoute53ResolverRule_basic (51.50s)
--- PASS: TestAccAwsRoute53ResolverRule_forward (302.02s)
--- PASS: TestAccAwsRoute53ResolverRule_forwardEndpointRecreate (468.20s)
--- PASS: TestAccAwsRoute53ResolverRule_justDotDomainName (53.81s)
--- PASS: TestAccAwsRoute53ResolverRule_tags (79.55s)
--- PASS: TestAccAwsRoute53ResolverRule_trailingDotDomainName (53.97s)
--- PASS: TestAccAwsRoute53ResolverRule_updateName (76.52s)

--- PASS: TestAccAwsRoute53ResolverRuleAssociation_basic (200.65s)

--- PASS: TestAccAWSRoute53Zone_basic (73.79s)
--- PASS: TestAccAWSRoute53Zone_Comment (88.35s)
--- PASS: TestAccAWSRoute53Zone_DelegationSetID (75.67s)
--- PASS: TestAccAWSRoute53Zone_disappears (67.61s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy (238.61s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (237.20s)
--- PASS: TestAccAWSRoute53Zone_multiple (78.13s)
--- PASS: TestAccAWSRoute53Zone_Tags (80.90s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (168.51s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (99.75s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (262.79s)

--- PASS: TestAccAWSRoute53ZoneAssociation_basic (201.40s)
--- PASS: TestAccAWSRoute53ZoneAssociation_CrossRegion (205.99s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears (205.47s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_VPC (191.07s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_Zone (192.61s)

[ghost]

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!