Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53_resolver_rule: Correct handling for single dot ('.') domain names #15015

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 3, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14730.

I verified that no Route 53 Hosted Zones can be created for the . domain, so this won't affect any base aws_route53_ resources.

Release note for CHANGELOG:

resource/aws_route53_resolver_rule: Correct handling of single dot `.` domain names

Output from acceptance testing:

$ go test ./aws -v -run TestTrimTrailingPeriod
=== RUN   TestTrimTrailingPeriod
--- PASS: TestTrimTrailingPeriod (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.037s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsRoute53ResolverRule_justDotDomainName\|TestAccAwsRoute53ResolverRule_trailingDotDomainName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsRoute53ResolverRule_justDotDomainName\|TestAccAwsRoute53ResolverRule_trailingDotDomainName -timeout 120m
=== RUN   TestAccAwsRoute53ResolverRule_justDotDomainName
=== PAUSE TestAccAwsRoute53ResolverRule_justDotDomainName
=== RUN   TestAccAwsRoute53ResolverRule_trailingDotDomainName
=== PAUSE TestAccAwsRoute53ResolverRule_trailingDotDomainName
=== CONT  TestAccAwsRoute53ResolverRule_justDotDomainName
=== CONT  TestAccAwsRoute53ResolverRule_trailingDotDomainName
--- PASS: TestAccAwsRoute53ResolverRule_justDotDomainName (40.75s)
--- PASS: TestAccAwsRoute53ResolverRule_trailingDotDomainName (40.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.793s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsRoute53ResolverRule_basic' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsRoute53ResolverRule_basic -timeout 120m
=== RUN   TestAccAwsRoute53ResolverRule_basic
=== PAUSE TestAccAwsRoute53ResolverRule_basic
=== CONT  TestAccAwsRoute53ResolverRule_basic
--- PASS: TestAccAwsRoute53ResolverRule_basic (38.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	38.949s

@ewbankkit ewbankkit requested a review from a team September 3, 2020 15:17
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/route53 Issues and PRs that pertain to the route53 service. service/route53resolver Issues and PRs that pertain to the route53resolver service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 3, 2020
@ewbankkit ewbankkit force-pushed the b-aws_route53_resolver_rule-domain_name-dot branch from a0fb777 to a66506c Compare September 3, 2020 15:24
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels Sep 3, 2020
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--- PASS: TestAccAwsRoute53ResolverRule_basic (70.74s)
--- PASS: TestAccAwsRoute53ResolverRule_justDotDomainName (69.65s)
--- PASS: TestAccAwsRoute53ResolverRule_trailingDotDomainName (70.00s)

@bflad bflad self-assigned this Sep 3, 2020
@bflad bflad added this to the v3.5.0 milestone Sep 3, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Output from acceptance testing:

--- PASS: TestAccAwsRoute53ResolverRule_basic (51.50s)
--- PASS: TestAccAwsRoute53ResolverRule_forward (302.02s)
--- PASS: TestAccAwsRoute53ResolverRule_forwardEndpointRecreate (468.20s)
--- PASS: TestAccAwsRoute53ResolverRule_justDotDomainName (53.81s)
--- PASS: TestAccAwsRoute53ResolverRule_tags (79.55s)
--- PASS: TestAccAwsRoute53ResolverRule_trailingDotDomainName (53.97s)
--- PASS: TestAccAwsRoute53ResolverRule_updateName (76.52s)

--- PASS: TestAccAwsRoute53ResolverRuleAssociation_basic (200.65s)

--- PASS: TestAccAWSRoute53Zone_basic (73.79s)
--- PASS: TestAccAWSRoute53Zone_Comment (88.35s)
--- PASS: TestAccAWSRoute53Zone_DelegationSetID (75.67s)
--- PASS: TestAccAWSRoute53Zone_disappears (67.61s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy (238.61s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (237.20s)
--- PASS: TestAccAWSRoute53Zone_multiple (78.13s)
--- PASS: TestAccAWSRoute53Zone_Tags (80.90s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (168.51s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (99.75s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (262.79s)

--- PASS: TestAccAWSRoute53ZoneAssociation_basic (201.40s)
--- PASS: TestAccAWSRoute53ZoneAssociation_CrossRegion (205.99s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears (205.47s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_VPC (191.07s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_Zone (192.61s)

@bflad bflad merged commit c5b1e7a into hashicorp:master Sep 3, 2020
bflad added a commit that referenced this pull request Sep 3, 2020
@ewbankkit ewbankkit deleted the b-aws_route53_resolver_rule-domain_name-dot branch September 3, 2020 18:45
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_route53_resolver_rule domain_name value "." is now broken
3 participants