Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPC endpoint service private dns name support #16495

Merged
merged 5 commits into from
Jan 5, 2021
Merged

VPC endpoint service private dns name support #16495

merged 5 commits into from
Jan 5, 2021

Conversation

stijndehaes
Copy link
Contributor

@stijndehaes stijndehaes commented Dec 1, 2020 •
edited
Loading

Added support for setting the private dns name
in an endpoint service. We also return the config
that is required for users to set in their route53
configuration.

Signed-off-by: Stijn De Haes stijndehaes@gmail.com

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16568

Release note for CHANGELOG:

resource/aws_vpc_endpoint_service: Support setting a private dns name

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointService_private_dns_name'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointService_private_dns_name -timeout 120m
=== RUN   TestAccAWSVpcEndpointService_private_dns_name
=== PAUSE TestAccAWSVpcEndpointService_private_dns_name
=== CONT  TestAccAWSVpcEndpointService_private_dns_name
--- PASS: TestAccAWSVpcEndpointService_private_dns_name (313.88s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       313.900s


make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointService_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointService_basic -timeout 120m
=== RUN   TestAccAWSVpcEndpointService_basic
=== PAUSE TestAccAWSVpcEndpointService_basic
=== CONT  TestAccAWSVpcEndpointService_basic
--- PASS: TestAccAWSVpcEndpointService_basic (260.04s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       260.062s

@stijndehaes stijndehaes requested a review from a team as a code owner December 1, 2020 10:32
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 1, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 1, 2020
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointService_basic\|TestAccAWSVpcEndpointService_private_dns_name'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointService_basic\|TestAccAWSVpcEndpointService_private_dns_name -timeout 120m
=== RUN   TestAccAWSVpcEndpointService_basic
=== PAUSE TestAccAWSVpcEndpointService_basic
=== RUN   TestAccAWSVpcEndpointService_private_dns_name
=== PAUSE TestAccAWSVpcEndpointService_private_dns_name
=== CONT  TestAccAWSVpcEndpointService_basic
=== CONT  TestAccAWSVpcEndpointService_private_dns_name
--- PASS: TestAccAWSVpcEndpointService_basic (240.31s)
--- PASS: TestAccAWSVpcEndpointService_private_dns_name (256.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	256.783s

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 1, 2020
ewbankkit
ewbankkit approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stijndehaes
VPC endpoint service private dns name support
7ac3848 
Added support for setting the private dns name
in an endpoint service. We also return the config
that is required for users to set in their route53
configuration.

Signed-off-by: Stijn De Haes <stijndehaes@gmail.com>
@stijndehaes stijndehaes requested review from ewbankkit and removed request for a team December 1, 2020 14:41
@ewbankkit ewbankkit mentioned this pull request Dec 3, 2020
Closed
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 30, 2020
@bflad bflad self-assigned this Jan 5, 2021
@bflad
Copy link
Contributor

bflad commented Jan 5, 2021

This appears to supersede #12246 and close #11510.

@bflad bflad linked an issue Jan 5, 2021 that may be closed by this pull request
AWS PrivateLink now supports Private DNS names for internal and 3rd party services #11510
Closed
bflad
bflad reviewed Jan 5, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stijndehaes 👋 Thank you for submitting this. Overall this was in pretty good shape, just some minor items, which I'll get in now before merging to verify, then we will pull this functionality in.

aws/resource_aws_vpc_endpoint_service.go Outdated Show resolved Hide resolved
aws/resource_aws_vpc_endpoint_service.go Outdated Show resolved Hide resolved
aws/resource_aws_vpc_endpoint_service.go Outdated Show resolved Hide resolved
aws/resource_aws_vpc_endpoint_service_test.go Outdated Show resolved Hide resolved
aws/resource_aws_vpc_endpoint_service_test.go Outdated Show resolved Hide resolved
aws/resource_aws_vpc_endpoint_service_test.go Outdated Show resolved Hide resolved
website/docs/r/vpc_endpoint_service.html.markdown Outdated Show resolved Hide resolved
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jan 5, 2021
@bflad bflad mentioned this pull request Jan 5, 2021
Closed
@bflad bflad added this to the v3.23.0 milestone Jan 5, 2021
bflad
bflad approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set -- thanks again, @stijndehaes 🚀

Output from acceptance testing:

--- PASS: TestAccAWSVpcEndpointService_GatewayLoadBalancerArns (211.72s)
--- PASS: TestAccAWSVpcEndpointService_disappears (259.98s)
--- PASS: TestAccAWSVpcEndpointService_private_dns_name (260.23s)
--- PASS: TestAccAWSVpcEndpointService_tags (260.39s)
--- PASS: TestAccAWSVpcEndpointService_basic (315.92s)
--- PASS: TestAccAWSVpcEndpointService_AllowedPrincipals (326.95s)

@bflad bflad merged commit f6880bb into hashicorp:master Jan 5, 2021
bflad added a commit that referenced this pull request Jan 5, 2021
@bflad
Update CHANGELOG for #16495
3ce21df
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.23.0
4 participants
@stijndehaes @ewbankkit @bflad @DrFaust92