Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Managing EC2 Transit Gateway Prefix List References #16572

Closed
bflad opened this issue Dec 3, 2020 · 3 comments · Fixed by #16823
Closed

Support Managing EC2 Transit Gateway Prefix List References #16572

bflad opened this issue Dec 3, 2020 · 3 comments · Fixed by #16823
Assignees
@bflad
Labels
new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone
v3.27.0

Comments

@bflad
Copy link
Contributor

bflad commented Dec 3, 2020 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Differently than EC2 Route Tables, EC2 Transit Gateways handle Prefix List routing via separate API calls than those already containing destination CIDRs. This feature request is for implementing a new resource in the Terraform AWS Provider to manage the lifecycle of those separate API resources.

New Resource

  • aws_ec2_transit_gateway_prefix_list_reference

Potential Terraform Configuration

resource "aws_ec2_transit_gateway_prefix_list_reference" "example" {
  blackhole                      = true/false
  prefix_list_id                 = aws_ec2_managed_prefix_list.example.id
  transit_gateway_attachment_id  = aws_ec2_transit_gateway_vpc_attachment.example.id
  transit_gateway_route_table_id = aws_ec2_transit_gateway_route_table.example.id
}

References
@bflad bflad added new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service. labels Dec 3, 2020
@bflad bflad mentioned this issue Dec 3, 2020
Closed
@bflad bflad self-assigned this Dec 17, 2020
bflad added a commit that referenced this issue Dec 17, 2020
@bflad
New Resource: aws_ec2_transit_gateway_prefix_list_reference
daa0116 
Reference: #16572

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_disappears (214.31s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_basic (217.12s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_disappears_TransitGateway (219.77s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_TransitGatewayAttachmentId (397.05s)
```
@bflad bflad mentioned this issue Dec 17, 2020
Merged
YakDriver pushed a commit that referenced this issue Feb 4, 2021
@bflad @YakDriver
New Resource: aws_ec2_transit_gateway_prefix_list_reference
9c45ddd 
Reference: #16572

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_disappears (214.31s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_basic (217.12s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_disappears_TransitGateway (219.77s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_TransitGatewayAttachmentId (397.05s)
```
bflad added a commit that referenced this issue Feb 4, 2021
@bflad @YakDriver
New Resource: aws_ec2_transit_gateway_prefix_list_reference (#16823)
6877834 
* New Resource: aws_ec2_transit_gateway_prefix_list_reference

Reference: #16572

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_disappears (214.31s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_basic (217.12s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_disappears_TransitGateway (219.77s)
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_TransitGatewayAttachmentId (397.05s)
```

* tests/resource/aws_ec2_transit_gateway_prefix_list_reference: Use variable to fix terrafmt issue

Output from acceptance testing:

```
--- PASS: TestAccAwsEc2TransitGatewayPrefixListReference_TransitGatewayAttachmentId (403.66s)
```

* Update CHANGELOG for #16823

* resource/ec2_transit_gateway_prefix_list_reference: Add precheck

Co-authored-by: Dirk Avery <dirk.avery@gmail.com>
@github-actions github-actions bot added this to the v3.27.0 milestone Feb 4, 2021
@bflad
Copy link
Contributor Author

bflad commented Feb 4, 2021

Support for this new resource has been merged and will release later today with version 3.27.0 of the Terraform AWS Provider. 👍

@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Milestone
v3.27.0
Development

Successfully merging a pull request may close this issue.

New Resource: aws_ec2_transit_gateway_prefix_list_reference hashicorp/terraform-provider-aws
1 participant
@bflad