Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS Capacity Provider - InstanceWarmupPeriod #16673

Closed
tburow opened this issue Dec 9, 2020 · 3 comments · Fixed by #16941
Closed

ECS Capacity Provider - InstanceWarmupPeriod #16673

tburow opened this issue Dec 9, 2020 · 3 comments · Fixed by #16941
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Milestone

Comments

@tburow
Copy link

tburow commented Dec 9, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Request added support for ECS capacity provider setting - InstanceWarmupPeriod

New or Affected Resource(s)

https://github.com/hashicorp/terraform-provider-aws/blob/master/aws/resource_aws_ecs_capacity_provider.go

  • resource_aws_ecs_capacity_provider

Potential Terraform Configuration

resource "aws_ecs_capacity_provider" "test" {
  name = "test"

  auto_scaling_group_provider {
    auto_scaling_group_arn         = aws_autoscaling_group.test.arn
    managed_termination_protection = "ENABLED"

    managed_scaling {
      maximum_scaling_step_size = 1000
      minimum_scaling_step_size = 1
      status                    = "ENABLED"
      target_capacity           = 10
      instance_warmup_period = 300
    }
  }
}

References

@tburow tburow added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 9, 2020
@ghost ghost added the service/ecs Issues and PRs that pertain to the ecs service. label Dec 9, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 9, 2020
@bill-rich bill-rich removed the needs-triage Waiting for first response or review from a maintainer. label Dec 14, 2020
@bflad bflad self-assigned this Feb 18, 2021
bflad pushed a commit that referenced this issue Feb 18, 2021
…eriod (#16941)

Reference: #16673

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSEcsCapacityProvider_basic (82.59s)
--- PASS: TestAccAWSEcsCapacityProvider_disappears (61.98s)
--- PASS: TestAccAWSEcsCapacityProvider_ManagedScaling (83.84s)
--- PASS: TestAccAWSEcsCapacityProvider_ManagedScalingPartial (60.27s)
--- PASS: TestAccAWSEcsCapacityProvider_Tags (100.69s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSEcsCapacityProvider_basic (64.74s)
--- PASS: TestAccAWSEcsCapacityProvider_disappears (61.46s)
--- PASS: TestAccAWSEcsCapacityProvider_ManagedScaling (56.88s)
--- PASS: TestAccAWSEcsCapacityProvider_ManagedScalingPartial (56.82s)
--- PASS: TestAccAWSEcsCapacityProvider_Tags (126.82s)
```
@bflad
Copy link
Contributor

bflad commented Feb 18, 2021

Support for the instance_warmup_period argument has been added and will release with version 3.29.0 of the Terraform AWS Provider, later today. Thank you to @shuheiktgw for the implementation. 👍

@bflad bflad added this to the v3.29.0 milestone Feb 18, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
3 participants