resource/aws_instance: Apply attribute waiter logic to iam_instance_profile attribute #16769
Assignees
Labels
service/ec2
Issues and PRs that pertain to the ec2 service.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone
Comments
bflad
added
tests
bflad
pushed a commit
that referenced
this issue
Dec 17, 2020
…ta source (#16620) Reference: #16514 Output from acceptance testing (test failure unrelated and noted in #16769): ``` --- FAIL: TestAccAWSInstance_instanceProfileChange (317.03s) --- PASS: TestAccAWSInstance_addSecondaryInterface (165.55s) --- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (159.08s) --- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (96.96s) --- PASS: TestAccAWSInstance_associatePublic_defaultPublic (88.29s) --- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (98.92s) --- PASS: TestAccAWSInstance_associatePublic_explicitPublic (78.79s) --- PASS: TestAccAWSInstance_associatePublic_overridePrivate (87.75s) --- PASS: TestAccAWSInstance_associatePublic_overridePublic (78.38s) --- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (259.61s) --- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (147.90s) --- PASS: TestAccAWSInstance_basic (76.37s) --- PASS: TestAccAWSInstance_blockDevices (84.41s) --- PASS: TestAccAWSInstance_changeInstanceType (374.14s) --- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (332.05s) --- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (122.53s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (125.02s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (294.22s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (108.40s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (310.98s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (135.78s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (288.61s) --- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (94.79s) --- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (124.98s) --- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (336.93s) --- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (216.49s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (224.03s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (107.79s) --- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (317.85s) --- PASS: TestAccAWSInstance_dedicatedInstance (126.43s) --- PASS: TestAccAWSInstance_disableApiTermination (154.23s) --- PASS: TestAccAWSInstance_disappears (151.57s) --- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (11.08s) --- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidThroughputForVolumeType (11.48s) --- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (72.43s) --- PASS: TestAccAWSInstance_EbsRootDevice_basic (191.38s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (153.72s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (173.98s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io1 (230.44s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io2 (246.25s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (225.70s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyThroughput_Gp3 (221.01s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (230.40s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (118.15s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (138.47s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (209.99s) --- PASS: TestAccAWSInstance_Empty_PrivateIP (247.91s) --- PASS: TestAccAWSInstance_enclaveOptions (524.76s) --- PASS: TestAccAWSInstance_forceNewAndTagsDrift (301.26s) --- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (195.55s) --- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (284.94s) --- PASS: TestAccAWSInstance_GP2IopsDevice (86.28s) --- PASS: TestAccAWSInstance_GP2WithIopsValue (9.66s) --- PASS: TestAccAWSInstance_hibernation (284.60s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgId (96.80s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgName (186.86s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCount (101.07s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (143.20s) --- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (13.53s) --- PASS: TestAccAWSInstance_keyPairCheck (249.89s) --- PASS: TestAccAWSInstance_metadataOptions (245.64s) --- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (285.45s) --- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (147.15s) --- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (202.59s) --- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (344.11s) --- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (163.40s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (355.32s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (144.22s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (415.89s) --- PASS: TestAccAWSInstance_noAMIEphemeralDevices (91.80s) --- PASS: TestAccAWSInstance_placementGroup (117.55s) --- PASS: TestAccAWSInstance_primaryNetworkInterface (132.58s) --- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (244.37s) --- PASS: TestAccAWSInstance_privateIP (259.77s) --- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (99.86s) --- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (234.60s) --- PASS: TestAccAWSInstance_rootInstanceStore (118.53s) --- PASS: TestAccAWSInstance_sourceDestCheck (258.89s) --- PASS: TestAccAWSInstance_tags (318.09s) --- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (237.74s) --- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (236.79s) --- PASS: TestAccAWSInstance_userDataBase64 (88.37s) --- PASS: TestAccAWSInstance_volumeTags (349.07s) --- PASS: TestAccAWSInstance_volumeTagsComputed (291.98s) --- PASS: TestAccAWSInstance_withIamInstanceProfile (276.41s) --- SKIP: TestAccAWSInstance_inEc2Classic (1.59s) --- SKIP: TestAccAWSInstance_outpost (1.89s) --- PASS: TestAccAWSInstanceDataSource_AzUserData (149.91s) --- PASS: TestAccAWSInstanceDataSource_basic (154.74s) --- PASS: TestAccAWSInstanceDataSource_blockDevices (111.39s) --- PASS: TestAccAWSInstanceDataSource_creditSpecification (188.40s) --- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (153.00s) --- PASS: TestAccAWSInstanceDataSource_enclaveOptions (332.35s) --- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (207.01s) --- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (240.13s) --- PASS: TestAccAWSInstanceDataSource_GetUserData (204.58s) --- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (194.61s) --- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (393.36s) --- PASS: TestAccAWSInstanceDataSource_gp3ThroughputDevice (134.01s) --- PASS: TestAccAWSInstanceDataSource_keyPair (143.35s) --- PASS: TestAccAWSInstanceDataSource_metadataOptions (311.32s) --- PASS: TestAccAWSInstanceDataSource_PlacementGroup (358.55s) --- PASS: TestAccAWSInstanceDataSource_privateIP (150.46s) --- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (163.76s) --- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (374.57s) --- PASS: TestAccAWSInstanceDataSource_secondaryPrivateIPs (146.10s) --- PASS: TestAccAWSInstanceDataSource_SecurityGroups (162.74s) --- PASS: TestAccAWSInstanceDataSource_tags (161.67s) --- PASS: TestAccAWSInstanceDataSource_VPC (170.24s) --- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (158.43s) --- PASS: TestAccAWSInstancesDataSource_basic (320.63s) --- PASS: TestAccAWSInstancesDataSource_instanceStateNames (321.13s) --- PASS: TestAccAWSInstancesDataSource_tags (319.82s) ```
19 tasks
bflad
added a commit
that referenced
this issue
Feb 2, 2021
…rofile attribute Reference: #16769 This resource attribute has long been the cause of the following flakey acceptance test: ``` === CONT TestAccAWSInstance_instanceProfileChange TestAccAWSInstance_instanceProfileChange: resource_aws_instance_test.go:1134: Step 3/5 error: After applying this test step, the plan was not empty. stdout: An execution plan has been generated and is shown below. Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: ~ resource "aws_instance" "test" { + iam_instance_profile = "tf-testacc-instance-1obw9bpsudzr" id = "i-0748e5ca403753317" tags = { "Name" = "tf-testacc-instance-1obw9bpsudzr" } } ``` Adding logic, similar to `SubnetMapCustomerOwnedIpOnLaunchUpdated` in #16676 can be used to ensure the attribute value has flipped correctly after calling the `AssociateIamInstanceProfile`, `DisassociateIamInstanceProfile` or `ReplaceIamInstanceProfile` APIs. This attribute waiter setup will be added to a forthcoming Retries and Waiters section in the Contribution Guide. Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSInstance_addSecondaryInterface (242.73s) --- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (230.14s) --- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (110.25s) --- PASS: TestAccAWSInstance_associatePublic_defaultPublic (110.99s) --- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (100.21s) --- PASS: TestAccAWSInstance_associatePublic_explicitPublic (110.40s) --- PASS: TestAccAWSInstance_associatePublic_overridePrivate (109.74s) --- PASS: TestAccAWSInstance_associatePublic_overridePublic (131.67s) --- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (146.51s) --- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (193.28s) --- PASS: TestAccAWSInstance_basic (88.80s) --- PASS: TestAccAWSInstance_blockDevices (121.48s) --- PASS: TestAccAWSInstance_blockDeviceTags_ebsAndRoot (210.18s) --- PASS: TestAccAWSInstance_blockDeviceTags_volumeTags (218.14s) --- PASS: TestAccAWSInstance_blockDeviceTags_withAttachedVolume (274.15s) --- PASS: TestAccAWSInstance_changeInstanceType (279.18s) --- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (146.18s) --- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (121.58s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (151.11s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (417.38s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (108.53s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (139.87s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (142.36s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (209.11s) --- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (111.75s) --- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (114.39s) --- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (180.11s) --- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (136.87s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (125.41s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (127.50s) --- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (180.12s) --- PASS: TestAccAWSInstance_dedicatedInstance (133.35s) --- PASS: TestAccAWSInstance_disableApiTermination (184.77s) --- PASS: TestAccAWSInstance_disappears (78.61s) --- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (12.67s) --- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidThroughputForVolumeType (10.14s) --- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (117.10s) --- PASS: TestAccAWSInstance_EbsRootDevice_basic (193.58s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (152.37s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (153.09s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io1 (169.55s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io2 (194.13s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (165.98s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyThroughput_Gp3 (163.26s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (183.84s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (147.87s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (192.81s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (232.62s) --- PASS: TestAccAWSInstance_Empty_PrivateIP (145.38s) --- PASS: TestAccAWSInstance_enclaveOptions (219.52s) --- PASS: TestAccAWSInstance_forceNewAndTagsDrift (283.16s) --- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (157.98s) --- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (198.56s) --- PASS: TestAccAWSInstance_GP2IopsDevice (99.64s) --- PASS: TestAccAWSInstance_GP2WithIopsValue (43.96s) --- PASS: TestAccAWSInstance_hibernation (236.92s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgId (103.41s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgName (131.23s) --- PASS: TestAccAWSInstance_inEc2Classic (107.37s) --- PASS: TestAccAWSInstance_instanceProfileChange (328.37s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCount (145.65s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (101.01s) --- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (19.16s) --- PASS: TestAccAWSInstance_keyPairCheck (131.83s) --- PASS: TestAccAWSInstance_metadataOptions (157.61s) --- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (189.12s) --- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (162.78s) --- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (157.66s) --- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (149.96s) --- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (220.50s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (121.07s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (180.92s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (297.98s) --- PASS: TestAccAWSInstance_noAMIEphemeralDevices (121.40s) --- PASS: TestAccAWSInstance_placementGroup (121.32s) --- PASS: TestAccAWSInstance_primaryNetworkInterface (157.80s) --- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (189.25s) --- PASS: TestAccAWSInstance_privateIP (147.33s) --- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (120.64s) --- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (162.61s) --- PASS: TestAccAWSInstance_rootInstanceStore (101.64s) --- PASS: TestAccAWSInstance_sourceDestCheck (238.40s) --- PASS: TestAccAWSInstance_tags (143.95s) --- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (157.16s) --- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (136.23s) --- PASS: TestAccAWSInstance_userDataBase64 (156.05s) --- PASS: TestAccAWSInstance_withIamInstanceProfile (127.90s) --- SKIP: TestAccAWSInstance_outpost (1.88s) --- PASS: TestAccAWSInstanceDataSource_AzUserData (106.26s) --- PASS: TestAccAWSInstanceDataSource_basic (110.08s) --- PASS: TestAccAWSInstanceDataSource_blockDevices (117.74s) --- PASS: TestAccAWSInstanceDataSource_blockDeviceTags (121.08s) --- PASS: TestAccAWSInstanceDataSource_creditSpecification (116.29s) --- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (136.51s) --- PASS: TestAccAWSInstanceDataSource_enclaveOptions (87.52s) --- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (188.34s) --- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (275.27s) --- PASS: TestAccAWSInstanceDataSource_GetUserData (208.51s) --- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (234.58s) --- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (98.45s) --- PASS: TestAccAWSInstanceDataSource_gp3ThroughputDevice (100.55s) --- PASS: TestAccAWSInstanceDataSource_keyPair (111.47s) --- PASS: TestAccAWSInstanceDataSource_metadataOptions (122.07s) --- PASS: TestAccAWSInstanceDataSource_PlacementGroup (129.96s) --- PASS: TestAccAWSInstanceDataSource_privateIP (113.30s) --- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (110.23s) --- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (120.74s) --- PASS: TestAccAWSInstanceDataSource_secondaryPrivateIPs (125.40s) --- PASS: TestAccAWSInstanceDataSource_SecurityGroups (126.16s) --- PASS: TestAccAWSInstanceDataSource_tags (96.07s) --- PASS: TestAccAWSInstanceDataSource_VPC (126.74s) --- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (135.88s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- FAIL: TestAccAWSInstance_dedicatedInstance (31.08s) # #17412 --- FAIL: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io2 (12.77s) # #17412 --- FAIL: TestAccAWSInstance_enclaveOptions (31.10s) # #17412 --- PASS: TestAccAWSInstance_addSecondaryInterface (201.36s) --- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (169.84s) --- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (100.80s) --- PASS: TestAccAWSInstance_associatePublic_defaultPublic (112.34s) --- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (94.40s) --- PASS: TestAccAWSInstance_associatePublic_explicitPublic (112.61s) --- PASS: TestAccAWSInstance_associatePublic_overridePrivate (93.90s) --- PASS: TestAccAWSInstance_associatePublic_overridePublic (83.17s) --- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (98.45s) --- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (174.93s) --- PASS: TestAccAWSInstance_basic (90.77s) --- PASS: TestAccAWSInstance_blockDevices (124.40s) --- PASS: TestAccAWSInstance_blockDeviceTags_ebsAndRoot (144.71s) --- PASS: TestAccAWSInstance_blockDeviceTags_volumeTags (189.71s) --- PASS: TestAccAWSInstance_blockDeviceTags_withAttachedVolume (184.30s) --- PASS: TestAccAWSInstance_changeInstanceType (178.33s) --- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (140.47s) --- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (111.53s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (120.43s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (223.58s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (98.06s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (90.11s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (131.18s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (196.64s) --- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (101.42s) --- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (119.74s) --- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (184.44s) --- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (135.21s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (167.30s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (100.56s) --- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (183.55s) --- PASS: TestAccAWSInstance_disableApiTermination (181.92s) --- PASS: TestAccAWSInstance_disappears (194.95s) --- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (11.73s) --- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidThroughputForVolumeType (10.91s) --- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (109.41s) --- PASS: TestAccAWSInstance_EbsRootDevice_basic (109.65s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (133.86s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (147.04s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io1 (166.57s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (156.04s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyThroughput_Gp3 (134.16s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (123.90s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (134.58s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (141.10s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (202.53s) --- PASS: TestAccAWSInstance_Empty_PrivateIP (116.78s) --- PASS: TestAccAWSInstance_forceNewAndTagsDrift (173.61s) --- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (146.02s) --- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (191.54s) --- PASS: TestAccAWSInstance_GP2IopsDevice (86.02s) --- PASS: TestAccAWSInstance_GP2WithIopsValue (11.25s) --- PASS: TestAccAWSInstance_hibernation (256.05s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgId (93.32s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgName (106.90s) --- PASS: TestAccAWSInstance_instanceProfileChange (248.34s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCount (112.67s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (114.70s) --- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (29.25s) --- PASS: TestAccAWSInstance_keyPairCheck (98.40s) --- PASS: TestAccAWSInstance_metadataOptions (185.29s) --- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (148.16s) --- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (137.85s) --- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (123.37s) --- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (135.65s) --- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (182.43s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (101.76s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (187.35s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (197.08s) --- PASS: TestAccAWSInstance_noAMIEphemeralDevices (92.96s) --- PASS: TestAccAWSInstance_placementGroup (126.79s) --- PASS: TestAccAWSInstance_primaryNetworkInterface (156.42s) --- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (125.43s) --- PASS: TestAccAWSInstance_privateIP (106.48s) --- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (80.05s) --- PASS: TestAccAWSInstance_rootInstanceStore (111.78s) --- PASS: TestAccAWSInstance_sourceDestCheck (213.01s) --- PASS: TestAccAWSInstance_tags (128.83s) --- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (148.75s) --- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (158.81s) --- PASS: TestAccAWSInstance_userDataBase64 (117.21s) --- PASS: TestAccAWSInstance_withIamInstanceProfile (123.11s) --- SKIP: TestAccAWSInstance_inEc2Classic (1.40s) --- SKIP: TestAccAWSInstance_outpost (0.70s) --- SKIP: TestAccAWSInstance_rootBlockDeviceMismatch (0.00s) --- FAIL: TestAccAWSInstanceDataSource_enclaveOptions (33.30s) # #17412 --- PASS: TestAccAWSInstanceDataSource_AzUserData (86.49s) --- PASS: TestAccAWSInstanceDataSource_basic (119.95s) --- PASS: TestAccAWSInstanceDataSource_blockDevices (128.42s) --- PASS: TestAccAWSInstanceDataSource_blockDeviceTags (130.34s) --- PASS: TestAccAWSInstanceDataSource_creditSpecification (119.83s) --- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (101.52s) --- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (175.43s) --- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (225.22s) --- PASS: TestAccAWSInstanceDataSource_GetUserData (240.00s) --- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (226.72s) --- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (99.37s) --- PASS: TestAccAWSInstanceDataSource_gp3ThroughputDevice (98.23s) --- PASS: TestAccAWSInstanceDataSource_keyPair (120.55s) --- PASS: TestAccAWSInstanceDataSource_metadataOptions (131.12s) --- PASS: TestAccAWSInstanceDataSource_PlacementGroup (150.17s) --- PASS: TestAccAWSInstanceDataSource_privateIP (112.23s) --- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (159.42s) --- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (128.18s) --- PASS: TestAccAWSInstanceDataSource_secondaryPrivateIPs (117.31s) --- PASS: TestAccAWSInstanceDataSource_SecurityGroups (114.26s) --- PASS: TestAccAWSInstanceDataSource_tags (117.87s) --- PASS: TestAccAWSInstanceDataSource_VPC (121.68s) --- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (144.39s) ```
bflad
added a commit
that referenced
this issue
Feb 17, 2021
…rofile attribute (#17414) Reference: #16769 This resource attribute has long been the cause of the following flakey acceptance test: ``` === CONT TestAccAWSInstance_instanceProfileChange TestAccAWSInstance_instanceProfileChange: resource_aws_instance_test.go:1134: Step 3/5 error: After applying this test step, the plan was not empty. stdout: An execution plan has been generated and is shown below. Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: ~ resource "aws_instance" "test" { + iam_instance_profile = "tf-testacc-instance-1obw9bpsudzr" id = "i-0748e5ca403753317" tags = { "Name" = "tf-testacc-instance-1obw9bpsudzr" } } ``` Adding logic, similar to `SubnetMapCustomerOwnedIpOnLaunchUpdated` in #16676 can be used to ensure the attribute value has flipped correctly after calling the `AssociateIamInstanceProfile`, `DisassociateIamInstanceProfile` or `ReplaceIamInstanceProfile` APIs. This attribute waiter setup will be added to a forthcoming Retries and Waiters section in the Contribution Guide. Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSInstance_addSecondaryInterface (242.73s) --- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (230.14s) --- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (110.25s) --- PASS: TestAccAWSInstance_associatePublic_defaultPublic (110.99s) --- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (100.21s) --- PASS: TestAccAWSInstance_associatePublic_explicitPublic (110.40s) --- PASS: TestAccAWSInstance_associatePublic_overridePrivate (109.74s) --- PASS: TestAccAWSInstance_associatePublic_overridePublic (131.67s) --- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (146.51s) --- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (193.28s) --- PASS: TestAccAWSInstance_basic (88.80s) --- PASS: TestAccAWSInstance_blockDevices (121.48s) --- PASS: TestAccAWSInstance_blockDeviceTags_ebsAndRoot (210.18s) --- PASS: TestAccAWSInstance_blockDeviceTags_volumeTags (218.14s) --- PASS: TestAccAWSInstance_blockDeviceTags_withAttachedVolume (274.15s) --- PASS: TestAccAWSInstance_changeInstanceType (279.18s) --- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (146.18s) --- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (121.58s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (151.11s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (417.38s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (108.53s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (139.87s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (142.36s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (209.11s) --- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (111.75s) --- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (114.39s) --- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (180.11s) --- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (136.87s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (125.41s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (127.50s) --- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (180.12s) --- PASS: TestAccAWSInstance_dedicatedInstance (133.35s) --- PASS: TestAccAWSInstance_disableApiTermination (184.77s) --- PASS: TestAccAWSInstance_disappears (78.61s) --- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (12.67s) --- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidThroughputForVolumeType (10.14s) --- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (117.10s) --- PASS: TestAccAWSInstance_EbsRootDevice_basic (193.58s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (152.37s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (153.09s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io1 (169.55s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io2 (194.13s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (165.98s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyThroughput_Gp3 (163.26s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (183.84s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (147.87s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (192.81s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (232.62s) --- PASS: TestAccAWSInstance_Empty_PrivateIP (145.38s) --- PASS: TestAccAWSInstance_enclaveOptions (219.52s) --- PASS: TestAccAWSInstance_forceNewAndTagsDrift (283.16s) --- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (157.98s) --- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (198.56s) --- PASS: TestAccAWSInstance_GP2IopsDevice (99.64s) --- PASS: TestAccAWSInstance_GP2WithIopsValue (43.96s) --- PASS: TestAccAWSInstance_hibernation (236.92s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgId (103.41s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgName (131.23s) --- PASS: TestAccAWSInstance_inEc2Classic (107.37s) --- PASS: TestAccAWSInstance_instanceProfileChange (328.37s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCount (145.65s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (101.01s) --- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (19.16s) --- PASS: TestAccAWSInstance_keyPairCheck (131.83s) --- PASS: TestAccAWSInstance_metadataOptions (157.61s) --- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (189.12s) --- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (162.78s) --- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (157.66s) --- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (149.96s) --- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (220.50s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (121.07s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (180.92s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (297.98s) --- PASS: TestAccAWSInstance_noAMIEphemeralDevices (121.40s) --- PASS: TestAccAWSInstance_placementGroup (121.32s) --- PASS: TestAccAWSInstance_primaryNetworkInterface (157.80s) --- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (189.25s) --- PASS: TestAccAWSInstance_privateIP (147.33s) --- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (120.64s) --- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (162.61s) --- PASS: TestAccAWSInstance_rootInstanceStore (101.64s) --- PASS: TestAccAWSInstance_sourceDestCheck (238.40s) --- PASS: TestAccAWSInstance_tags (143.95s) --- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (157.16s) --- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (136.23s) --- PASS: TestAccAWSInstance_userDataBase64 (156.05s) --- PASS: TestAccAWSInstance_withIamInstanceProfile (127.90s) --- SKIP: TestAccAWSInstance_outpost (1.88s) --- PASS: TestAccAWSInstanceDataSource_AzUserData (106.26s) --- PASS: TestAccAWSInstanceDataSource_basic (110.08s) --- PASS: TestAccAWSInstanceDataSource_blockDevices (117.74s) --- PASS: TestAccAWSInstanceDataSource_blockDeviceTags (121.08s) --- PASS: TestAccAWSInstanceDataSource_creditSpecification (116.29s) --- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (136.51s) --- PASS: TestAccAWSInstanceDataSource_enclaveOptions (87.52s) --- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (188.34s) --- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (275.27s) --- PASS: TestAccAWSInstanceDataSource_GetUserData (208.51s) --- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (234.58s) --- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (98.45s) --- PASS: TestAccAWSInstanceDataSource_gp3ThroughputDevice (100.55s) --- PASS: TestAccAWSInstanceDataSource_keyPair (111.47s) --- PASS: TestAccAWSInstanceDataSource_metadataOptions (122.07s) --- PASS: TestAccAWSInstanceDataSource_PlacementGroup (129.96s) --- PASS: TestAccAWSInstanceDataSource_privateIP (113.30s) --- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (110.23s) --- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (120.74s) --- PASS: TestAccAWSInstanceDataSource_secondaryPrivateIPs (125.40s) --- PASS: TestAccAWSInstanceDataSource_SecurityGroups (126.16s) --- PASS: TestAccAWSInstanceDataSource_tags (96.07s) --- PASS: TestAccAWSInstanceDataSource_VPC (126.74s) --- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (135.88s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- FAIL: TestAccAWSInstance_dedicatedInstance (31.08s) # #17412 --- FAIL: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io2 (12.77s) # #17412 --- FAIL: TestAccAWSInstance_enclaveOptions (31.10s) # #17412 --- PASS: TestAccAWSInstance_addSecondaryInterface (201.36s) --- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (169.84s) --- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (100.80s) --- PASS: TestAccAWSInstance_associatePublic_defaultPublic (112.34s) --- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (94.40s) --- PASS: TestAccAWSInstance_associatePublic_explicitPublic (112.61s) --- PASS: TestAccAWSInstance_associatePublic_overridePrivate (93.90s) --- PASS: TestAccAWSInstance_associatePublic_overridePublic (83.17s) --- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (98.45s) --- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (174.93s) --- PASS: TestAccAWSInstance_basic (90.77s) --- PASS: TestAccAWSInstance_blockDevices (124.40s) --- PASS: TestAccAWSInstance_blockDeviceTags_ebsAndRoot (144.71s) --- PASS: TestAccAWSInstance_blockDeviceTags_volumeTags (189.71s) --- PASS: TestAccAWSInstance_blockDeviceTags_withAttachedVolume (184.30s) --- PASS: TestAccAWSInstance_changeInstanceType (178.33s) --- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (140.47s) --- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (111.53s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (120.43s) --- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (223.58s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (98.06s) --- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (90.11s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (131.18s) --- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (196.64s) --- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (101.42s) --- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (119.74s) --- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (184.44s) --- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (135.21s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (167.30s) --- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (100.56s) --- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (183.55s) --- PASS: TestAccAWSInstance_disableApiTermination (181.92s) --- PASS: TestAccAWSInstance_disappears (194.95s) --- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (11.73s) --- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidThroughputForVolumeType (10.91s) --- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (109.41s) --- PASS: TestAccAWSInstance_EbsRootDevice_basic (109.65s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (133.86s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (147.04s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io1 (166.57s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (156.04s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyThroughput_Gp3 (134.16s) --- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (123.90s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (134.58s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (141.10s) --- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (202.53s) --- PASS: TestAccAWSInstance_Empty_PrivateIP (116.78s) --- PASS: TestAccAWSInstance_forceNewAndTagsDrift (173.61s) --- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (146.02s) --- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (191.54s) --- PASS: TestAccAWSInstance_GP2IopsDevice (86.02s) --- PASS: TestAccAWSInstance_GP2WithIopsValue (11.25s) --- PASS: TestAccAWSInstance_hibernation (256.05s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgId (93.32s) --- PASS: TestAccAWSInstance_inDefaultVpcBySgName (106.90s) --- PASS: TestAccAWSInstance_instanceProfileChange (248.34s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCount (112.67s) --- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (114.70s) --- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (29.25s) --- PASS: TestAccAWSInstance_keyPairCheck (98.40s) --- PASS: TestAccAWSInstance_metadataOptions (185.29s) --- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (148.16s) --- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (137.85s) --- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (123.37s) --- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (135.65s) --- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (182.43s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (101.76s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (187.35s) --- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (197.08s) --- PASS: TestAccAWSInstance_noAMIEphemeralDevices (92.96s) --- PASS: TestAccAWSInstance_placementGroup (126.79s) --- PASS: TestAccAWSInstance_primaryNetworkInterface (156.42s) --- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (125.43s) --- PASS: TestAccAWSInstance_privateIP (106.48s) --- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (80.05s) --- PASS: TestAccAWSInstance_rootInstanceStore (111.78s) --- PASS: TestAccAWSInstance_sourceDestCheck (213.01s) --- PASS: TestAccAWSInstance_tags (128.83s) --- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (148.75s) --- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (158.81s) --- PASS: TestAccAWSInstance_userDataBase64 (117.21s) --- PASS: TestAccAWSInstance_withIamInstanceProfile (123.11s) --- SKIP: TestAccAWSInstance_inEc2Classic (1.40s) --- SKIP: TestAccAWSInstance_outpost (0.70s) --- SKIP: TestAccAWSInstance_rootBlockDeviceMismatch (0.00s) --- FAIL: TestAccAWSInstanceDataSource_enclaveOptions (33.30s) # #17412 --- PASS: TestAccAWSInstanceDataSource_AzUserData (86.49s) --- PASS: TestAccAWSInstanceDataSource_basic (119.95s) --- PASS: TestAccAWSInstanceDataSource_blockDevices (128.42s) --- PASS: TestAccAWSInstanceDataSource_blockDeviceTags (130.34s) --- PASS: TestAccAWSInstanceDataSource_creditSpecification (119.83s) --- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (101.52s) --- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (175.43s) --- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (225.22s) --- PASS: TestAccAWSInstanceDataSource_GetUserData (240.00s) --- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (226.72s) --- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (99.37s) --- PASS: TestAccAWSInstanceDataSource_gp3ThroughputDevice (98.23s) --- PASS: TestAccAWSInstanceDataSource_keyPair (120.55s) --- PASS: TestAccAWSInstanceDataSource_metadataOptions (131.12s) --- PASS: TestAccAWSInstanceDataSource_PlacementGroup (150.17s) --- PASS: TestAccAWSInstanceDataSource_privateIP (112.23s) --- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (159.42s) --- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (128.18s) --- PASS: TestAccAWSInstanceDataSource_secondaryPrivateIPs (117.31s) --- PASS: TestAccAWSInstanceDataSource_SecurityGroups (114.26s) --- PASS: TestAccAWSInstanceDataSource_tags (117.87s) --- PASS: TestAccAWSInstanceDataSource_VPC (121.68s) --- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (144.39s) ```
|
This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Community Note
Description
This resource attribute has long been the cause of the following flakey acceptance test:
Adding logic, similar to
SubnetMapCustomerOwnedIpOnLaunchUpdatedin #16676 can be used to ensure the attribute value has flipped correctly after calling theAssociateIamInstanceProfileorReplaceIamInstanceProfileAPIs.Affected Resource
References
The text was updated successfully, but these errors were encountered: