resource/aws_ecs_capacity_provider: Add support for instance warmup period

[shuheiktgw]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16673

Release note for CHANGELOG:

resource/aws_ecs_capacity_provider: Add support for instance warmup period

Output from acceptance testing:

$  make testacc TESTARGS='-run=TestAccAWSEcsCapacityProvider_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsCapacityProvider_* -timeout 120m
=== RUN   TestAccAWSEcsCapacityProvider_basic
=== PAUSE TestAccAWSEcsCapacityProvider_basic
=== RUN   TestAccAWSEcsCapacityProvider_disappears
=== PAUSE TestAccAWSEcsCapacityProvider_disappears
=== RUN   TestAccAWSEcsCapacityProvider_ManagedScaling
=== PAUSE TestAccAWSEcsCapacityProvider_ManagedScaling
=== RUN   TestAccAWSEcsCapacityProvider_ManagedScalingPartial
=== PAUSE TestAccAWSEcsCapacityProvider_ManagedScalingPartial
=== RUN   TestAccAWSEcsCapacityProvider_Tags
=== PAUSE TestAccAWSEcsCapacityProvider_Tags
=== CONT  TestAccAWSEcsCapacityProvider_basic
=== CONT  TestAccAWSEcsCapacityProvider_ManagedScalingPartial
=== CONT  TestAccAWSEcsCapacityProvider_ManagedScaling
=== CONT  TestAccAWSEcsCapacityProvider_disappears
=== CONT  TestAccAWSEcsCapacityProvider_Tags
--- PASS: TestAccAWSEcsCapacityProvider_ManagedScalingPartial (66.75s)
--- PASS: TestAccAWSEcsCapacityProvider_ManagedScaling (66.82s)
--- PASS: TestAccAWSEcsCapacityProvider_disappears (68.01s)
--- PASS: TestAccAWSEcsCapacityProvider_basic (85.37s)
--- PASS: TestAccAWSEcsCapacityProvider_Tags (137.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	139.787s

Thank you for your review! 👍

[shuheiktgw]

This PR conflicts with #16942

[bflad]

Looks great, @shuheiktgw, just going to adjust the validation to match API reference. 👍

[bflad]

Thank you, @shuheiktgw 🚀 (Will add changelog entry on merge)

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSEcsCapacityProvider_basic (82.59s)
--- PASS: TestAccAWSEcsCapacityProvider_disappears (61.98s)
--- PASS: TestAccAWSEcsCapacityProvider_ManagedScaling (83.84s)
--- PASS: TestAccAWSEcsCapacityProvider_ManagedScalingPartial (60.27s)
--- PASS: TestAccAWSEcsCapacityProvider_Tags (100.69s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSEcsCapacityProvider_basic (64.74s)
--- PASS: TestAccAWSEcsCapacityProvider_disappears (61.46s)
--- PASS: TestAccAWSEcsCapacityProvider_ManagedScaling (56.88s)
--- PASS: TestAccAWSEcsCapacityProvider_ManagedScalingPartial (56.82s)
--- PASS: TestAccAWSEcsCapacityProvider_Tags (126.82s)

[shuheiktgw]

Thank you for your review! @bflad

[ghost]

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!