Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on the aws_imagebuilder_image_pipeline is not correct #17665

Closed
gswallow opened this issue Feb 17, 2021 · 4 comments · Fixed by #17666
Closed

Documentation on the aws_imagebuilder_image_pipeline is not correct #17665

gswallow opened this issue Feb 17, 2021 · 4 comments · Fixed by #17666
Assignees
Labels
documentation Introduces or discusses updates to documentation. service/imagebuilder Issues and PRs that pertain to the imagebuilder service.
Milestone

Comments

@gswallow
Copy link

The documentation on schedule_expressions is wrong: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/imagebuilder_image_pipeline#schedule_expression

Instead of five fields, you must supply six. Also, one of the fields (day of month or day of week) must be a '?' if the other is set.

Source:

https://docs.aws.amazon.com/imagebuilder/latest/userguide/cron-expressions.html

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 17, 2021
@bflad bflad added documentation Introduces or discusses updates to documentation. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 17, 2021
@bflad bflad self-assigned this Feb 17, 2021
@bflad
Copy link
Contributor

bflad commented Feb 17, 2021

Thank you for the heads up, @gswallow! The syntax recently changed in the Image Builder API. A documentation (and testing) update has been submitted: #17666

@gswallow
Copy link
Author

Sweet! Cheers!

@github-actions github-actions bot added this to the v3.29.0 milestone Feb 18, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/imagebuilder Issues and PRs that pertain to the imagebuilder service.
Projects
None yet
2 participants