Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_imagebuilder_image_pipeline: Testing and documentation updates for schedule_expression API change #17666

Merged

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 17, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17396
Closes #17665

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (40.77s)
--- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (42.15s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (52.66s)
--- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (53.89s)

@bflad bflad requested a review from a team as a code owner February 17, 2021 19:40
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 17, 2021
…pdates for schedule_expression API change

Reference: #17396

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (40.77s)
--- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (42.15s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_ScheduleExpression (52.66s)
--- PASS: TestAccAwsImageBuilderImagePipeline_Schedule_PipelineExecutionStartCondition (53.89s)
```
@bflad bflad force-pushed the td-aws_imagebuilder_image_pipeline-schedule_expression-updates branch from b048713 to 7208df7 Compare February 18, 2021 19:00
@anGie44 anGie44 self-assigned this Feb 18, 2021
@bflad bflad merged commit dbce469 into main Feb 18, 2021
@bflad bflad deleted the td-aws_imagebuilder_image_pipeline-schedule_expression-updates branch February 18, 2021 21:23
@github-actions github-actions bot added this to the v3.29.0 milestone Feb 18, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants