-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Standardize acceptance test naming #17847
Comments
Thank you for putting this together. I'm generally 👍 to doing something here as it is a little over the place across the board. Drive-by note with some of my personal thoughts here:
Some other considerations:
|
The state of all tests as of today...
|
@bflad Great feedback! Sample PR: #17849
Love, love.
This would have avoided the recent regression problem with EC2 instances since I would have been running the data source tests consistently throughout the process.
If this is far off it may be worth some clean up in the meantime.
I like this idea.
Nice. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Fixed by #21306
Description
Primary Goal
Acceptance test names should be standardized to facilitate one primary goal:
ec2
) with one wildcard e.g.-run='TestAccAWSEC2'
Second Goals
Secondary goals might include:
-run='TestAccAWSEC2DataSource'
-run='TestAccAWSEC2Resource'
Problems
TestAccAWSAMI_
,TestAccAWSVPC_
,TestAccAWSALBTargetGroup_
)TestAccAWS
prefix and useTestAccAws
insteadDataSource
beforeAWS
/Aws
(e.g.,TestAccDataSourceAwsEbsVolumes_
)Proposal
Use CI-testing (semgrep or tfproviderlint) to require the following (after fixing existing problems):
TestAcc
("AWS" and "Aws" are dropped)TestAccAWSCallerIdentity_
), after the prefix, include "Meta."Service Test Names
(*) Indicates "service" dropped
(**) Indicates changes beyond just dropping "service"
New or Affected Resource(s)
References
The text was updated successfully, but these errors were encountered: