Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Acceptance Test Names Use Same Prefix in Single File #219

Closed
bflad opened this issue Dec 15, 2020 · 0 comments · Fixed by #230
Closed

Ensure Acceptance Test Names Use Same Prefix in Single File #219

bflad opened this issue Dec 15, 2020 · 0 comments · Fixed by #230
Assignees
Labels
ast AST Handling check/acctest Acceptance Testing Check new-check New Lint Check
Milestone

Comments

@bflad
Copy link
Owner

bflad commented Dec 15, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

There have been cases of capitalization differences in new tests and other code refactorings causing acceptance test function names to drift from a single standard within a file. Each file should ideally implement the same prefixed test naming so it is easier for contributors to run all acceptance tests for a particular resource.

New Checks

  • AT###

Flagged Provider Code

func TestAccExampleThing_FirstAttribute(t *testing.T) { /* ... */ }

func TestAccExampleOopsThing_SecondAttribute(t *testing.T) { /* ... */ }

func TestAccExampleTHING_ThirdAttribute(t *testing.T) { /* ... */ }

Passing Provider Code

func TestAccExampleThing_FirstAttribute(t *testing.T) { /* ... */ }

func TestAccExampleThing_SecondAttribute(t *testing.T) { /* ... */ }

func TestAccExampleThing_ThirdAttribute(t *testing.T) { /* ... */ }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast AST Handling check/acctest Acceptance Testing Check new-check New Lint Check
Projects
None yet
1 participant