ACM PCA: add resource to issue certificates from private CA and import CA certificates

[gdavison]

This PR extends the contribution by @dvdliao in #10213.

In addition to issuing certificates using aws_acmpca_certificate, it also allows importing a certificate into a private CA using aws_acmpca_certificate_authority_certificate. This is required to enable a CA to issue certificates.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10183
Closes #5552

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAcc.*AwsAcmpca'

--- PASS: TestAccAwsAcmpcaCertificateAuthority_disappears (188.72s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_DeleteFromActiveState (212.85s)
--- PASS: TestAccDataSourceAwsAcmpcaCertificate_Basic (229.87s)
--- PASS: TestAccDataSourceAwsAcmpcaCertificateAuthority_basic (230.76s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_basic (244.67s)
--- PASS: TestAccAwsAcmpcaCertificate_RootCertificate (251.85s)
--- PASS: TestAccAwsAcmpcaCertificateAuthorityCertificate_RootCA (258.49s)
--- PASS: TestAccAwsAcmpcaCertificate_SubordinateCertificate (261.86s)
--- PASS: TestAccAwsAcmpcaCertificateAuthorityCertificate_SubordinateCA (264.34s)
--- PASS: TestAccAwsAcmpcaCertificate_Validity_Absolute (266.55s)
--- PASS: TestAccAwsAcmpcaCertificate_Validity_EndDate (271.35s)
--- PASS: TestAccAwsAcmpcaCertificate_EndEntityCertificate (268.24s)
--- PASS: TestAccAwsAcmpcaCertificateAuthorityCertificate_UpdateRootCA (85.20s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Enabled (353.68s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays (368.14s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Tags (385.77s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled (430.11s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname (474.40s)

[dvdliao]

thank you!

[bill-rich]

Looks good. Just a couple of questions and comments.

[bill-rich]

LGTM

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAcmpca -timeout 120m
=== RUN   TestAccAwsAcmpcaCertificateAuthorityCertificate_RootCA
=== PAUSE TestAccAwsAcmpcaCertificateAuthorityCertificate_RootCA
=== RUN   TestAccAwsAcmpcaCertificateAuthorityCertificate_UpdateRootCA
=== PAUSE TestAccAwsAcmpcaCertificateAuthorityCertificate_UpdateRootCA
=== RUN   TestAccAwsAcmpcaCertificateAuthorityCertificate_SubordinateCA
=== PAUSE TestAccAwsAcmpcaCertificateAuthorityCertificate_SubordinateCA
=== RUN   TestAccAwsAcmpcaCertificateAuthority_basic
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_basic
=== RUN   TestAccAwsAcmpcaCertificateAuthority_disappears
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_disappears
=== RUN   TestAccAwsAcmpcaCertificateAuthority_Enabled
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_Enabled
=== RUN   TestAccAwsAcmpcaCertificateAuthority_DeleteFromActiveState
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_DeleteFromActiveState
=== RUN   TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname
=== RUN   TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled
=== RUN   TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays
=== RUN   TestAccAwsAcmpcaCertificateAuthority_Tags
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_Tags
=== RUN   TestAccAwsAcmpcaCertificate_RootCertificate
=== PAUSE TestAccAwsAcmpcaCertificate_RootCertificate
=== RUN   TestAccAwsAcmpcaCertificate_SubordinateCertificate
=== PAUSE TestAccAwsAcmpcaCertificate_SubordinateCertificate
=== RUN   TestAccAwsAcmpcaCertificate_EndEntityCertificate
=== PAUSE TestAccAwsAcmpcaCertificate_EndEntityCertificate
=== RUN   TestAccAwsAcmpcaCertificate_Validity_EndDate
=== PAUSE TestAccAwsAcmpcaCertificate_Validity_EndDate
=== RUN   TestAccAwsAcmpcaCertificate_Validity_Absolute
=== PAUSE TestAccAwsAcmpcaCertificate_Validity_Absolute
=== CONT  TestAccAwsAcmpcaCertificateAuthorityCertificate_RootCA
=== CONT  TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays
=== CONT  TestAccAwsAcmpcaCertificate_Validity_Absolute
=== CONT  TestAccAwsAcmpcaCertificate_Validity_EndDate
=== CONT  TestAccAwsAcmpcaCertificate_EndEntityCertificate
=== CONT  TestAccAwsAcmpcaCertificate_SubordinateCertificate
=== CONT  TestAccAwsAcmpcaCertificate_RootCertificate
=== CONT  TestAccAwsAcmpcaCertificateAuthority_Tags
=== CONT  TestAccAwsAcmpcaCertificateAuthority_Enabled
=== CONT  TestAccAwsAcmpcaCertificateAuthorityCertificate_UpdateRootCA
=== CONT  TestAccAwsAcmpcaCertificateAuthority_DeleteFromActiveState
=== CONT  TestAccAwsAcmpcaCertificateAuthorityCertificate_SubordinateCA
=== CONT  TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname
=== CONT  TestAccAwsAcmpcaCertificateAuthority_disappears
=== CONT  TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled
=== CONT  TestAccAwsAcmpcaCertificateAuthority_basic
--- PASS: TestAccAwsAcmpcaCertificateAuthority_disappears (15.31s)
--- PASS: TestAccAwsAcmpcaCertificate_RootCertificate (22.02s)
--- PASS: TestAccAwsAcmpcaCertificate_Validity_Absolute (25.52s)
--- PASS: TestAccAwsAcmpcaCertificate_SubordinateCertificate (26.06s)
--- PASS: TestAccAwsAcmpcaCertificate_Validity_EndDate (27.92s)
--- PASS: TestAccAwsAcmpcaCertificateAuthorityCertificate_SubordinateCA (29.04s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_DeleteFromActiveState (30.66s)
--- PASS: TestAccAwsAcmpcaCertificateAuthorityCertificate_RootCA (34.78s)
--- PASS: TestAccAwsAcmpcaCertificateAuthorityCertificate_UpdateRootCA (35.05s)
--- PASS: TestAccAwsAcmpcaCertificate_EndEntityCertificate (39.07s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_basic (39.72s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Enabled (42.82s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Tags (49.94s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays (52.08s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled (64.80s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname (82.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	85.299s

[ghost]

This has been released in version 3.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!