ACMPCA Issue Certificate from Private CA #10213

dvdliao · 2019-09-24T02:04:22Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

FEATURES:

* **New Data Source:** `aws_acmpca_private_certificate` ([#10183](https://github.com/terraform-providers/terraform-provider-aws/issues/10183))
* **New Resource:** `aws_acmpca_private_certificate` ([#10183](https://github.com/terraform-providers/terraform-provider-aws/issues/10183))

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccAwsAcmpcaPrivateCertificate_Basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAwsAcmpcaPrivateCertificate_Basic -timeout 120m
=== RUN   TestAccAwsAcmpcaPrivateCertificate_Basic
=== PAUSE TestAccAwsAcmpcaPrivateCertificate_Basic
=== CONT  TestAccAwsAcmpcaPrivateCertificate_Basic
--- PASS: TestAccAwsAcmpcaPrivateCertificate_Basic (19.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	19.124s

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsAcmpcaPrivateCertificate_Basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccDataSourceAwsAcmpcaPrivateCertificate_Basic -timeout 120m
=== RUN   TestAccDataSourceAwsAcmpcaPrivateCertificate_Basic
=== PAUSE TestAccDataSourceAwsAcmpcaPrivateCertificate_Basic
=== CONT  TestAccDataSourceAwsAcmpcaPrivateCertificate_Basic
--- PASS: TestAccDataSourceAwsAcmpcaPrivateCertificate_Basic (23.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.621s

dvdliao · 2019-09-25T20:16:42Z

hey @bflad or anyone on team, can I get a review? 🙂

dvdliao · 2019-10-04T18:10:26Z

hi @bflad 👋 do you have an estimate on when you can get to this PR? thanks

bflad · 2019-10-06T18:24:33Z

Hi @dvdliao 👋 Sorry, my focus is elsewhere at the moment and I cannot provide an estimate for when the maintainers will have the time or bandwidth to review this (I'm not their manager 😉). In the meantime, you may want to double check the Contributing Guide for some guidelines and checklists to speed up the review process when that does occur. (e.g. its a little tucked away under the Pull Request Lifecycle section, but the maintainers handle updates to the CHANGELOG.md file.)

dvdliao · 2019-10-07T05:02:05Z

Thanks for the update, hoping this will be relatively soon.

venky999 · 2019-10-14T08:11:52Z

Is there any update this issue @terraformbot we are awaiting for this long.. its bit disappointing that @dvdliao has to merge from master so many times ..since the pull request is not reviewed... feel its discouraging to create pull request for new features...

dvdliao · 2019-10-24T03:18:41Z

any updates on timeline?

dvdliao · 2019-11-07T17:30:57Z

Hi @bflad any ideas when the team can get to this?

robbruce · 2019-11-08T19:30:17Z

@dvdliao brought your code up to date, but don't seem to be able to do a pull request into your code

https://github.com/crimsonmacaw/terraform-provider-aws/tree/acmpca-private-cert

DrFaust92

looks good, another small set of changes

can you add a TestAccAwsAcmpcaPrivateCertificate_disappears test?

aws/resource_aws_acmpca_private_certificate.go

dvdliao · 2020-05-05T20:33:13Z

looks good, another small set of changes

can you add a TestAccAwsAcmpcaPrivateCertificate_disappears test?

I have a stub here: https://github.com/terraform-providers/terraform-provider-aws/pull/10213/files#diff-670696a9c5c93937e4abe325d689c83eR41 problem is at the time AWS did not provide a way to verify the certificate revocation list

dvdliao · 2020-05-08T04:41:00Z

@DrFaust92 another look please? 🙂

dvdliao · 2020-06-01T01:52:00Z

any updates?

DrFaust92

Some more minor changes,
FY, i can review this but i'm not a maintainer so i cannot approve these changes. :<

regarding import, passthrough will not work here but can you try to implement import using a logic similar to https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_acmpca_certificate_authority.go#L23

aws/data_source_aws_acmpca_private_certificate.go

dvdliao · 2020-06-02T06:33:01Z

any ideas for how to get maintainers attention?

ewbankkit · 2020-06-10T13:51:49Z

@dvdliao Does the ACMPCA need to be activated before it can issue a valid certificate?
i.e. in test case you have, is the aws_acmpca_private_certificate in Failed state?

dvdliao · 2020-06-12T03:06:48Z

@dvdliao Does the ACMPCA need to be activated before it can issue a valid certificate?
i.e. in test case you have, is the aws_acmpca_private_certificate in Failed state?

ah you are right, i tested this with an internal ACMPCA CA that has already been activated, but then changed the test to create one.

AFAIK the aws_acmpca_certificate_authority resource cannot auto activate the CA

ewbankkit · 2020-06-12T20:37:07Z

@dvdliao I have code that does that (for acceptance testing) in #13684. Once that is merged we can look at adding code to aws_acmpca_certificate_authority to activate it - do you think it's best to always activate a ROOT CA on creation?

dvdliao · 2020-06-12T20:59:23Z

@ewbankkit Nice!

do you think it's best to always activate a ROOT CA on creation?

Yes

teamterraform · 2020-08-18T20:13:45Z

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Action Required: Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

annyip · 2020-10-23T19:45:35Z

what's the status on this?

gflarity · 2021-02-12T19:54:24Z

How do we move this forward and get this reviewed?

taylorsmcclure · 2021-02-16T18:20:50Z

I would love to move my PCA infrastructure into terraform. Is it possible to merge this soon?

ghost · 2021-03-12T01:02:47Z

This has been released in version 3.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2021-04-11T17:10:47Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

dvdliao added 4 commits September 23, 2019 16:17

private cert issuing

6807a0b

tests

b88a02c

data resources and docs

557335d

minor

f5f1fad

dvdliao requested a review from a team September 24, 2019 02:04

Merge branch 'master' into acmpca-private-cert

853bdf5

dvdliao changed the title ~~Acmpca private cert~~ ACMPCA Issue Certificate from Private CA Sep 24, 2019

dvdliao and others added 2 commits September 23, 2019 19:35

typos

142d8be

Merge branch 'master' into acmpca-private-cert

84b9f92

dvdliao and others added 6 commits September 26, 2019 16:20

Merge branch 'master' into acmpca-private-cert

c8fad70

update changelog

74f9787

Merge branch 'master' into acmpca-private-cert

de44fd3

Merge branch 'master' into acmpca-private-cert

6b4fdc1

Merge branch 'master' into acmpca-private-cert

5252c6e

fix conflicts

eee3a97

Merge branch 'master' into acmpca-private-cert

89170da

Merge branch 'master' into acmpca-private-cert

ff75379

DrFaust92 suggested changes May 5, 2020

View reviewed changes

aws/resource_aws_acmpca_private_certificate.go Outdated Show resolved Hide resolved

Update resource_aws_acmpca_private_certificate.go

1c65502

dvdliao requested review from DrFaust92 and removed request for a team June 1, 2020 01:48

DrFaust92 suggested changes Jun 1, 2020

View reviewed changes

aws/data_source_aws_acmpca_private_certificate.go Outdated Show resolved Hide resolved

dvdliao added 2 commits June 1, 2020 23:12

Merge branch 'master' into acmpca-private-cert

b8efe13

cr

d4505bc

ewbankkit mentioned this pull request Jun 9, 2020

Add activation of ACMPCA CA to acceptance tests #13684

Merged

anGie44 force-pushed the master branch from 6c6566f to 081bf57 Compare June 29, 2020 16:14

Base automatically changed from master to main January 23, 2021 00:56

breathingdust requested a review from a team as a code owner January 23, 2021 00:56

gdavison self-assigned this Feb 19, 2021

gdavison mentioned this pull request Feb 27, 2021

ACM PCA: add resource to issue certificates from private CA and import CA certificates #17850

Merged

gdavison merged commit 1e7d722 into hashicorp:main Mar 11, 2021

github-actions bot added this to the v3.32.0 milestone Mar 11, 2021

ghost locked as resolved and limited conversation to collaborators Apr 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ACMPCA Issue Certificate from Private CA #10213

ACMPCA Issue Certificate from Private CA #10213

dvdliao commented Sep 24, 2019

dvdliao commented Sep 25, 2019

dvdliao commented Oct 4, 2019

bflad commented Oct 6, 2019

dvdliao commented Oct 7, 2019

venky999 commented Oct 14, 2019

dvdliao commented Oct 24, 2019

dvdliao commented Nov 7, 2019

robbruce commented Nov 8, 2019

DrFaust92 left a comment

dvdliao commented May 5, 2020

dvdliao commented May 8, 2020

dvdliao commented Jun 1, 2020

DrFaust92 left a comment

dvdliao commented Jun 2, 2020

ewbankkit commented Jun 10, 2020

dvdliao commented Jun 12, 2020 •

edited

Loading

ewbankkit commented Jun 12, 2020

dvdliao commented Jun 12, 2020

teamterraform commented Aug 18, 2020

annyip commented Oct 23, 2020

gflarity commented Feb 12, 2021

taylorsmcclure commented Feb 16, 2021

ghost commented Mar 12, 2021

ghost commented Apr 11, 2021

ACMPCA Issue Certificate from Private CA #10213

ACMPCA Issue Certificate from Private CA #10213

Conversation

dvdliao commented Sep 24, 2019

Community Note

dvdliao commented Sep 25, 2019

dvdliao commented Oct 4, 2019

bflad commented Oct 6, 2019

dvdliao commented Oct 7, 2019

venky999 commented Oct 14, 2019

dvdliao commented Oct 24, 2019

dvdliao commented Nov 7, 2019

robbruce commented Nov 8, 2019

DrFaust92 left a comment

Choose a reason for hiding this comment

dvdliao commented May 5, 2020

dvdliao commented May 8, 2020

dvdliao commented Jun 1, 2020

DrFaust92 left a comment

Choose a reason for hiding this comment

dvdliao commented Jun 2, 2020

ewbankkit commented Jun 10, 2020

dvdliao commented Jun 12, 2020 • edited Loading

ewbankkit commented Jun 12, 2020

dvdliao commented Jun 12, 2020

teamterraform commented Aug 18, 2020

Notification of Recent and Upcoming Changes to Contributions

Action Required: Terraform 0.12 Syntax

Action Required: Terraform Plugin SDK Version 2

Action Required: Removal of website/aws.erb File

Upcoming Change of Git Branch Naming

Upcoming Change of GitHub Organization

annyip commented Oct 23, 2020

gflarity commented Feb 12, 2021

taylorsmcclure commented Feb 16, 2021

ghost commented Mar 12, 2021

ghost commented Apr 11, 2021

dvdliao commented Jun 12, 2020 •

edited

Loading