Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make snapshot_identifier computed #18013

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Make snapshot_identifier computed #18013

merged 3 commits into from
Mar 11, 2021

Conversation

bill-rich
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #467

Output from acceptance testing:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBInstance_SnapshotIdentifierRemoved -timeout 120m
=== RUN   TestAccAWSDBInstance_SnapshotIdentifierRemoved
=== PAUSE TestAccAWSDBInstance_SnapshotIdentifierRemoved
=== CONT  TestAccAWSDBInstance_SnapshotIdentifierRemoved
--- PASS: TestAccAWSDBInstance_SnapshotIdentifierRemoved (1386.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1386.601s

@bill-rich bill-rich requested a review from a team as a code owner March 10, 2021 08:50
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 10, 2021
@bill-rich bill-rich force-pushed the e-make_snapshot_identifier_computed branch from 4f8a45c to 7da9766 Compare March 10, 2021 08:54
bflad
bflad approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me 🚀

.changelog/18013.txt Outdated Show resolved Hide resolved
aws/resource_aws_db_instance_test.go Outdated Show resolved Hide resolved
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 10, 2021
bill-rich and others added 2 commits March 11, 2021 11:35
@bill-rich @bflad
Update .changelog/18013.txt
277cf7b 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@bill-rich @bflad
Update aws/resource_aws_db_instance_test.go
d9664f5 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@bill-rich bill-rich merged commit dce223f into main Mar 11, 2021
@bill-rich bill-rich deleted the e-make_snapshot_identifier_computed branch March 11, 2021 20:16
@github-actions github-actions bot added this to the v3.32.0 milestone Mar 11, 2021
github-actions bot pushed a commit that referenced this pull request Mar 11, 2021
Update CHANGELOG.md for #18013
f0259a7
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 3.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

This was referenced Mar 12, 2021
Closed
Closed
Closed
Closed
@ghost
Copy link

ghost commented Apr 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.32.0
Development

Successfully merging this pull request may close these issues.

With aws_db_instance when you remove the snapshot_identifier it wants to force a new resource
2 participants
@bill-rich @bflad