Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support AppConfig Hosted Configuration Version #19324

Merged
merged 17 commits into from
Jul 12, 2021
Merged

feat: support AppConfig Hosted Configuration Version #19324

merged 17 commits into from
Jul 12, 2021

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented May 12, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11973 #18032 #19320 #19307

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAppConfigHostedConfigurationVersion'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppConfigHostedConfigurationVersion -timeout 180m
=== RUN   TestAccAWSAppConfigHostedConfigurationVersion_basic
=== PAUSE TestAccAWSAppConfigHostedConfigurationVersion_basic
=== RUN   TestAccAWSAppConfigHostedConfigurationVersion_disappears
=== PAUSE TestAccAWSAppConfigHostedConfigurationVersion_disappears
=== CONT  TestAccAWSAppConfigHostedConfigurationVersion_basic
=== CONT  TestAccAWSAppConfigHostedConfigurationVersion_disappears
--- PASS: TestAccAWSAppConfigHostedConfigurationVersion_disappears (45.99s)
--- PASS: TestAccAWSAppConfigHostedConfigurationVersion_basic (55.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.708s

This adds aws_appconfig_hosted_configuration_version to #19320 to support AWS AppConfig Hosted Configuration Version.

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appconfig Issues and PRs that pertain to the appconfig service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 12, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 12, 2021
@anGie44 anGie44 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 12, 2021
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jul 12, 2021
@anGie44 anGie44 self-assigned this Jul 12, 2021
@anGie44 anGie44 marked this pull request as ready for review July 12, 2021 12:27
@suzuki-shunsuke
Copy link
Contributor Author

I ran the acceptance test and updated the description.
#19324 (comment)

Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @suzuki-shunsuke ! Great work here 🚀

Output of acceptance tests (commercial):

--- PASS: TestAccAWSAppConfigConfigurationProfile_disappears (50.61s)
--- PASS: TestAccAWSAppConfigApplication_basic (51.80s)
--- PASS: TestAccAWSAppConfigHostedConfigurationVersion_disappears (67.38s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_basic (67.94s)
--- PASS: TestAccAWSAppConfigEnvironment_basic (71.90s)
--- PASS: TestAccAWSAppConfigHostedConfigurationVersion_basic (79.48s)
--- PASS: TestAccAWSAppConfigApplication_updateName (84.61s)
--- PASS: TestAccAWSAppConfigApplication_disappears (35.12s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Validators_Multiple (88.09s)
--- PASS: TestAccAWSAppConfigEnvironment_updateName (102.04s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_updateDescription (108.67s)
--- PASS: TestAccAWSAppConfigEnvironment_MultipleEnvironments (110.88s)
--- PASS: TestAccAWSAppConfigApplication_updateDescription (114.34s)
--- PASS: TestAccAWSAppConfigApplication_Tags (114.36s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Validators_Lambda (115.94s)
--- PASS: TestAccAWSAppConfigEnvironment_Tags (121.95s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Tags (122.03s)
--- PASS: TestAccAWSAppConfigEnvironment_updateDescription (124.21s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Validators_JSON (125.34s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_updateName (77.00s)
--- PASS: TestAccAWSAppConfigEnvironment_Monitors (130.74s)

GovCloud:

--- PASS: TestAccAWSAppConfigEnvironment_disappears (50.34s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_disappears (51.31s)
--- PASS: TestAccAWSAppConfigEnvironment_basic (54.60s)
--- PASS: TestAccAWSAppConfigHostedConfigurationVersion_disappears (55.97s)
--- PASS: TestAccAWSAppConfigApplication_basic (58.84s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_basic (59.39s)
--- PASS: TestAccAWSAppConfigHostedConfigurationVersion_basic (67.83s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Validators_Multiple (80.17s)
--- PASS: TestAccAWSAppConfigApplication_disappears (31.61s)
--- PASS: TestAccAWSAppConfigApplication_updateName (88.11s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Validators_Lambda (104.06s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_updateName (104.23s)
--- PASS: TestAccAWSAppConfigEnvironment_updateName (105.31s)
--- PASS: TestAccAWSAppConfigEnvironment_MultipleEnvironments (105.51s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_updateDescription (105.51s)
--- PASS: TestAccAWSAppConfigApplication_Tags (114.99s)
--- PASS: TestAccAWSAppConfigEnvironment_Tags (118.73s)
--- PASS: TestAccAWSAppConfigApplication_updateDescription (122.13s)
--- PASS: TestAccAWSAppConfigEnvironment_updateDescription (123.94s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Tags (124.61s)
--- PASS: TestAccAWSAppConfigEnvironment_Monitors (133.78s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Validators_JSON (98.64s)

@anGie44 anGie44 added this to the v3.50.0 milestone Jul 12, 2021
@anGie44 anGie44 merged commit 0d5d425 into hashicorp:main Jul 12, 2021
@suzuki-shunsuke suzuki-shunsuke deleted the feat/appconfig_hosted_configuration_version branch July 12, 2021 20:01
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/appconfig Issues and PRs that pertain to the appconfig service. size/XL Managed by automation to categorize the size of a PR. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants