Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add aws_appconfig_application and aws_appconfig_environment #19307

Merged
merged 22 commits into from
Jul 12, 2021
Merged

feat: add aws_appconfig_application and aws_appconfig_environment #19307

merged 22 commits into from
Jul 12, 2021

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented May 11, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11973 #18032 #19320

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAppConfig'                      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppConfig -timeout 180m
=== RUN   TestAccAWSAppConfigApplication_basic
=== PAUSE TestAccAWSAppConfigApplication_basic
=== RUN   TestAccAWSAppConfigApplication_disappears
=== PAUSE TestAccAWSAppConfigApplication_disappears
=== RUN   TestAccAWSAppConfigApplication_Tags
=== PAUSE TestAccAWSAppConfigApplication_Tags
=== RUN   TestAccAWSAppConfigEnvironment_basic
=== PAUSE TestAccAWSAppConfigEnvironment_basic
=== RUN   TestAccAWSAppConfigEnvironment_disappears
=== PAUSE TestAccAWSAppConfigEnvironment_disappears
=== RUN   TestAccAWSAppConfigEnvironment_Tags
=== PAUSE TestAccAWSAppConfigEnvironment_Tags
=== CONT  TestAccAWSAppConfigApplication_basic
=== CONT  TestAccAWSAppConfigEnvironment_disappears
=== CONT  TestAccAWSAppConfigEnvironment_Tags
=== CONT  TestAccAWSAppConfigEnvironment_basic
=== CONT  TestAccAWSAppConfigApplication_disappears
=== CONT  TestAccAWSAppConfigApplication_Tags
--- PASS: TestAccAWSAppConfigApplication_disappears (93.56s)
--- PASS: TestAccAWSAppConfigEnvironment_disappears (108.12s)
--- PASS: TestAccAWSAppConfigApplication_basic (125.29s)
--- PASS: TestAccAWSAppConfigEnvironment_basic (133.89s)
--- PASS: TestAccAWSAppConfigApplication_Tags (218.01s)
--- PASS: TestAccAWSAppConfigEnvironment_Tags (237.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	239.478s

This includes #18032 because aws_appconfig_application is required for acceptance tests of aws_appconfig_environment.
This fixes some lint errors of #18032 too. fd94cb2 b47ccb6
This pull request adds aws_appconfig_application and aws_appconfig_environment to support AppConfig Application and AppConfig Environment.

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appconfig Issues and PRs that pertain to the appconfig service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 11, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 11, 2021
@ghost ghost added service/autoscaling Issues and PRs that pertain to the autoscaling service. service/codebuild Issues and PRs that pertain to the codebuild service. service/ec2 Issues and PRs that pertain to the ec2 service. service/glue Issues and PRs that pertain to the glue service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3control Issues and PRs that pertain to the s3control service. service/securityhub Issues and PRs that pertain to the securityhub service. labels May 11, 2021
@suzuki-shunsuke suzuki-shunsuke requested a review from a team as a code owner May 11, 2021 12:23
This was referenced May 11, 2021
Merged
Merged
Merged
@suzuki-shunsuke
Copy link
Contributor Author

Please remove unrelated labels. #19307 (comment)

  • service/autoscaling
  • service/codebuild
  • service/ec2
  • service/glue
  • service/route53resolver
  • service/s3control
  • service/securityhub

And please review.

@suzuki-shunsuke suzuki-shunsuke mentioned this pull request May 30, 2021
Closed
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed service/autoscaling Issues and PRs that pertain to the autoscaling service. service/codebuild Issues and PRs that pertain to the codebuild service. service/ec2 Issues and PRs that pertain to the ec2 service. service/glue Issues and PRs that pertain to the glue service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3control Issues and PRs that pertain to the s3control service. service/securityhub Issues and PRs that pertain to the securityhub service. labels Jun 9, 2021
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Jul 11, 2021
@anGie44 anGie44 mentioned this pull request Jul 11, 2021
Closed
@anGie44 anGie44 self-assigned this Jul 11, 2021
@anGie44
Copy link
Contributor

anGie44 commented Jul 12, 2021 •
edited
Loading

Hi @suzuki-shunsuke, thank you for this PR and carrying over the work from #18032! Overall, this looks really great 👍 I'm going to add in a commit to add support for default tags, extra test coverage, and update the documentation accordingly to get this merged in and released with our next milestone.

Output of acceptance tests:

--- PASS: TestAccAWSAppConfigApplication_disappears (64.85s)
--- PASS: TestAccAWSAppConfigApplication_basic (89.64s)
--- PASS: TestAccAWSAppConfigEnvironment_disappears (117.39s)
--- PASS: TestAccAWSAppConfigEnvironment_basic (131.63s)
--- PASS: TestAccAWSAppConfigApplication_updateName (202.15s)
--- PASS: TestAccAWSAppConfigEnvironment_updateName (232.10s)
--- PASS: TestAccAWSAppConfigEnvironment_MultipleEnvironments (279.91s)
--- PASS: TestAccAWSAppConfigApplication_Tags (288.05s)
--- PASS: TestAccAWSAppConfigApplication_updateDescription (290.70s)
--- PASS: TestAccAWSAppConfigEnvironment_Tags (306.05s)
--- PASS: TestAccAWSAppConfigEnvironment_updateDescription (323.83s)
--- PASS: TestAccAWSAppConfigEnvironment_Monitors (332.98s)

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jul 12, 2021
@anGie44
* Add Default Tags Support
876c4be 
* Update documentation
* Add test coverage for resource updates
* refactor expand/flatten methods
@anGie44 anGie44 added this to the v3.50.0 milestone Jul 12, 2021
@anGie44 anGie44 merged commit 24656c8 into hashicorp:main Jul 12, 2021
@suzuki-shunsuke suzuki-shunsuke deleted the feat/appconfig_environment-2 branch July 12, 2021 20:02
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Jul 14, 2021
Merged
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/appconfig Issues and PRs that pertain to the appconfig service. size/XL Managed by automation to categorize the size of a PR. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.50.0
Development

Successfully merging this pull request may close these issues.
4 participants
@suzuki-shunsuke @anGie44 @DrFaust92 @Isaiah-Turner