Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag filter to aws_efs_file_system data source #20399

Merged
merged 5 commits into from
Aug 26, 2021

Conversation

jakauppila
Copy link
Contributor

@jakauppila jakauppila commented Aug 2, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18097

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsEfs'

=== RUN   TestAccDataSourceAwsEfsFileSystem_id
=== PAUSE TestAccDataSourceAwsEfsFileSystem_id
=== RUN   TestAccDataSourceAwsEfsFileSystem_tags
=== PAUSE TestAccDataSourceAwsEfsFileSystem_tags
=== RUN   TestAccDataSourceAwsEfsFileSystem_name
=== PAUSE TestAccDataSourceAwsEfsFileSystem_name
=== RUN   TestAccDataSourceAwsEfsFileSystem_availabilityZone
=== PAUSE TestAccDataSourceAwsEfsFileSystem_availabilityZone
=== RUN   TestAccDataSourceAwsEfsFileSystem_NonExistent
=== PAUSE TestAccDataSourceAwsEfsFileSystem_NonExistent
=== RUN   TestAccDataSourceAwsEfsMountTarget_basic
=== PAUSE TestAccDataSourceAwsEfsMountTarget_basic
=== RUN   TestAccDataSourceAwsEfsMountTarget_byAccessPointID
=== PAUSE TestAccDataSourceAwsEfsMountTarget_byAccessPointID
=== RUN   TestAccDataSourceAwsEfsMountTarget_byFileSystemID
=== PAUSE TestAccDataSourceAwsEfsMountTarget_byFileSystemID
=== CONT  TestAccDataSourceAwsEfsFileSystem_id
=== CONT  TestAccDataSourceAwsEfsMountTarget_basic
=== CONT  TestAccDataSourceAwsEfsMountTarget_byFileSystemID
=== CONT  TestAccDataSourceAwsEfsMountTarget_byAccessPointID
=== CONT  TestAccDataSourceAwsEfsFileSystem_availabilityZone
=== CONT  TestAccDataSourceAwsEfsFileSystem_NonExistent
=== CONT  TestAccDataSourceAwsEfsFileSystem_name
=== CONT  TestAccDataSourceAwsEfsFileSystem_tags
--- PASS: TestAccDataSourceAwsEfsFileSystem_NonExistent (13.13s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_name (47.60s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_id (57.83s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_tags (58.17s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_availabilityZone (67.11s)
--- PASS: TestAccDataSourceAwsEfsMountTarget_byFileSystemID (145.16s)
--- PASS: TestAccDataSourceAwsEfsMountTarget_basic (152.66s)
--- PASS: TestAccDataSourceAwsEfsMountTarget_byAccessPointID (160.19s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       160.242s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/efs Issues and PRs that pertain to the efs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Aug 2, 2021
@zhelding zhelding self-assigned this Aug 26, 2021
@zhelding
Copy link
Contributor

Hi @jakauppila; thanks so much for your first contribution to the provider!

I've made a couple small formatting changes, but otherwise this looks good to me.

Merging!

@zhelding zhelding merged commit aaa1e23 into hashicorp:main Aug 26, 2021
@github-actions github-actions bot added this to the v3.56.0 milestone Aug 26, 2021
@jakauppila
Copy link
Contributor Author

Thanks @zhelding !

@github-actions
Copy link

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 4, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/efs Issues and PRs that pertain to the efs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support filters on aws_efs_file_system data source
3 participants