-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_launch_tamplate: Allow more resource values for tag specification #20409
r/aws_launch_tamplate: Allow more resource values for tag specification #20409
Conversation
d16481c
to
c84d310
Compare
c84d310
to
c5c4df2
Compare
Actually, this is a duplicate of #16732. But that pr covers more resources and was never merged, so this might have a better chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAWSLaunchTemplate_data'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplate_data -timeout 180m
=== RUN TestAccAWSLaunchTemplate_data
=== PAUSE TestAccAWSLaunchTemplate_data
=== CONT TestAccAWSLaunchTemplate_data
--- PASS: TestAccAWSLaunchTemplate_data (17.18s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 20.725s
@gordonbondon Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #19140
Relates #14601
Replaced hardcoded list of allowed resource type strings according to #14601 and this comment
Output from acceptance testing: