Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/aws chime voice connector origination #20676

Merged
merged 6 commits into from
Sep 8, 2021
Merged

F/aws chime voice connector origination #20676

merged 6 commits into from
Sep 8, 2021

Conversation

aleks1001
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSChimeVoiceConnectorOrigination_ -timeout 180m
=== RUN   TestAccAWSChimeVoiceConnectorOrigination_basic
=== PAUSE TestAccAWSChimeVoiceConnectorOrigination_basic
=== RUN   TestAccAWSChimeVoiceConnectorOrigination_disappears
=== PAUSE TestAccAWSChimeVoiceConnectorOrigination_disappears
=== RUN   TestAccAWSChimeVoiceConnectorOrigination_update
=== PAUSE TestAccAWSChimeVoiceConnectorOrigination_update
=== CONT  TestAccAWSChimeVoiceConnectorOrigination_basic
=== CONT  TestAccAWSChimeVoiceConnectorOrigination_update
=== CONT  TestAccAWSChimeVoiceConnectorOrigination_disappears
--- PASS: TestAccAWSChimeVoiceConnectorOrigination_disappears (27.46s)
--- PASS: TestAccAWSChimeVoiceConnectorOrigination_basic (39.32s)
--- PASS: TestAccAWSChimeVoiceConnectorOrigination_update (58.88s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       62.198s
...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Aug 24, 2021
@breathingdust breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 26, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this PR @aleks1001, great work overall! To ensure we get this into an upcoming release, similar to #20667 , I've pushed an additional commit to address the acceptance test validation of Exists/Destroy functionality and some small additions in the CRUD ops to ensure all fields were importable.

Output of acceptance tests:

--- PASS: TestAccAWSChimeVoiceConnectorOrigination_disappears (15.92s)
--- PASS: TestAccAWSChimeVoiceConnectorOrigination_basic (17.61s)
--- PASS: TestAccAWSChimeVoiceConnectorOrigination_update (30.26s)

@anGie44 anGie44 added this to the v3.58.0 milestone Sep 8, 2021
@anGie44 anGie44 merged commit f478dae into hashicorp:main Sep 8, 2021
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

This functionality has been released in v3.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants