Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource aws_chime_voice_connector_termination #20667

Merged
merged 15 commits into from
Sep 8, 2021
Merged

Add new resource aws_chime_voice_connector_termination #20667

merged 15 commits into from
Sep 8, 2021

Conversation

aleks1001
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSChimeVoiceConnectorTermination_ -timeout 180m
=== RUN   TestAccAWSChimeVoiceConnectorTermination_basic
=== PAUSE TestAccAWSChimeVoiceConnectorTermination_basic
=== RUN   TestAccAWSChimeVoiceConnectorTermination_disappears
=== PAUSE TestAccAWSChimeVoiceConnectorTermination_disappears
=== RUN   TestAccAWSChimeVoiceConnectorTermination_update
=== PAUSE TestAccAWSChimeVoiceConnectorTermination_update
=== CONT  TestAccAWSChimeVoiceConnectorTermination_basic
=== CONT  TestAccAWSChimeVoiceConnectorTermination_update
=== CONT  TestAccAWSChimeVoiceConnectorTermination_disappears
--- PASS: TestAccAWSChimeVoiceConnectorTermination_disappears (37.13s)
--- PASS: TestAccAWSChimeVoiceConnectorTermination_basic (37.37s)
--- PASS: TestAccAWSChimeVoiceConnectorTermination_update (38.37s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       41.197s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 24, 2021
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one small change.

@aleks1001 aleks1001 requested a review from bill-rich August 26, 2021 15:05
@breathingdust breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 26, 2021
@anGie44 anGie44 self-assigned this Sep 2, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aleks1001 , thanks again for this PR! Just a couple additional comments to address. Reach out if you have any questions 😃

aws/resource_aws_chime_voice_connector_termination.go Outdated Show resolved Hide resolved
aws/resource_aws_chime_voice_connector_termination.go Outdated Show resolved Hide resolved
aws/resource_aws_chime_voice_connector_termination.go Outdated Show resolved Hide resolved
aws/resource_aws_chime_voice_connector_termination.go Outdated Show resolved Hide resolved
aws/resource_aws_chime_voice_connector_termination.go Outdated Show resolved Hide resolved
aws/resource_aws_chime_voice_connector_termination.go Outdated Show resolved Hide resolved
aleks1001 and others added 3 commits September 3, 2021 16:49
Co-authored-by: angie pinilla <angie@hashicorp.com>
Co-authored-by: angie pinilla <angie@hashicorp.com>
Co-authored-by: angie pinilla <angie@hashicorp.com>
aleks1001 and others added 3 commits September 3, 2021 16:58
@aleks1001 aleks1001 requested a review from anGie44 September 3, 2021 21:35
@aleks1001 aleks1001 requested a review from anGie44 September 7, 2021 20:21
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @aleks1001 🚀 🚀 ! I've pushed a commit to address a finding I stumbled upon during running the acceptance tests -- looks like the Voice Connector resource can at times return an API error during creation when multiple resources are created in parallel, so I've added some additional logic in our retry handlers. The tests also revealed we were still checking for the voice connector resource instead of the voice connector termination resource, so those references have also been updated.

Output of acceptance tests:

--- PASS: TestAccAWSChimeVoiceConnectorTermination_basic (17.65s)
--- PASS: TestAccAWSChimeVoiceConnectorTermination_update (25.75s)
--- PASS: TestAccAWSChimeVoiceConnectorTermination_disappears (33.22s)

@anGie44 anGie44 added this to the v3.58.0 milestone Sep 8, 2021
@anGie44 anGie44 merged commit c94ebdf into hashicorp:main Sep 8, 2021
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

This functionality has been released in v3.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/chime Issues and PRs that pertain to the chime service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants