r/fsx_ontap_filesystem - new resource #20951

DrFaust92 · 2021-09-18T12:14:04Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20778

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSFsxOntapFileSystem_'
--- PASS: TestAccAWSFsxOntapFileSystem_basic (2401.51s)
--- PASS: TestAccAWSFsxOntapFileSystem_kmsKeyId (2467.56s)
--- PASS: TestAccAWSFsxOntapFileSystem_routeTableIds (2513.34s)
--- PASS: TestAccAWSFsxOntapFileSystem_fsxAdminPassword (2540.97s)
--- PASS: TestAccAWSFsxOntapFileSystem_dailyAutomaticBackupStartTime (2584.58s)
--- PASS: TestAccAWSFsxOntapFileSystem_disappears (2588.81s)
--- PASS: TestAccAWSFsxOntapFileSystem_tags (2619.38s)
--- PASS: TestAccAWSFsxOntapFileSystem_endpointIpAddressRange (2644.31s)
--- PASS: TestAccAWSFsxOntapFileSystem_diskIopsConfiguration (2666.75s)
--- PASS: TestAccAWSFsxOntapFileSystem_weeklyMaintenanceStartTime (2682.98s)
--- PASS: TestAccAWSFsxOntapFileSystem_automaticBackupRetentionDays (2773.84s)

…ps://docs.aws.amazon.com/fsx/latest/APIReference/API_UpdateFileSystem.html. Acceptance failure: === CONT TestAccAWSFsxOntapFileSystem_storageCapacity resource_aws_fsx_ontap_file_system_test.go:309: Step 4/4 error: Error running apply: exit status 1 Error: error updating FSx ONTAP File System (fs-029a44228aa99a660): BadRequest: Modifying the storage capacity of an ONTAP file system is not supported. with aws_fsx_ontap_file_system.test, on terraform_plugin_test.tf line 29, in resource "aws_fsx_ontap_file_system" "test": 29: resource "aws_fsx_ontap_file_system" "test" { --- FAIL: TestAccAWSFsxOntapFileSystem_storageCapacity (3867.39s)

ewbankkit

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccAWSFsxOntapFileSystem_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxOntapFileSystem_ -timeout 180m
=== RUN   TestAccAWSFsxOntapFileSystem_basic
=== PAUSE TestAccAWSFsxOntapFileSystem_basic
=== RUN   TestAccAWSFsxOntapFileSystem_fsxAdminPassword
=== PAUSE TestAccAWSFsxOntapFileSystem_fsxAdminPassword
=== RUN   TestAccAWSFsxOntapFileSystem_endpointIpAddressRange
=== PAUSE TestAccAWSFsxOntapFileSystem_endpointIpAddressRange
=== RUN   TestAccAWSFsxOntapFileSystem_diskIopsConfiguration
=== PAUSE TestAccAWSFsxOntapFileSystem_diskIopsConfiguration
=== RUN   TestAccAWSFsxOntapFileSystem_disappears
=== PAUSE TestAccAWSFsxOntapFileSystem_disappears
=== RUN   TestAccAWSFsxOntapFileSystem_SecurityGroupIds
=== PAUSE TestAccAWSFsxOntapFileSystem_SecurityGroupIds
=== RUN   TestAccAWSFsxOntapFileSystem_routeTableIds
=== PAUSE TestAccAWSFsxOntapFileSystem_routeTableIds
=== RUN   TestAccAWSFsxOntapFileSystem_tags
=== PAUSE TestAccAWSFsxOntapFileSystem_tags
=== RUN   TestAccAWSFsxOntapFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccAWSFsxOntapFileSystem_weeklyMaintenanceStartTime
=== RUN   TestAccAWSFsxOntapFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccAWSFsxOntapFileSystem_automaticBackupRetentionDays
=== RUN   TestAccAWSFsxOntapFileSystem_kmsKeyId
=== PAUSE TestAccAWSFsxOntapFileSystem_kmsKeyId
=== RUN   TestAccAWSFsxOntapFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccAWSFsxOntapFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccAWSFsxOntapFileSystem_basic
=== CONT  TestAccAWSFsxOntapFileSystem_endpointIpAddressRange
=== CONT  TestAccAWSFsxOntapFileSystem_tags
=== CONT  TestAccAWSFsxOntapFileSystem_routeTableIds
=== CONT  TestAccAWSFsxOntapFileSystem_disappears
=== CONT  TestAccAWSFsxOntapFileSystem_kmsKeyId
=== CONT  TestAccAWSFsxOntapFileSystem_automaticBackupRetentionDays
=== CONT  TestAccAWSFsxOntapFileSystem_weeklyMaintenanceStartTime
=== CONT  TestAccAWSFsxOntapFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccAWSFsxOntapFileSystem_diskIopsConfiguration
=== CONT  TestAccAWSFsxOntapFileSystem_fsxAdminPassword
=== CONT  TestAccAWSFsxOntapFileSystem_SecurityGroupIds
--- PASS: TestAccAWSFsxOntapFileSystem_diskIopsConfiguration (1463.65s)
--- PASS: TestAccAWSFsxOntapFileSystem_dailyAutomaticBackupStartTime (1477.54s)
--- PASS: TestAccAWSFsxOntapFileSystem_tags (1492.05s)
--- PASS: TestAccAWSFsxOntapFileSystem_endpointIpAddressRange (1512.22s)
--- PASS: TestAccAWSFsxOntapFileSystem_fsxAdminPassword (1518.56s)
--- PASS: TestAccAWSFsxOntapFileSystem_routeTableIds (1526.57s)
--- PASS: TestAccAWSFsxOntapFileSystem_kmsKeyId (1526.91s)
--- PASS: TestAccAWSFsxOntapFileSystem_automaticBackupRetentionDays (1580.47s)
--- PASS: TestAccAWSFsxOntapFileSystem_weeklyMaintenanceStartTime (1592.42s)
--- PASS: TestAccAWSFsxOntapFileSystem_disappears (2327.82s)
--- PASS: TestAccAWSFsxOntapFileSystem_basic (2331.28s)
--- PASS: TestAccAWSFsxOntapFileSystem_SecurityGroupIds (3898.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3902.810s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSFsxOntapFileSystem_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxOntapFileSystem_ -timeout 180m
=== RUN   TestAccAWSFsxOntapFileSystem_basic
=== PAUSE TestAccAWSFsxOntapFileSystem_basic
=== RUN   TestAccAWSFsxOntapFileSystem_fsxAdminPassword
=== PAUSE TestAccAWSFsxOntapFileSystem_fsxAdminPassword
=== RUN   TestAccAWSFsxOntapFileSystem_endpointIpAddressRange
=== PAUSE TestAccAWSFsxOntapFileSystem_endpointIpAddressRange
=== RUN   TestAccAWSFsxOntapFileSystem_diskIopsConfiguration
=== PAUSE TestAccAWSFsxOntapFileSystem_diskIopsConfiguration
=== RUN   TestAccAWSFsxOntapFileSystem_disappears
=== PAUSE TestAccAWSFsxOntapFileSystem_disappears
=== RUN   TestAccAWSFsxOntapFileSystem_SecurityGroupIds
=== PAUSE TestAccAWSFsxOntapFileSystem_SecurityGroupIds
=== RUN   TestAccAWSFsxOntapFileSystem_routeTableIds
=== PAUSE TestAccAWSFsxOntapFileSystem_routeTableIds
=== RUN   TestAccAWSFsxOntapFileSystem_tags
=== PAUSE TestAccAWSFsxOntapFileSystem_tags
=== RUN   TestAccAWSFsxOntapFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccAWSFsxOntapFileSystem_weeklyMaintenanceStartTime
=== RUN   TestAccAWSFsxOntapFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccAWSFsxOntapFileSystem_automaticBackupRetentionDays
=== RUN   TestAccAWSFsxOntapFileSystem_kmsKeyId
=== PAUSE TestAccAWSFsxOntapFileSystem_kmsKeyId
=== RUN   TestAccAWSFsxOntapFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccAWSFsxOntapFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccAWSFsxOntapFileSystem_basic
=== CONT  TestAccAWSFsxOntapFileSystem_disappears
=== CONT  TestAccAWSFsxOntapFileSystem_routeTableIds
=== CONT  TestAccAWSFsxOntapFileSystem_SecurityGroupIds
=== CONT  TestAccAWSFsxOntapFileSystem_tags
=== CONT  TestAccAWSFsxOntapFileSystem_fsxAdminPassword
=== CONT  TestAccAWSFsxOntapFileSystem_weeklyMaintenanceStartTime
=== CONT  TestAccAWSFsxOntapFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccAWSFsxOntapFileSystem_endpointIpAddressRange
=== CONT  TestAccAWSFsxOntapFileSystem_kmsKeyId
=== CONT  TestAccAWSFsxOntapFileSystem_diskIopsConfiguration
=== CONT  TestAccAWSFsxOntapFileSystem_automaticBackupRetentionDays
--- PASS: TestAccAWSFsxOntapFileSystem_disappears (1018.33s)
--- PASS: TestAccAWSFsxOntapFileSystem_endpointIpAddressRange (1439.57s)
--- PASS: TestAccAWSFsxOntapFileSystem_basic (1469.12s)
--- PASS: TestAccAWSFsxOntapFileSystem_diskIopsConfiguration (1479.06s)
--- PASS: TestAccAWSFsxOntapFileSystem_routeTableIds (1489.68s)
--- PASS: TestAccAWSFsxOntapFileSystem_tags (1505.67s)
--- PASS: TestAccAWSFsxOntapFileSystem_fsxAdminPassword (1506.32s)
--- PASS: TestAccAWSFsxOntapFileSystem_dailyAutomaticBackupStartTime (1526.47s)
--- PASS: TestAccAWSFsxOntapFileSystem_weeklyMaintenanceStartTime (1527.15s)
--- PASS: TestAccAWSFsxOntapFileSystem_kmsKeyId (1577.94s)
--- PASS: TestAccAWSFsxOntapFileSystem_automaticBackupRetentionDays (1621.61s)        
--- PASS: TestAccAWSFsxOntapFileSystem_SecurityGroupIds (3468.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3472.822s

ewbankkit · 2021-09-22T17:17:28Z

@DrFaust92 Thanks for the contribution 🎉 👏.
I changed storage_capacity to ForceNew: true as StorageCapacity cannot be updated for ONTAP file systems: https://docs.aws.amazon.com/fsx/latest/APIReference/API_UpdateFileSystem.html.

github-actions · 2021-09-23T22:53:38Z

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-06-19T02:41:20Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

DrFaust92 added 4 commits September 18, 2021 15:15

fsx ontap fs

fd9ecdf

fsx ontap - add route tables and endpoint ip args

84a0c4c

fsx ontap fs - add endpoint attribute

86b031f

fsx ontap fs - disk config

99cf734

DrFaust92 force-pushed the fsx_ontap_fs branch from 32a2a1c to 99cf734 Compare September 18, 2021 12:16

DrFaust92 added the new-resource Introduces a new resource. label Sep 18, 2021

DrFaust92 changed the title ~~Fsx ontap fs~~ r/fsx_ontap_filesystem - new resource Sep 18, 2021

DrFaust92 added 5 commits September 18, 2021 16:25

fmt

85650e8

fsx ontap fs - admin pass arg

afb30ee

docs

6f356c7

remove backup

5397464

changelog

ca3b241

github-actions bot added the documentation Introduces or discusses updates to documentation. label Sep 18, 2021

DrFaust92 added 2 commits September 18, 2021 17:14

fix test

deca775

docs

d6bb80a

DrFaust92 mentioned this pull request Sep 18, 2021

Feature Request: Amazon FSx for NetApp ONTAP #20778

Closed

DrFaust92 added 10 commits September 18, 2021 17:54

test fixes

25a489d

route tables can be computed

79a5f8d

fmt

a67b25a

fix test

414393e

fix tests

b886074

ignore import of pass

d7d4a51

update admin pass

119d006

tests

70960c0

make kms test shorter

0e19a24

fmt

f11143c

sweeper dep

d5ed379

github-actions bot added the service/ec2 Issues and PRs that pertain to the ec2 service. label Sep 18, 2021

DrFaust92 marked this pull request as ready for review September 18, 2021 22:02

DrFaust92 removed the service/ec2 Issues and PRs that pertain to the ec2 service. label Sep 18, 2021

ewbankkit added 2 commits September 22, 2021 09:40

Separate FSx file system create and update waiters.

8b5b20a

r/aws_fsx_ontap_file_system: 'Ontap' -> 'ONTAP' in error messages.

9b4bb50

github-actions bot added the service/ec2 Issues and PRs that pertain to the ec2 service. label Sep 22, 2021

ewbankkit approved these changes Sep 22, 2021

View reviewed changes

ewbankkit removed the service/ec2 Issues and PRs that pertain to the ec2 service. label Sep 22, 2021

ewbankkit merged commit 9efd68d into hashicorp:main Sep 22, 2021

github-actions bot added this to the v3.60.0 milestone Sep 22, 2021

DrFaust92 deleted the fsx_ontap_fs branch September 22, 2021 19:00

ewbankkit mentioned this pull request Oct 26, 2021

fix route table for Amazon FSx for NetApp ONTAP routes and tag #21265

Merged

github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/fsx_ontap_filesystem - new resource #20951

r/fsx_ontap_filesystem - new resource #20951

DrFaust92 commented Sep 18, 2021 •

edited

Loading

ewbankkit left a comment

ewbankkit commented Sep 22, 2021 •

edited

Loading

github-actions bot commented Sep 23, 2021

github-actions bot commented Jun 19, 2022

r/fsx_ontap_filesystem - new resource #20951

r/fsx_ontap_filesystem - new resource #20951

Conversation

DrFaust92 commented Sep 18, 2021 • edited Loading

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Sep 22, 2021 • edited Loading

github-actions bot commented Sep 23, 2021

github-actions bot commented Jun 19, 2022

DrFaust92 commented Sep 18, 2021 •

edited

Loading

ewbankkit commented Sep 22, 2021 •

edited

Loading