Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_glue_data_catalog_encryption_settings: Reset at delete #21452

Merged
merged 4 commits into from
Oct 22, 2021

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21261.

Output from acceptance testing:

% make testacc PKG_NAME=internal/service/glue TESTARGS='-run=TestAccGlue_serial/DataCatalogEncryptionSettings'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run=TestAccGlue_serial/DataCatalogEncryptionSettings -timeout 180m
=== RUN   TestAccGlue_serial
=== RUN   TestAccGlue_serial/DataCatalogEncryptionSettings
=== RUN   TestAccGlue_serial/DataCatalogEncryptionSettings/basic
=== RUN   TestAccGlue_serial/DataCatalogEncryptionSettings/DataSource
--- PASS: TestAccGlue_serial (58.17s)
    --- PASS: TestAccGlue_serial/DataCatalogEncryptionSettings (58.17s)
        --- PASS: TestAccGlue_serial/DataCatalogEncryptionSettings/basic (45.58s)
        --- PASS: TestAccGlue_serial/DataCatalogEncryptionSettings/DataSource (12.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	60.968s

@github-actions github-actions bot added service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Oct 22, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ above about adding a CheckDestroy though not sure if it's really necessary since we're resetting not deleting...otherwise, LGTM 👍

Output of acceptance tests:

--- PASS: TestAccGlue_serial (97.08s)
    --- PASS: TestAccGlue_serial/DataCatalogEncryptionSettings (97.08s)
        --- PASS: TestAccGlue_serial/DataCatalogEncryptionSettings/basic (84.61s)
        --- PASS: TestAccGlue_serial/DataCatalogEncryptionSettings/DataSource (12.47s)

@ewbankkit ewbankkit merged commit 6a52589 into main Oct 22, 2021
@ewbankkit ewbankkit deleted the b-aws_glue_data_catalog_encryption_settings-delete branch October 22, 2021 18:37
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 22, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/glue Issues and PRs that pertain to the glue service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting aws_glue_data_catalog_encryption_settings resource does not disable catalog encryption
2 participants