Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Glue Data Catalog Encryption Settings acceptance tests #22403

Merged
merged 5 commits into from
Jan 5, 2022

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

In HashiCorp CI testing we are seeing lots of errors like

=== RUN   TestAccAthenaDatabase_basic
=== PAUSE TestAccAthenaDatabase_basic
=== CONT  TestAccAthenaDatabase_basic
database_test.go:22: Step 1/1 error: Error running apply: exit status 1
Error: reason: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask. MetaException(message:The ciphertext refers to a customer master key that does not exist, does not exist in this region, or you are not allowed to access. (Service: AWSKMS; Status Code: 400; Error Code: AccessDeniedException; Request ID: c9efb163-27f2-4c80-bc45-505513cd3d59; Proxy: null) (Service: AmazonDataCatalog; Status Code: 400; Error Code: GlueEncryptionException; Request ID: c225a893-7632-49f6-9e0c-79d17b15d667; Proxy: null))
with aws_athena_database.hoge,
on terraform_plugin_test.tf line 7, in resource "aws_athena_database" "hoge":
7: resource "aws_athena_database" "hoge" {
--- FAIL: TestAccAthenaDatabase_basic (84.41s)

This could be because at one time the Glue Data Catalog Encryption Settings referred to a KMS key that has now been deleted.
I have opened an AWS Support ticket to try and get this sorted out.
In anticipation of this getting resolved, skip any acceptance tests that affect the Glue Data Catalog Encryption Settings.
The tests can be manually adapted if they need to be run.

% make testacc TESTARGS='-run=TestAccGlue_serial/DataCatalogEncryptionSettings' PKG_NAME=internal/service/glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run=TestAccGlue_serial/DataCatalogEncryptionSettings -timeout 180m
=== RUN   TestAccGlue_serial
=== RUN   TestAccGlue_serial/DataCatalogEncryptionSettings
=== RUN   TestAccGlue_serial/DataCatalogEncryptionSettings/basic
    data_catalog_encryption_settings_test.go:17: Skipping aws_glue_data_catalog_encryption_settings tests
=== RUN   TestAccGlue_serial/DataCatalogEncryptionSettings/dataSource
    data_catalog_encryption_settings_data_source_test.go:12: Skipping aws_glue_data_catalog_encryption_settings tests
--- PASS: TestAccGlue_serial (0.00s)
    --- PASS: TestAccGlue_serial/DataCatalogEncryptionSettings (0.00s)
        --- SKIP: TestAccGlue_serial/DataCatalogEncryptionSettings/basic (0.00s)
        --- SKIP: TestAccGlue_serial/DataCatalogEncryptionSettings/dataSource (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	3.651s

Relates #21452.
Relates #22338.

…an leave the account in a state where a referenced KMS key is deleted.

% make testacc TESTARGS='-run=TestAccGlue_serial/DataCatalogEncryptionSettings' PKG_NAME=internal/service/glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run=TestAccGlue_serial/DataCatalogEncryptionSettings -timeout 180m
=== RUN   TestAccGlue_serial
=== RUN   TestAccGlue_serial/DataCatalogEncryptionSettings
=== RUN   TestAccGlue_serial/DataCatalogEncryptionSettings/basic
    data_catalog_encryption_settings_test.go:17: Skipping aws_glue_data_catalog_encryption_settings tests
=== RUN   TestAccGlue_serial/DataCatalogEncryptionSettings/dataSource
    data_catalog_encryption_settings_data_source_test.go:12: Skipping aws_glue_data_catalog_encryption_settings tests
--- PASS: TestAccGlue_serial (0.00s)
    --- PASS: TestAccGlue_serial/DataCatalogEncryptionSettings (0.00s)
        --- SKIP: TestAccGlue_serial/DataCatalogEncryptionSettings/basic (0.00s)
        --- SKIP: TestAccGlue_serial/DataCatalogEncryptionSettings/dataSource (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	3.651s
@github-actions github-actions bot added service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. labels Jan 4, 2022
@ewbankkit ewbankkit added service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 4, 2022
@zhelding
Copy link
Contributor

zhelding commented Jan 5, 2022

LGTM! 🚀

…e-resource-delete' into t-GlueEncryptionException
@github-actions github-actions bot added service/cloudfront Issues and PRs that pertain to the cloudfront service. service/iam Issues and PRs that pertain to the iam service. sweeper Pertains to changes to or issues with the sweeper. size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 5, 2022
@ewbankkit ewbankkit merged commit 8dd4fe3 into main Jan 5, 2022
@ewbankkit ewbankkit deleted the t-GlueEncryptionException branch January 5, 2022 17:12
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 5, 2022
github-actions bot pushed a commit that referenced this pull request Jan 5, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cloudfront Issues and PRs that pertain to the cloudfront service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants