Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_route53_resolver_dnssec_config - increase config create/delete timeouts to 10 minutes #21797

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

tokiwong
Copy link
Contributor

@tokiwong tokiwong commented Nov 16, 2021

DNSSEC config validation status takes longer than 5 minutes on initial creation

examples:
ENABLING exceeding 5 minutes

aws_route53_resolver_dnssec_config.main: Still creating... [4m40s elapsed]
aws_route53_resolver_dnssec_config.main: Still creating... [4m50s elapsed]
aws_route53_resolver_dnssec_config.main: Still creating... [5m0s elapsed]
╷
│ Error: timeout while waiting for state to become 'ENABLED' (last state: 'ENABLING', timeout: 5m0s)
│ 
│   with aws_route53_resolver_dnssec_config.main,
│   on network.tf line 16, in resource "aws_route53_resolver_dnssec_config" "main":
│   16: resource "aws_route53_resolver_dnssec_config" "main" {
│ 

DISABLING exceeding 5 minutes (due to the taint applied to the resource since creation exceeded initial timeout)

aws_route53_resolver_dnssec_config.main: Still destroying... [id=rdsc-5463558bd171395b, 4m40s elapsed]
aws_route53_resolver_dnssec_config.main: Still destroying... [id=rdsc-5463558bd171395b, 4m50s elapsed]
aws_route53_resolver_dnssec_config.main: Still destroying... [id=rdsc-5463558bd171395b, 5m0s elapsed]
╷
│ Error: error waiting for Route 53 Resolver DNSSEC config (rdsc-5463558bd171395b) to be disabled: timeout while waiting for state to become 'DISABLED' (last state: 'DISABLING', timeout: 5m0s)
│ 

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20732

@github-actions github-actions bot added service/route53resolver Issues and PRs that pertain to the route53resolver service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Nov 16, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @tokiwong 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 16, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53ResolverDNSSECConfig_' PKG_NAME=internal/service/route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run=TestAccRoute53ResolverDNSSECConfig_ -timeout 180m
=== RUN   TestAccRoute53ResolverDNSSECConfig_basic
=== PAUSE TestAccRoute53ResolverDNSSECConfig_basic
=== RUN   TestAccRoute53ResolverDNSSECConfig_disappear
=== PAUSE TestAccRoute53ResolverDNSSECConfig_disappear
=== CONT  TestAccRoute53ResolverDNSSECConfig_basic
=== CONT  TestAccRoute53ResolverDNSSECConfig_disappear
--- PASS: TestAccRoute53ResolverDNSSECConfig_disappear (472.22s)
--- PASS: TestAccRoute53ResolverDNSSECConfig_basic (485.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	488.860s

@ewbankkit
Copy link
Contributor

@tokiwong Thanks for the contribution 🎉 👏.

@github-actions
Copy link

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/route53resolver Issues and PRs that pertain to the route53resolver service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants