Tech-Debt: Migrate all acceptance tests to use the independent s3 resources

[anGie44]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Now that arguments in the s3_bucket resource have been deprecated, tests across services should be updated to use the corresponding independent resources as errors will arise e.g.

Error: Value for unconfigurable attribute
        
          with aws_s3_bucket.hoge,
          on terraform_plugin_test.tf line 6, in resource "aws_s3_bucket" "hoge":
           6: resource "aws_s3_bucket" "hoge" {
        
        Can't configure a value for "server_side_encryption_configuration": its value
        will be decided automatically based on the result of applying this
        configuration.

Affected Tests

The following require migrating to aws_s3_bucket_policy:

• TestAccCloudFormationStack_WithURLWithParams_withYAML
• TestAccCloudFormationStack_WithURL_withParams
• TestAccCloudFormationStack_WithURLWithParams_noUpdate
• TestAccCloudTrail_serial/Trail
• TestAccRedshiftCluster_loggingEnabled

The following require migrating to aws_s3_bucket_acl:

• Uses acl (tests/wafv2: update to aws_s3_bucket_acl resource #23004)
  • acctest
  • apigateway
  • cloudformation
  • cloudfront
  • cloudwatch
  • cloudwatchlogs
  • codepipeline
  • configservice
  • costandusagereportservice
  • elasticloadbalancing
  • elastictranscoder
  • emr
  • firehose
  • fsx
  • globalaccelerator
  • guardduty
  • kafka
  • lakeformation
  • lambda
  • mwaa
  • networkfirewall
  • quicksight
  • route53
  • s3
  • sagemaker
  • servicecatalog
  • ses
  • sns
  • ssm
  • synthetics
  • transfer
  • waf
  • wafregional
  • wafv2 (WebACLLoggingConfiguration)
• Uses grant
  • TestAccEC2SpotDatafeedSubscription_serial

References

• [Discuss/Feature] Additional S3 Bucket Resources #4418
• Upcoming Changes in Version 4.0 of the AWS Provider #20433
• r/s3_bucket: read-only acl and grant arguments #22537
• r/s3_bucket: read-only policy argument #22538

[github-actions]

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.