-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/servicecatalog: update to aws_s3_bucket_acl
resource
#23016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccServiceCatalogConstraint\|TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic\|TestAccServiceCatalogProductDataSource_\|TestAccServiceCatalogProductPortfolioAssociation_\|TestAccServiceCatalogProduct_\|TestAccServiceCatalogProvisionedProduct_\|TestAccServiceCatalogProvisioningArtifact_' PKG=servicecatalog
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run=TestAccServiceCatalogConstraint\|TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic\|TestAccServiceCatalogProductDataSource_\|TestAccServiceCatalogProductPortfolioAssociation_\|TestAccServiceCatalogProduct_\|TestAccServiceCatalogProvisionedProduct_\|TestAccServiceCatalogProvisioningArtifact_ -timeout 180m
=== RUN TestAccServiceCatalogConstraintDataSource_basic
=== PAUSE TestAccServiceCatalogConstraintDataSource_basic
=== RUN TestAccServiceCatalogConstraint_basic
=== PAUSE TestAccServiceCatalogConstraint_basic
=== RUN TestAccServiceCatalogConstraint_disappears
=== PAUSE TestAccServiceCatalogConstraint_disappears
=== RUN TestAccServiceCatalogConstraint_update
=== PAUSE TestAccServiceCatalogConstraint_update
=== RUN TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic
=== PAUSE TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic
=== RUN TestAccServiceCatalogProductDataSource_basic
=== PAUSE TestAccServiceCatalogProductDataSource_basic
=== RUN TestAccServiceCatalogProductDataSource_physicalID
=== PAUSE TestAccServiceCatalogProductDataSource_physicalID
=== RUN TestAccServiceCatalogProductPortfolioAssociation_basic
=== PAUSE TestAccServiceCatalogProductPortfolioAssociation_basic
=== RUN TestAccServiceCatalogProductPortfolioAssociation_disappears
=== PAUSE TestAccServiceCatalogProductPortfolioAssociation_disappears
=== RUN TestAccServiceCatalogProduct_basic
=== PAUSE TestAccServiceCatalogProduct_basic
=== RUN TestAccServiceCatalogProduct_disappears
=== PAUSE TestAccServiceCatalogProduct_disappears
=== RUN TestAccServiceCatalogProduct_update
=== PAUSE TestAccServiceCatalogProduct_update
=== RUN TestAccServiceCatalogProduct_updateTags
=== PAUSE TestAccServiceCatalogProduct_updateTags
=== RUN TestAccServiceCatalogProduct_physicalID
=== PAUSE TestAccServiceCatalogProduct_physicalID
=== RUN TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== RUN TestAccServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccServiceCatalogProvisionedProduct_disappears
=== RUN TestAccServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags
=== RUN TestAccServiceCatalogProvisioningArtifact_basic
=== PAUSE TestAccServiceCatalogProvisioningArtifact_basic
=== RUN TestAccServiceCatalogProvisioningArtifact_disappears
=== PAUSE TestAccServiceCatalogProvisioningArtifact_disappears
=== RUN TestAccServiceCatalogProvisioningArtifact_update
=== PAUSE TestAccServiceCatalogProvisioningArtifact_update
=== RUN TestAccServiceCatalogProvisioningArtifact_physicalID
=== PAUSE TestAccServiceCatalogProvisioningArtifact_physicalID
=== CONT TestAccServiceCatalogConstraintDataSource_basic
=== CONT TestAccServiceCatalogProduct_update
=== CONT TestAccServiceCatalogProduct_basic
=== CONT TestAccServiceCatalogProvisionedProduct_basic
=== CONT TestAccServiceCatalogConstraint_basic
=== CONT TestAccServiceCatalogProductDataSource_physicalID
=== CONT TestAccServiceCatalogProvisionedProduct_tags
=== CONT TestAccServiceCatalogProvisioningArtifact_physicalID
=== CONT TestAccServiceCatalogProvisioningArtifact_update
=== CONT TestAccServiceCatalogProvisioningArtifact_disappears
=== CONT TestAccServiceCatalogProvisioningArtifact_basic
=== CONT TestAccServiceCatalogProductPortfolioAssociation_disappears
=== CONT TestAccServiceCatalogProduct_physicalID
=== CONT TestAccServiceCatalogProduct_updateTags
=== CONT TestAccServiceCatalogProductPortfolioAssociation_basic
=== CONT TestAccServiceCatalogProduct_disappears
=== CONT TestAccServiceCatalogConstraint_update
=== CONT TestAccServiceCatalogProvisionedProduct_disappears
=== CONT TestAccServiceCatalogProductDataSource_basic
=== CONT TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic
--- PASS: TestAccServiceCatalogProduct_disappears (57.32s)
=== CONT TestAccServiceCatalogConstraint_disappears
--- PASS: TestAccServiceCatalogProduct_basic (64.58s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_disappears (66.80s)
--- PASS: TestAccServiceCatalogProductDataSource_basic (73.57s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_basic (78.80s)
--- PASS: TestAccServiceCatalogConstraint_basic (79.79s)
--- PASS: TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic (81.88s)
--- PASS: TestAccServiceCatalogConstraintDataSource_basic (88.15s)
--- PASS: TestAccServiceCatalogProduct_update (97.12s)
--- PASS: TestAccServiceCatalogProduct_updateTags (99.44s)
--- PASS: TestAccServiceCatalogProduct_physicalID (102.11s)
--- PASS: TestAccServiceCatalogProductPortfolioAssociation_disappears (103.69s)
--- PASS: TestAccServiceCatalogProductDataSource_physicalID (109.99s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_physicalID (114.15s)
--- PASS: TestAccServiceCatalogProductPortfolioAssociation_basic (114.75s)
--- PASS: TestAccServiceCatalogConstraint_disappears (58.24s)
--- PASS: TestAccServiceCatalogConstraint_update (120.86s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_update (123.64s)
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (178.56s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (195.06s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (360.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog 363.792s
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #22997
Relates #22537
Relates #20433
Output from acceptance testing: