Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/servicecatalog: update to aws_s3_bucket_acl resource #23016

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 8, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22997
Relates #22537
Relates #20433

Output from acceptance testing:

--- PASS: TestAccServiceCatalogConstraintDataSource_basic (91.09s)
--- PASS: TestAccServiceCatalogConstraint_basic (94.72s)
--- PASS: TestAccServiceCatalogConstraint_disappears (73.18s)
--- PASS: TestAccServiceCatalogConstraint_update (117.48s)

--- PASS: TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic (84.66s)

--- PASS: TestAccServiceCatalogProductDataSource_basic (86.39s)
--- PASS: TestAccServiceCatalogProductDataSource_physicalID (124.10s)

--- PASS: TestAccServiceCatalogProductPortfolioAssociation_basic (130.33s)
--- PASS: TestAccServiceCatalogProductPortfolioAssociation_disappears (119.22s)

--- PASS: TestAccServiceCatalogProduct_basic (71.08s)
--- PASS: TestAccServiceCatalogProduct_disappears (56.87s)
--- PASS: TestAccServiceCatalogProduct_physicalID (123.44s)
--- PASS: TestAccServiceCatalogProduct_update (107.10s)
--- PASS: TestAccServiceCatalogProduct_updateTags (107.67s)

--- PASS: TestAccServiceCatalogProvisionedProduct_basic (171.55s)
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (152.03s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (257.59s)

--- PASS: TestAccServiceCatalogProvisioningArtifact_basic (93.09s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_disappears (83.26s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_physicalID (93.58s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_update (120.05s)

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 8, 2022
@anGie44 anGie44 marked this pull request as ready for review February 8, 2022 15:58
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccServiceCatalogConstraint\|TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic\|TestAccServiceCatalogProductDataSource_\|TestAccServiceCatalogProductPortfolioAssociation_\|TestAccServiceCatalogProduct_\|TestAccServiceCatalogProvisionedProduct_\|TestAccServiceCatalogProvisioningArtifact_' PKG=servicecatalog
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20  -run=TestAccServiceCatalogConstraint\|TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic\|TestAccServiceCatalogProductDataSource_\|TestAccServiceCatalogProductPortfolioAssociation_\|TestAccServiceCatalogProduct_\|TestAccServiceCatalogProvisionedProduct_\|TestAccServiceCatalogProvisioningArtifact_ -timeout 180m
=== RUN   TestAccServiceCatalogConstraintDataSource_basic
=== PAUSE TestAccServiceCatalogConstraintDataSource_basic
=== RUN   TestAccServiceCatalogConstraint_basic
=== PAUSE TestAccServiceCatalogConstraint_basic
=== RUN   TestAccServiceCatalogConstraint_disappears
=== PAUSE TestAccServiceCatalogConstraint_disappears
=== RUN   TestAccServiceCatalogConstraint_update
=== PAUSE TestAccServiceCatalogConstraint_update
=== RUN   TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic
=== PAUSE TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic
=== RUN   TestAccServiceCatalogProductDataSource_basic
=== PAUSE TestAccServiceCatalogProductDataSource_basic
=== RUN   TestAccServiceCatalogProductDataSource_physicalID
=== PAUSE TestAccServiceCatalogProductDataSource_physicalID
=== RUN   TestAccServiceCatalogProductPortfolioAssociation_basic
=== PAUSE TestAccServiceCatalogProductPortfolioAssociation_basic
=== RUN   TestAccServiceCatalogProductPortfolioAssociation_disappears
=== PAUSE TestAccServiceCatalogProductPortfolioAssociation_disappears
=== RUN   TestAccServiceCatalogProduct_basic
=== PAUSE TestAccServiceCatalogProduct_basic
=== RUN   TestAccServiceCatalogProduct_disappears
=== PAUSE TestAccServiceCatalogProduct_disappears
=== RUN   TestAccServiceCatalogProduct_update
=== PAUSE TestAccServiceCatalogProduct_update
=== RUN   TestAccServiceCatalogProduct_updateTags
=== PAUSE TestAccServiceCatalogProduct_updateTags
=== RUN   TestAccServiceCatalogProduct_physicalID
=== PAUSE TestAccServiceCatalogProduct_physicalID
=== RUN   TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== RUN   TestAccServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags
=== RUN   TestAccServiceCatalogProvisioningArtifact_basic
=== PAUSE TestAccServiceCatalogProvisioningArtifact_basic
=== RUN   TestAccServiceCatalogProvisioningArtifact_disappears
=== PAUSE TestAccServiceCatalogProvisioningArtifact_disappears
=== RUN   TestAccServiceCatalogProvisioningArtifact_update
=== PAUSE TestAccServiceCatalogProvisioningArtifact_update
=== RUN   TestAccServiceCatalogProvisioningArtifact_physicalID
=== PAUSE TestAccServiceCatalogProvisioningArtifact_physicalID
=== CONT  TestAccServiceCatalogConstraintDataSource_basic
=== CONT  TestAccServiceCatalogProduct_update
=== CONT  TestAccServiceCatalogProduct_basic
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
=== CONT  TestAccServiceCatalogConstraint_basic
=== CONT  TestAccServiceCatalogProductDataSource_physicalID
=== CONT  TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisioningArtifact_physicalID
=== CONT  TestAccServiceCatalogProvisioningArtifact_update
=== CONT  TestAccServiceCatalogProvisioningArtifact_disappears
=== CONT  TestAccServiceCatalogProvisioningArtifact_basic
=== CONT  TestAccServiceCatalogProductPortfolioAssociation_disappears
=== CONT  TestAccServiceCatalogProduct_physicalID
=== CONT  TestAccServiceCatalogProduct_updateTags
=== CONT  TestAccServiceCatalogProductPortfolioAssociation_basic
=== CONT  TestAccServiceCatalogProduct_disappears
=== CONT  TestAccServiceCatalogConstraint_update
=== CONT  TestAccServiceCatalogProvisionedProduct_disappears
=== CONT  TestAccServiceCatalogProductDataSource_basic
=== CONT  TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic
--- PASS: TestAccServiceCatalogProduct_disappears (57.32s)
=== CONT  TestAccServiceCatalogConstraint_disappears
--- PASS: TestAccServiceCatalogProduct_basic (64.58s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_disappears (66.80s)
--- PASS: TestAccServiceCatalogProductDataSource_basic (73.57s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_basic (78.80s)
--- PASS: TestAccServiceCatalogConstraint_basic (79.79s)
--- PASS: TestAccServiceCatalogPortfolioConstraintsDataSource_Constraint_basic (81.88s)
--- PASS: TestAccServiceCatalogConstraintDataSource_basic (88.15s)
--- PASS: TestAccServiceCatalogProduct_update (97.12s)
--- PASS: TestAccServiceCatalogProduct_updateTags (99.44s)
--- PASS: TestAccServiceCatalogProduct_physicalID (102.11s)
--- PASS: TestAccServiceCatalogProductPortfolioAssociation_disappears (103.69s)
--- PASS: TestAccServiceCatalogProductDataSource_physicalID (109.99s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_physicalID (114.15s)
--- PASS: TestAccServiceCatalogProductPortfolioAssociation_basic (114.75s)
--- PASS: TestAccServiceCatalogConstraint_disappears (58.24s)
--- PASS: TestAccServiceCatalogConstraint_update (120.86s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_update (123.64s)
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (178.56s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (195.06s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (360.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	363.792s

@anGie44 anGie44 added this to the v4.0.0 milestone Feb 8, 2022
@anGie44 anGie44 merged commit 2d51edd into main Feb 8, 2022
@anGie44 anGie44 deleted the td-servicecatalog-s3-bucket-acl-tests branch February 8, 2022 18:51
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants