-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StackSet with auto_deployment gets administration_role_arn during refresh, resulting in update loop #23464
Comments
Hey @fvant 👋 Thank you for taking the time to raise this! So that we have all of the necessary information in order to look into this, can you supply an example Terraform configuration as well? I'm not positive as to whether the engineer who looks at this will need debug logs or not for this one, but that may be something that we end up requesting as well. |
Hi @justinretzolk , this is an issue I am also having with Terraform deployments at the moment. I would like to point out that I think this is part of a much wider problem with Terraform's AWS Provider implementation of AWS CloudFormation Stacksets. In my instance, when Terraform attempts to deploy a second time because of this issue, it causes a much wider failure because other parameters cannot be configured such as FailureTolerance and MaxConcurrent (which stops timeout issues when deploying) detailed here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/stacksets-concepts.html#stackset-ops-options. The wider issues related are linked here and the only solution I have had is to avoid using SERVICE_MANAGED roles and make use of provisioners :( so I configure the required StackSet options. I have noticed that you have commented on these so it would be great to get a much wider update to the issues present! Terraform version: 1.1.5 |
@fvant @justinretzolk |
Hey @ReadyElbow 👋 Thank you for checking in on this. Unfortunately, I'm not able to provide an estimate on when this will be looked into due to the potential of shifting priorities. We prioritize work by count of ":+1:" reactions, as well as a few other things. A larger prioritization document is in the works, but in the meantime additional information may be found in our issue lifecycle document. |
Looks like we're running into this. Not sure if this would work - but potentially a workaround here is to add:
|
Subscribing because I'm running into the same issue, going to look into @rayterrill tip. Thanks! |
left a thumbs up. Running into exactly the same issue when trying to deploy a service_managed stackset |
Same problem here. Adding the lifecycle rule is a great work around. |
Can confirm my org runs into this same issue - adding a lifecycle rule works as a workaround for now. |
ignore - sysdig_secure_cloud_account.alias, since it's autopopulated on backend only, not on terraform state - aws_cloudformation_stack_set.stackset.administration_role_arn, since [it's not gracefully handled](hashicorp/terraform-provider-aws#23464)
the lifecycle rule works for now |
Current issue with the AWS provider causes an update loop: hashicorp/terraform-provider-aws#23464
Current issue with the AWS provider causes an update loop: hashicorp/terraform-provider-aws#23464
The administration_role_arn parameter is in constant drift. You cannot use auto_deployment and specify that parameter. There is an open issue for this here: hashicorp/terraform-provider-aws#23464 Currently the only fix is to ignore these changes via lifecycle rule
The administration_role_arn parameter is in constant drift. You cannot use auto_deployment and specify that parameter. There is an open issue for this here: hashicorp/terraform-provider-aws#23464 Currently the only fix is to ignore these changes via lifecycle rule
can also confirm running into this same issue - adding a lifecycle rule works as a workaround for now. |
Community Note
Terraform CLI and Terraform AWS Provider Version
Affected Resource(s)
Terraform Configuration Files
Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.
Debug Output
Panic Output
Expected Behavior
There were no changes to the stack itself, so not update needed
Actual Behavior
The stackset is updated successfully, only to planned for update on the next run again.
This is the plan, showing that the administrator_role_arn will be removed (as it is service managed, it should not be there)
The update is successful when i check in the AWS Console Organizations
Steps to Reproduce
Important Factoids
When i do add the administrator_role_arn to the configuration, just so it matches the state, i get this expected error
References
The text was updated successfully, but these errors were encountered: