-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/athena_database - add properties
+ import support
#24172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccAthenaDatabase_ PKG=athena ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/athena/... -v -count 1 -parallel 2 -run='TestAccAthenaDatabase_' -timeout 180m
=== RUN TestAccAthenaDatabase_basic
=== PAUSE TestAccAthenaDatabase_basic
=== RUN TestAccAthenaDatabase_properties
=== PAUSE TestAccAthenaDatabase_properties
=== RUN TestAccAthenaDatabase_acl
=== PAUSE TestAccAthenaDatabase_acl
=== RUN TestAccAthenaDatabase_encryption
=== PAUSE TestAccAthenaDatabase_encryption
=== RUN TestAccAthenaDatabase_nameStartsWithUnderscore
=== PAUSE TestAccAthenaDatabase_nameStartsWithUnderscore
=== RUN TestAccAthenaDatabase_nameCantHaveUppercase
=== PAUSE TestAccAthenaDatabase_nameCantHaveUppercase
=== RUN TestAccAthenaDatabase_destroyFailsIfTablesExist
=== PAUSE TestAccAthenaDatabase_destroyFailsIfTablesExist
=== RUN TestAccAthenaDatabase_forceDestroyAlwaysSucceeds
=== PAUSE TestAccAthenaDatabase_forceDestroyAlwaysSucceeds
=== RUN TestAccAthenaDatabase_description
=== PAUSE TestAccAthenaDatabase_description
=== RUN TestAccAthenaDatabase_unescaped_description
=== PAUSE TestAccAthenaDatabase_unescaped_description
=== RUN TestAccAthenaDatabase_disppears
=== PAUSE TestAccAthenaDatabase_disppears
=== CONT TestAccAthenaDatabase_properties
=== CONT TestAccAthenaDatabase_destroyFailsIfTablesExist
--- PASS: TestAccAthenaDatabase_properties (33.14s)
=== CONT TestAccAthenaDatabase_nameStartsWithUnderscore
--- PASS: TestAccAthenaDatabase_destroyFailsIfTablesExist (41.89s)
=== CONT TestAccAthenaDatabase_nameCantHaveUppercase
--- PASS: TestAccAthenaDatabase_nameCantHaveUppercase (1.27s)
=== CONT TestAccAthenaDatabase_unescaped_description
--- PASS: TestAccAthenaDatabase_nameStartsWithUnderscore (32.70s)
=== CONT TestAccAthenaDatabase_disppears
--- PASS: TestAccAthenaDatabase_unescaped_description (35.29s)
=== CONT TestAccAthenaDatabase_encryption
--- PASS: TestAccAthenaDatabase_disppears (27.54s)
=== CONT TestAccAthenaDatabase_acl
--- PASS: TestAccAthenaDatabase_encryption (33.01s)
=== CONT TestAccAthenaDatabase_description
--- PASS: TestAccAthenaDatabase_acl (30.61s)
=== CONT TestAccAthenaDatabase_forceDestroyAlwaysSucceeds
--- PASS: TestAccAthenaDatabase_description (32.37s)
=== CONT TestAccAthenaDatabase_basic
--- PASS: TestAccAthenaDatabase_forceDestroyAlwaysSucceeds (31.41s)
--- PASS: TestAccAthenaDatabase_basic (31.61s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/athena 180.670s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #24022
Output from acceptance testing: