Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement aws_account_primary_contact #26123

Merged
merged 21 commits into from
Apr 28, 2023
Merged

Implement aws_account_primary_contact #26123

merged 21 commits into from
Apr 28, 2023

Conversation

kurtmc
Copy link
Contributor

@kurtmc kurtmc commented Aug 4, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26077

Output from acceptance testing:

$ make testacc PKG=account TESTS="TestAccAccountPrimary_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20 -run='TestAccAccountPrimary_'  -timeout 180m
=== RUN   TestAccAccountPrimary_basic
--- PASS: TestAccAccountPrimary_basic (24.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/account    24.128s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/account Issues and PRs that pertain to the account service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Aug 4, 2022
@kurtmc kurtmc force-pushed the r/aws_account_primary_contact branch from efdb760 to 69664f1 Compare August 4, 2022 06:33
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 23, 2022
@kurtmc kurtmc force-pushed the r/aws_account_primary_contact branch 3 times, most recently from 6238b59 to 91ba54f Compare August 25, 2022 03:53
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Aug 25, 2022
@kurtmc kurtmc force-pushed the r/aws_account_primary_contact branch from 91ba54f to 8795a5d Compare August 25, 2022 04:14
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/L Managed by automation to categorize the size of a PR. labels Aug 25, 2022
@kurtmc kurtmc marked this pull request as ready for review August 25, 2022 04:20
@kurtmc kurtmc force-pushed the r/aws_account_primary_contact branch 2 times, most recently from 186e84b to 196e82c Compare August 25, 2022 04:30
@kyle-c-simmons
Copy link

Hi, is there any updates on this or anything we can do to help speed this up?

@kurtmc kurtmc force-pushed the r/aws_account_primary_contact branch from 196e82c to 7dc4423 Compare February 17, 2023 01:11
@kurtmc kurtmc force-pushed the r/aws_account_primary_contact branch from 7dc4423 to 8eb6912 Compare February 17, 2023 01:33
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Apr 27, 2023
@ewbankkit
r/aws_account_alternate_contact: Tidy up resource Delete.
d05d91b
@ewbankkit
Add 'tfresource.RetryIf' and 'tfresource.RetryWhenNotFoundN'.
32a0999
@ewbankkit
r/aws_account_alternate_contact: Simplify.
cb1e7a9
@ewbankkit
Acceptance test output:
638a8c9 
% make testacc TESTARGS='-run=TestAccAccount_serial/AlternateContact' PKG=account
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20  -run=TestAccAccount_serial/AlternateContact -timeout 180m
=== RUN   TestAccAccount_serial
=== PAUSE TestAccAccount_serial
=== CONT  TestAccAccount_serial
=== RUN   TestAccAccount_serial/AlternateContact
=== RUN   TestAccAccount_serial/AlternateContact/basic
=== RUN   TestAccAccount_serial/AlternateContact/disappears
=== RUN   TestAccAccount_serial/AlternateContact/AccountID
--- PASS: TestAccAccount_serial (79.60s)
    --- PASS: TestAccAccount_serial/AlternateContact (79.60s)
        --- PASS: TestAccAccount_serial/AlternateContact/basic (27.85s)
        --- PASS: TestAccAccount_serial/AlternateContact/disappears (12.20s)
        --- PASS: TestAccAccount_serial/AlternateContact/AccountID (39.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	85.073s
@ewbankkit
The start of musings on a replacement for the Terraform Plugin SDK v2…
950d023 
… `helper/retry` package.
@ewbankkit
r/aws_account_alternate_contact: Use new, PoC retry functionality.
05f34ff
@ewbankkit
r/aws_account_primary_contact: Tidy up.
4d8100c
@ewbankkit
Add CHANGELOG entry.
dfffa5b
@ewbankkit
Account: Use AWS SDK for Go v2.
cc1c8a2
@ewbankkit
Run 'go get github.com/aws/aws-sdk-go-v2/service/account@v1.10.5 && g…
34a1218 
…o mod tidy'.
@ewbankkit
Add 'AccountEndpointID'.
82fe32e
@ewbankkit
Account: Migrate to AWS SDK for Go v2.
f6ea84d
@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/kms Issues and PRs that pertain to the kms service. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Apr 28, 2023
ewbankkit
ewbankkit approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAccount_serial' PKG=account 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20  -run=TestAccAccount_serial -timeout 180m
=== RUN   TestAccAccount_serial
=== PAUSE TestAccAccount_serial
=== CONT  TestAccAccount_serial
=== RUN   TestAccAccount_serial/AlternateContact
=== RUN   TestAccAccount_serial/AlternateContact/basic
=== RUN   TestAccAccount_serial/AlternateContact/disappears
=== RUN   TestAccAccount_serial/AlternateContact/AccountID
=== RUN   TestAccAccount_serial/PrimaryContact
=== RUN   TestAccAccount_serial/PrimaryContact/basic
--- PASS: TestAccAccount_serial (105.69s)
    --- PASS: TestAccAccount_serial/AlternateContact (78.25s)
        --- PASS: TestAccAccount_serial/AlternateContact/basic (27.29s)
        --- PASS: TestAccAccount_serial/AlternateContact/disappears (11.89s)
        --- PASS: TestAccAccount_serial/AlternateContact/AccountID (39.07s)
    --- PASS: TestAccAccount_serial/PrimaryContact (27.44s)
        --- PASS: TestAccAccount_serial/PrimaryContact/basic (27.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	110.988s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account/retry	0.167s [no tests to run]

@ewbankkit
Copy link
Contributor

@kurtmc Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e79842c into hashicorp:main Apr 28, 2023
@github-actions github-actions bot added this to the v4.66.0 milestone Apr 28, 2023
@ewbankkit ewbankkit mentioned this pull request May 1, 2023
Merged
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@kurtmc kurtmc deleted the r/aws_account_primary_contact branch May 7, 2023 20:36
@hieki hieki mentioned this pull request Jun 1, 2023
Merged
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. new-resource Introduces a new resource. service/account Issues and PRs that pertain to the account service. service/kms Issues and PRs that pertain to the kms service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.66.0
Development

Successfully merging this pull request may close these issues.

new resource aws_account_primary_contact
4 participants
@kurtmc @kyle-c-simmons @ewbankkit @justinretzolk