Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement aws_account_primary_contact #26123

Merged
merged 21 commits into from
Apr 28, 2023
Merged

Implement aws_account_primary_contact #26123

merged 21 commits into from
Apr 28, 2023

Commits on Feb 17, 2023

  1. Implement aws_account_primary_contact

    @kurtmc
    kurtmc committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8eb6912 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Merge branch 'main' into HEAD 

    # Conflicts:
#	internal/provider/provider.go
    @ewbankkit
    ewbankkit committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    242c0ba View commit details
    Browse the repository at this point in the history

  2. r/aws_account_primary_contact: Use 'schema.NoopContext'.

    @ewbankkit
    ewbankkit committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    cceb73e View commit details
    Browse the repository at this point in the history

  3. r/aws_account_alternate_contact: Consolidate source files.

    @ewbankkit
    ewbankkit committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    5e5cbae View commit details
    Browse the repository at this point in the history

  4. r/aws_account_alternate_contact: Alphabetoze attributes.

    @ewbankkit
    ewbankkit committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    63e8380 View commit details
    Browse the repository at this point in the history

  5. r/aws_account_alternate_contact: 'FindAlternateContactByAccountIDAndC… 

    …ontactType' -> 'FindAlternateContactByTwoPartKey'.
    @ewbankkit
    ewbankkit committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    278c8ab View commit details
    Browse the repository at this point in the history

  6. r/aws_account_alternate_contact: Tidy up resource Delete.

    @ewbankkit
    ewbankkit committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    d05d91b View commit details
    Browse the repository at this point in the history

  7. Add 'tfresource.RetryIf' and 'tfresource.RetryWhenNotFoundN'.

    @ewbankkit
    ewbankkit committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    32a0999 View commit details
    Browse the repository at this point in the history

  8. r/aws_account_alternate_contact: Simplify.

    @ewbankkit
    ewbankkit committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    cb1e7a9 View commit details
    Browse the repository at this point in the history

  9. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccAccount_serial/AlternateContact' PKG=account
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20  -run=TestAccAccount_serial/AlternateContact -timeout 180m
=== RUN   TestAccAccount_serial
=== PAUSE TestAccAccount_serial
=== CONT  TestAccAccount_serial
=== RUN   TestAccAccount_serial/AlternateContact
=== RUN   TestAccAccount_serial/AlternateContact/basic
=== RUN   TestAccAccount_serial/AlternateContact/disappears
=== RUN   TestAccAccount_serial/AlternateContact/AccountID
--- PASS: TestAccAccount_serial (79.60s)
    --- PASS: TestAccAccount_serial/AlternateContact (79.60s)
        --- PASS: TestAccAccount_serial/AlternateContact/basic (27.85s)
        --- PASS: TestAccAccount_serial/AlternateContact/disappears (12.20s)
        --- PASS: TestAccAccount_serial/AlternateContact/AccountID (39.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	85.073s
    @ewbankkit
    ewbankkit committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    638a8c9 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. The start of musings on a replacement for the Terraform Plugin SDK v2… 

    … `helper/retry` package.
    @ewbankkit
    ewbankkit committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    950d023 View commit details
    Browse the repository at this point in the history

  2. r/aws_account_alternate_contact: Use new, PoC retry functionality.

    @ewbankkit
    ewbankkit committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    05f34ff View commit details
    Browse the repository at this point in the history

  3. r/aws_account_primary_contact: Tidy up.

    @ewbankkit
    ewbankkit committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    4d8100c View commit details
    Browse the repository at this point in the history

  4. Add CHANGELOG entry.

    @ewbankkit
    ewbankkit committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    dfffa5b View commit details
    Browse the repository at this point in the history

  5. Account: Use AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    cc1c8a2 View commit details
    Browse the repository at this point in the history

  6. Run 'go get github.com/aws/aws-sdk-go-v2/service/account@v1.10.5 && g… 

    …o mod tidy'.
    @ewbankkit
    ewbankkit committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    34a1218 View commit details
    Browse the repository at this point in the history

  7. Add 'AccountEndpointID'.

    @ewbankkit
    ewbankkit committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    82fe32e View commit details
    Browse the repository at this point in the history

  8. Account: Migrate to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    f6ea84d View commit details
    Browse the repository at this point in the history

  9. Update account_primary_contact.html.markdown

    @ewbankkit
    ewbankkit authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    b5e0d6c View commit details
    Browse the repository at this point in the history

  10. Fix golangci-lint 'gomnd'.

    @ewbankkit
    ewbankkit committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    87208d1 View commit details
    Browse the repository at this point in the history

  11. Merge commit '87208d145e8feeac16f497e6a109f461a3bbca48' into HEAD

    @ewbankkit
    ewbankkit committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d6b5139 View commit details
    Browse the repository at this point in the history