Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute arn_without_revision on aws_ecs_task_definition #27351

Merged
merged 5 commits into from
Mar 11, 2023
Merged

Add attribute arn_without_revision on aws_ecs_task_definition #27351

merged 5 commits into from
Mar 11, 2023

Conversation

DBX12
Copy link
Contributor

@DBX12 DBX12 commented Oct 20, 2022

Description

This pull requests adds the attribute arn_without_revision to the resource aws_ecs_task_definition as explained in issue #27119

Relations

Closes #27119

Notes

  • I do not have an AWS account, so I could not run the tests which require one.
  • I'm participating in hacktoberfest 2022. So if you deem this pull request helpful, I'd be glad if you could add the hacktoberfest-accepted label to the PR so it helps me reaching the goal :)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Oct 20, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @DBX12 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 20, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 10, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=ecs TESTS=TestAccECSTaskDefinition_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskDefinition_'  -timeout 180m

--- PASS: TestAccECSTaskDefinition_invalidContainerDefinition (4.14s)
=== CONT  TestAccECSTaskDefinition_Fargate_basic
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (31.53s)
=== CONT  TestAccECSTaskDefinition_inferenceAccelerator
--- PASS: TestAccECSTaskDefinition_networkMode (31.71s)
=== CONT  TestAccECSTaskDefinition_arrays
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (32.43s)
=== CONT  TestAccECSTaskDefinition_pidMode
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (33.20s)
=== CONT  TestAccECSTaskDefinition_ipcMode
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (34.07s)
=== CONT  TestAccECSTaskDefinition_constraint
--- PASS: TestAccECSTaskDefinition_runtimePlatform (34.24s)
=== CONT  TestAccECSTaskDefinition_disappears
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (34.31s)
=== CONT  TestAccECSTaskDefinition_executionRole
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (34.48s)
=== CONT  TestAccECSTaskDefinition_proxy
--- PASS: TestAccECSTaskDefinition_scratchVolume (34.74s)
--- PASS: TestAccECSTaskDefinition_taskRoleARN (34.87s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (42.54s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (43.97s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (44.43s)
--- PASS: TestAccECSTaskDefinition_Fargate_basic (40.82s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (47.60s)
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (49.91s)
--- PASS: TestAccECSTaskDefinition_basic (50.43s)
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (23.42s)
--- PASS: TestAccECSTaskDefinition_arrays (24.20s)
--- PASS: TestAccECSTaskDefinition_pidMode (23.94s)
--- PASS: TestAccECSTaskDefinition_ipcMode (23.27s)
--- PASS: TestAccECSTaskDefinition_executionRole (22.46s)
--- PASS: TestAccECSTaskDefinition_constraint (24.36s)
--- PASS: TestAccECSTaskDefinition_disappears (29.13s)
--- PASS: TestAccECSTaskDefinition_proxy (29.50s)
--- PASS: TestAccECSTaskDefinition_tags (66.19s)
--- PASS: TestAccECSTaskDefinition_service (115.81s)
--- PASS: TestAccECSTaskDefinition_fsxWinFileSystem (3447.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        3450.106s

@jar-b jar-b merged commit e49e771 into hashicorp:main Mar 11, 2023
@jar-b
Copy link
Member

jar-b commented Mar 11, 2023

Thanks for your contribution, @DBX12! 👏

@github-actions github-actions bot added this to the v4.59.0 milestone Mar 11, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DBX12 DBX12 deleted the f-arn_without_revision branch March 17, 2023 12:10
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Attribute arn_without_revision on aws_ecs_task_definition
3 participants