Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for adding tags to Elastic IPs #2932

Closed
bacoboy opened this issue Jan 10, 2018 · 5 comments
Closed

Add support for adding tags to Elastic IPs #2932

bacoboy opened this issue Jan 10, 2018 · 5 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/ec2 Issues and PRs that pertain to the ec2 service.

Comments

@bacoboy
Copy link

bacoboy commented Jan 10, 2018

EIPs can now have tags. Opening a feature request to add to the aws_eip data source and resource.

Source: https://aws.amazon.com/about-aws/whats-new/2017/12/amazon-virtual-private-cloud-vpc-now-allows-customers-to-tag-their-elastic-ip-addresses/
@bflad
Copy link
Contributor

bflad commented Jan 10, 2018

Hi @bacoboy! This feature has actually already landed in the aws_eip resource as part of #2768 and will be available in 1.7.0 which will be released 🔜 . The functionality for the aws_eip data source has not been implemented, but we would gladly accept a PR.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jan 10, 2018
@UnsafePointer UnsafePointer mentioned this issue May 3, 2018
Closed
UnsafePointer pushed a commit to UnsafePointer/terraform-provider-aws that referenced this issue May 7, 2018
@UnsafePointer
Add support for tags and filters to aws_eip data source
dab8e52 
This should close hashicorp#2932
@UnsafePointer
Copy link

Duplicate of #3423. Check also #3525

@bacoboy
Copy link
Author

bacoboy commented May 29, 2018

This is not a dupe of #3423. It was to add tags to the resource. It should be closed at this point.
#3423 is about using tags on the data source to find the eip -- this one was to set the tags on the resource.

@UnsafePointer
Copy link

@bacoboy the first comment referenced the data source and the resource, and by the time I read it the resource already had it. This issue should one closed now, as there are specific issues for the data source and a PR opened for that.

@bacoboy bacoboy closed this as completed May 29, 2018
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for tags and filters to aws_eip data source UnsafePointer/terraform-provider-aws
3 participants
@bflad @UnsafePointer @bacoboy