Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_feature_group - support table format #30118

Merged
merged 10 commits into from
Mar 31, 2023

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Mar 18, 2023

Description

Relations

Closes #30098

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccSageMakerFeatureGroup_serial PKG=sagemaker
    --- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_format (79.14s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_createCatalog (78.77s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_providedCatalog (69.08s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/onlineConfigSecurityConfig (57.73s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/tags (97.65s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/basic (57.82s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/disappears (51.30s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_basic (78.94s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/description (58.25s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/multipleFeatures (57.57s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Mar 18, 2023
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 18, 2023
@DrFaust92 DrFaust92 marked this pull request as ready for review March 20, 2023 19:56
@DrFaust92 DrFaust92 marked this pull request as draft March 26, 2023 20:35
@DrFaust92 DrFaust92 marked this pull request as ready for review March 27, 2023 06:42
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Mar 30, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerFeatureGroup_serial/offlineConfig_format' PKG=sagemaker
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMakerFeatureGroup_serial/offlineConfig_format -timeout 180m
=== RUN   TestAccSageMakerFeatureGroup_serial
=== PAUSE TestAccSageMakerFeatureGroup_serial
=== CONT  TestAccSageMakerFeatureGroup_serial
=== RUN   TestAccSageMakerFeatureGroup_serial/offlineConfig_format
--- PASS: TestAccSageMakerFeatureGroup_serial (62.48s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_format (62.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	69.261s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 903c635 into hashicorp:main Mar 31, 2023
@github-actions github-actions bot added this to the v4.62.0 milestone Mar 31, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support IceBerg File Format in aws_sagemaker_feature_group
2 participants