Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standby_replicas attribute on the aws_opensearchserverless_collection resource #34677

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Add standby_replicas attribute on the aws_opensearchserverless_collection resource #34677

merged 8 commits into from
Dec 11, 2023

Conversation

cprakasu
Copy link
Contributor

@cprakasu cprakasu commented Dec 1, 2023

Description

This PR adds the standby_replicas argument on the aws_opensearchserverless_collection resource.

This makes it possible to upload a policy to the endpoint resource.

Relations

Closes #34675

References

Output from Acceptance Testing

% make testacc  TESTS=TestAccOpenSearchServerlessCollection_standbyReplicas PKG=opensearchserverless
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessCollection_standbyReplicas'  -timeout 360m
=== RUN   TestAccOpenSearchServerlessCollection_standbyReplicas
=== PAUSE TestAccOpenSearchServerlessCollection_standbyReplicas
=== CONT  TestAccOpenSearchServerlessCollection_standbyReplicas
--- PASS: TestAccOpenSearchServerlessCollection_standbyReplicas (146.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless       146.777s
% make testacc  TESTS=TestAccOpenSearchServerlessCollection_basic PKG=opensearchserverless
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessCollection_basic'  -timeout 360m
=== RUN   TestAccOpenSearchServerlessCollection_basic
=== PAUSE TestAccOpenSearchServerlessCollection_basic
=== CONT  TestAccOpenSearchServerlessCollection_basic
--- PASS: TestAccOpenSearchServerlessCollection_basic (146.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless       146.307s

Copy link

github-actions bot commented Dec 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. labels Dec 1, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 1, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @cprakasu 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 6, 2023
@johnsonaj johnsonaj self-assigned this Dec 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 11, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccOpenSearchServerlessCollection_\|TestAccOpenSearchServerlessCollectionDataSource_basic' PKG=opensearchserverless

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20  -run=TestAccOpenSearchServerlessCollection_\|TestAccOpenSearchServerlessCollectionDataSource_basic -timeout 360m
--- PASS: TestAccOpenSearchServerlessCollection_disappears (441.94s)
--- PASS: TestAccOpenSearchServerlessCollection_basic (446.66s)
--- PASS: TestAccOpenSearchServerlessCollection_standbyReplicas (446.81s)
--- PASS: TestAccOpenSearchServerlessCollectionDataSource_basic (456.63s)
--- PASS: TestAccOpenSearchServerlessCollection_update (466.93s)
--- PASS: TestAccOpenSearchServerlessCollection_tags (488.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless	492.533s

@johnsonaj
Copy link
Contributor

@cprakasu thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 35862fe into hashicorp:main Dec 11, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.31.0 milestone Dec 11, 2023
Copy link

This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: resource aws_opensearchserverless_collection - standby_replicas
3 participants