Actually fetch the tags of a service

[ankon]

The acceptance test only checked the existence of the tags attribute, but not the actual contents -- so the missing Include: ["TAGS"] for the DescribeServices call wasn't detected.

Fix that by explicitly checking for the number of tags (1) and the one we expect.

Relations

Relates #18593 (Code related to the ISO regions cloned from cluster_data_source, I have no means of checking whether this is actually true or not.)
Closes #34124.

References

https://pkg.go.dev/github.com/aws/aws-sdk-go@v1.54.6/service/ecs#DescribeServicesInput

Output from Acceptance Testing

$ AWS_PROFILE=... make testacc TESTS=TestAccECSServiceDataSource_basic PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSServiceDataSource_basic'  -timeout 360m
=== RUN   TestAccECSServiceDataSource_basic
=== PAUSE TestAccECSServiceDataSource_basic
=== CONT  TestAccECSServiceDataSource_basic
--- PASS: TestAccECSServiceDataSource_basic (77.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	77.179s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECSServiceDataSource_\|TestAccECSService_disappears' PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSServiceDataSource_\|TestAccECSService_disappears -timeout 360m
=== RUN   TestAccECSServiceDataSource_basic
=== PAUSE TestAccECSServiceDataSource_basic
=== RUN   TestAccECSService_disappears
=== PAUSE TestAccECSService_disappears
=== CONT  TestAccECSServiceDataSource_basic
=== CONT  TestAccECSService_disappears
--- PASS: TestAccECSServiceDataSource_basic (59.87s)
--- PASS: TestAccECSService_disappears (180.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	185.259s

[ewbankkit]

@ankon Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.