Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually fetch the tags of a service #38067

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Actually fetch the tags of a service #38067

merged 3 commits into from
Jun 21, 2024

Commits on Jun 21, 2024

  1. Actually fetch the tags of a service 

    The acceptance test only checked the existence of the `tags` attribute, but not the actual contents -- so the missing
`Include: ["TAGS"]` for the `DescribeServices` call wasn't detected.

Fix that by explicitly checking for the number of tags (1) and the one we expect.
    @ankon
    ankon committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    2e3c1a1 View commit details
    Browse the repository at this point in the history

  2. Tweak CHANGELOG entry.

    @ewbankkit
    ewbankkit committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    07d94e6 View commit details
    Browse the repository at this point in the history

  3. d/aws_ecs_service: Use finder.

    @ewbankkit
    ewbankkit committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    f47fe73 View commit details
    Browse the repository at this point in the history