-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource]: Added Verified Permissions identity_source
#38181
[New Resource]: Added Verified Permissions identity_source
#38181
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Want to wait for #38192 to be merged to remove the expanders for the union types and fully use AutoFlex. |
This PR is ready for review again. Small note for the reviewer, I added a custom expander for the AutoFlex for certain types but had to make a distinction on the Example (configuration): Create: https://docs.aws.amazon.com/verifiedpermissions/latest/apireference/API_Configuration.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @DanielRieske. I've updated the tests to separate them out and test conversions in both directions
--- PASS: TestAccVerifiedPermissionsIdentitySource_disappears (82.97s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_OpenID_basic (83.24s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_Cognito_basic (89.08s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_OpenID_convertToCognito (107.56s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_Cognito_update (108.68s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_Cognito_convertToOpenID (108.94s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_OpenID_update (121.13s)
This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds the last resource
identity_source
to make this service complete.Relations
Closes #35801
Closes #32158
References
Output from Acceptance Testing