Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: go1.22.6 downgrade #39256

Merged
merged 12 commits into from
Sep 10, 2024
Merged

provider: go1.22.6 downgrade #39256

merged 12 commits into from
Sep 10, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Sep 10, 2024 •
edited
Loading

Description

A small number of users have reported failed or hanging network connections using the version of the Terraform AWS provider which was first built with Go 1.23.0 (v5.65.0). At this point, maintainers have been unable to reproduce failures, but enough distinct users have reported issues that we are going to attempt downgrading to Go 1.22.6 for the next provider release. We will continue to coordinate with users and AWS in an attempt to identify the root cause, using this upcoming release with a reverted Go build version as a data point.

Relations

Relates #38999
Relates #39144

Relates #39110
Relates #39115
Relates #39125
Relates #39141
Relates #39173

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withTrafficSourcesELBs\|TestAccAutoScalingGroup_loadBalancers\|TestAccAutoScalingGroup_targetGroups' PKG=autoscaling
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/autoscaling/... -v -count 1 -parallel 20  -run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withTrafficSourcesELBs\|TestAccAutoScalingGroup_loadBalancers\|TestAccAutoScalingGroup_targetGroups -timeout 360m

--- PASS: TestAccAutoScalingGroup_basic (28.41s)
--- PASS: TestAccAutoScalingGroup_targetGroups (108.44s)
--- PASS: TestAccAutoScalingGroup_loadBalancers (287.88s)
--- PASS: TestAccAutoScalingGroup_withTrafficSourcesELBs (374.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        380.382s
% make testacc TESTARGS='-run=TestAccLakeFormation_serial/^LFTags$$' PKG=lakeformation
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/^LFTags$ -timeout 360m

--- PASS: TestAccLakeFormation_serial (97.10s)
    --- PASS: TestAccLakeFormation_serial/LFTags (97.10s)
        --- PASS: TestAccLakeFormation_serial/LFTags/basic (15.97s)
        --- PASS: TestAccLakeFormation_serial/LFTags/disappears (13.05s)
        --- PASS: TestAccLakeFormation_serial/LFTags/tagKeyComplex (12.14s)
        --- PASS: TestAccLakeFormation_serial/LFTags/values (24.46s)
        --- PASS: TestAccLakeFormation_serial/LFTags/valuesOverFifty (31.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      103.355s
% make golangci-lint
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`.
make: golangci-lint Checks / 3 of 3...
% make sanity
make: Sanity Check (48 tests of Top 30 resources)
make: Like 'sane' but less output and runs all tests despite most errors
make: NOTE: NOT an exhaustive set of tests! Finds big problems only.
17 of 48 complete: 17 passed, 0 failed
33 of 48 complete: 33 passed, 0 failed
48 of 48 complete: 48 passed, 0 failed

@jar-b
chore: revert to go1.22.6
8ef5573 
A small number of users have reported failed or hanging network connections using the version of the Terraform AWS provider which was first built with Go `1.23.0` (`v5.65.0`). At this point, maintainers have been unable to reproduce failures, but enough distinct users have reported issues that we are going to attempt downgrading to Go `1.22.6` for the next provider release. We will continue to coordinate with users and AWS in an attempt to identify the root cause, using this upcoming release with a reverted Go build version as a data point.
@jar-b
Revert "Remove 'tfslices.Chunks'."
9be946f 
This reverts commit e5c24d5.
@jar-b
Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - ssm."
bfff87f 
This reverts commit 281ea60.
@jar-b
Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - route53."
d1b3b11 
This reverts commit f722b5d.
@jar-b
Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - rds."
0c6c637 
This reverts commit ed58544.
@jar-b
Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - neptune."
8ec8670 
This reverts commit d42525b.
@jar-b
Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - kafka."
f797f26 
This reverts commit 623df99.
@jar-b
Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - docdb."
9ec42d9 
This reverts commit 7d5e310.
@jar-b
Revert "Replace 'tfslices.Chunks' with 'slices.Chunk' - connect."
c40facf 
This reverts commit e56ae32.
@jar-b
Partial reversion of Replace 'tfslices.Chunks' with 'slices.Chunk' - …
b142d28 
…lakeformation.

```console
% make testacc TESTARGS='-run=TestAccLakeFormation_serial/^LFTags$$' PKG=lakeformation
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/^LFTags$ -timeout 360m

--- PASS: TestAccLakeFormation_serial (97.10s)
    --- PASS: TestAccLakeFormation_serial/LFTags (97.10s)
        --- PASS: TestAccLakeFormation_serial/LFTags/basic (15.97s)
        --- PASS: TestAccLakeFormation_serial/LFTags/disappears (13.05s)
        --- PASS: TestAccLakeFormation_serial/LFTags/tagKeyComplex (12.14s)
        --- PASS: TestAccLakeFormation_serial/LFTags/values (24.46s)
        --- PASS: TestAccLakeFormation_serial/LFTags/valuesOverFifty (31.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      103.355s
```
@jar-b
Partial reversion of Replace 'tfslices.Chunks' with 'slices.Chunk' - …
a351eb1 
…autoscaling.

```console
% make testacc TESTARGS='-run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withTrafficSourcesELBs\|TestAccAutoScalingGroup_loadBalancers\|TestAccAutoScalingGroup_targetGroups' PKG=autoscaling
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/autoscaling/... -v -count 1 -parallel 20  -run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withTrafficSourcesELBs\|TestAccAutoScalingGroup_loadBalancers\|TestAccAutoScalingGroup_targetGroups -timeout 360m

--- PASS: TestAccAutoScalingGroup_basic (28.41s)
--- PASS: TestAccAutoScalingGroup_targetGroups (108.44s)
--- PASS: TestAccAutoScalingGroup_loadBalancers (287.88s)
--- PASS: TestAccAutoScalingGroup_withTrafficSourcesELBs (374.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        380.382s
```
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. service/rds Issues and PRs that pertain to the rds service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ssm Issues and PRs that pertain to the ssm service. provider Pertains to the provider itself, rather than any interaction with AWS. service/neptune Issues and PRs that pertain to the neptune service. service/connect Issues and PRs that pertain to the connect service. service/kafka Issues and PRs that pertain to the kafka service. service/docdb Issues and PRs that pertain to the docdb service. service/lakeformation Issues and PRs that pertain to the lakeformation service. skaff Issues and pull requested related to the skaff tool prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 10, 2024
@jar-b jar-b marked this pull request as ready for review September 10, 2024 20:16
@jar-b jar-b requested a review from a team as a code owner September 10, 2024 20:16
ewbankkit
ewbankkit approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make sane               
make: Sane Check (48 tests of Top 30 resources)
make: Like 'sanity' except full output and stops soon after 1st error
make: NOTE: NOT an exhaustive set of tests! Finds big problems only.
=== RUN   TestAccIAMInstanceProfile_tags
=== PAUSE TestAccIAMInstanceProfile_tags
=== RUN   TestAccIAMInstanceProfile_tags_null
=== PAUSE TestAccIAMInstanceProfile_tags_null
=== RUN   TestAccIAMInstanceProfile_tags_AddOnUpdate
=== PAUSE TestAccIAMInstanceProfile_tags_AddOnUpdate
=== RUN   TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate
=== RUN   TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_overlapping
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_overlapping
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccIAMInstanceProfile_tags_ComputedTag_OnCreate
=== PAUSE TestAccIAMInstanceProfile_tags_ComputedTag_OnCreate
=== RUN   TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccIAMInstanceProfile_basic
=== PAUSE TestAccIAMInstanceProfile_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_basic
=== PAUSE TestAccIAMPolicyDocumentDataSource_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== PAUSE TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== RUN   TestAccIAMPolicy_tags
=== PAUSE TestAccIAMPolicy_tags
=== RUN   TestAccIAMPolicy_tags_null
=== PAUSE TestAccIAMPolicy_tags_null
=== RUN   TestAccIAMPolicy_tags_AddOnUpdate
=== PAUSE TestAccIAMPolicy_tags_AddOnUpdate
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccIAMPolicy_tags_DefaultTags_providerOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_providerOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
=== RUN   TestAccIAMPolicy_tags_DefaultTags_overlapping
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_overlapping
=== RUN   TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccIAMPolicy_tags_ComputedTag_OnCreate
=== PAUSE TestAccIAMPolicy_tags_ComputedTag_OnCreate
=== RUN   TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccIAMPolicy_basic
=== PAUSE TestAccIAMPolicy_basic
=== RUN   TestAccIAMPolicy_policy
=== PAUSE TestAccIAMPolicy_policy
=== RUN   TestAccIAMPolicy_policyDuplicateKeys
=== PAUSE TestAccIAMPolicy_policyDuplicateKeys
=== RUN   TestAccIAMRolePolicyAttachment_basic
=== PAUSE TestAccIAMRolePolicyAttachment_basic
=== RUN   TestAccIAMRolePolicyAttachment_disappears
=== PAUSE TestAccIAMRolePolicyAttachment_disappears
=== RUN   TestAccIAMRolePolicyAttachment_Disappears_role
=== PAUSE TestAccIAMRolePolicyAttachment_Disappears_role
=== RUN   TestAccIAMRolePolicy_basic
=== PAUSE TestAccIAMRolePolicy_basic
=== RUN   TestAccIAMRolePolicy_unknownsInPolicy
=== PAUSE TestAccIAMRolePolicy_unknownsInPolicy
=== RUN   TestAccIAMRole_basic
=== PAUSE TestAccIAMRole_basic
=== RUN   TestAccIAMRole_namePrefix
=== PAUSE TestAccIAMRole_namePrefix
=== RUN   TestAccIAMRole_disappears
=== PAUSE TestAccIAMRole_disappears
=== RUN   TestAccIAMRole_InlinePolicy_basic
=== PAUSE TestAccIAMRole_InlinePolicy_basic
=== CONT  TestAccIAMInstanceProfile_tags
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccIAMPolicy_tags_EmptyTag_OnCreate
=== CONT  TestAccIAMPolicy_tags_AddOnUpdate
=== CONT  TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccIAMInstanceProfile_tags_ComputedTag_OnCreate
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccIAMPolicy_tags
=== CONT  TestAccIAMPolicy_tags_null
=== CONT  TestAccIAMPolicy_basic
=== CONT  TestAccIAMRole_InlinePolicy_basic
=== CONT  TestAccIAMRole_disappears
=== CONT  TestAccIAMRole_namePrefix
=== CONT  TestAccIAMRole_basic
=== CONT  TestAccIAMRolePolicy_unknownsInPolicy
=== CONT  TestAccIAMRolePolicy_basic
=== CONT  TestAccIAMInstanceProfile_basic
--- PASS: TestAccIAMRole_disappears (24.54s)
=== CONT  TestAccIAMRolePolicyAttachment_Disappears_role
--- PASS: TestAccIAMPolicy_basic (28.58s)
=== CONT  TestAccIAMRolePolicyAttachment_disappears
--- PASS: TestAccIAMRolePolicy_basic (28.66s)
=== CONT  TestAccIAMRolePolicyAttachment_basic
--- PASS: TestAccIAMRole_basic (28.78s)
=== CONT  TestAccIAMPolicy_policyDuplicateKeys
--- PASS: TestAccIAMRole_namePrefix (28.82s)
=== CONT  TestAccIAMPolicy_policy
--- PASS: TestAccIAMInstanceProfile_basic (29.02s)
=== CONT  TestAccIAMPolicyDocumentDataSource_sourceConflicting
--- PASS: TestAccIAMRolePolicy_unknownsInPolicy (30.26s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping
--- PASS: TestAccIAMPolicy_policyDuplicateKeys (2.79s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag (34.83s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag (35.08s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccIAMInstanceProfile_tags_ComputedTag_OnCreate (36.33s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccIAMPolicy_tags_null (40.10s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_overlapping
--- PASS: TestAccIAMPolicyDocumentDataSource_sourceConflicting (17.63s)
=== CONT  TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccIAMRolePolicyAttachment_Disappears_role (23.74s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly
--- PASS: TestAccIAMPolicy_tags_AddOnUpdate (51.45s)
=== CONT  TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace (52.21s)
=== CONT  TestAccIAMPolicyDocumentDataSource_basic
--- PASS: TestAccIAMRolePolicyAttachment_disappears (24.48s)
=== CONT  TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate
--- PASS: TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Replace (58.12s)
=== CONT  TestAccIAMInstanceProfile_tags_AddOnUpdate
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnCreate (59.61s)
=== CONT  TestAccIAMInstanceProfile_tags_null
--- PASS: TestAccIAMInstanceProfile_tags_ComputedTag_OnUpdate_Add (60.05s)
=== CONT  TestAccIAMPolicy_tags_ComputedTag_OnCreate
--- PASS: TestAccIAMRole_InlinePolicy_basic (63.32s)
=== CONT  TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_emptyProviderOnlyTag (32.14s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag (32.52s)
=== CONT  TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccIAMPolicyDocumentDataSource_basic (17.75s)
--- PASS: TestAccIAMPolicy_policy (46.53s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccIAMRolePolicyAttachment_basic (47.23s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_nonOverlapping
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add (80.18s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly (52.38s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_overlapping
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly (54.75s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccIAMPolicy_tags_ComputedTag_OnCreate (37.03s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag (35.43s)
=== CONT  TestAccIAMPolicy_tags_DefaultTags_providerOnly
--- PASS: TestAccIAMInstanceProfile_tags_null (44.41s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag (36.26s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace (55.16s)
--- PASS: TestAccIAMInstanceProfile_tags_AddOnUpdate (53.90s)
--- PASS: TestAccIAMPolicy_tags (115.06s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag (35.15s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate (62.76s)
--- PASS: TestAccIAMInstanceProfile_tags (116.45s)
--- PASS: TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Replace (55.91s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping (88.99s)
--- PASS: TestAccIAMPolicy_tags_ComputedTag_OnUpdate_Add (54.51s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add (76.51s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly (49.37s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_emptyProviderOnlyTag (27.94s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_overlapping (84.96s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly (40.50s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nonOverlapping (64.76s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly (94.97s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_overlapping (58.91s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_providerOnly (62.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	166.996s
=== RUN   TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN   TestAccLogsGroup_multiple
=== PAUSE TestAccLogsGroup_multiple
=== CONT  TestAccLogsGroup_basic
=== CONT  TestAccLogsGroup_multiple
--- PASS: TestAccLogsGroup_multiple (12.20s)
--- PASS: TestAccLogsGroup_basic (15.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	20.493s
=== RUN   TestAccVPCDataSource_basic
=== PAUSE TestAccVPCDataSource_basic
=== RUN   TestAccVPCRouteTableAssociation_Subnet_basic
=== PAUSE TestAccVPCRouteTableAssociation_Subnet_basic
=== RUN   TestAccVPCRouteTable_basic
=== PAUSE TestAccVPCRouteTable_basic
=== RUN   TestAccVPCSecurityGroupRule_race
=== PAUSE TestAccVPCSecurityGroupRule_race
=== RUN   TestAccVPCSecurityGroupRule_protocolChange
=== PAUSE TestAccVPCSecurityGroupRule_protocolChange
=== RUN   TestAccVPCSecurityGroup_basic
=== PAUSE TestAccVPCSecurityGroup_basic
=== RUN   TestAccVPCSecurityGroup_egressMode
=== PAUSE TestAccVPCSecurityGroup_egressMode
=== RUN   TestAccVPCSecurityGroup_vpcAllEgress
=== PAUSE TestAccVPCSecurityGroup_vpcAllEgress
=== RUN   TestAccVPCSubnet_basic
=== PAUSE TestAccVPCSubnet_basic
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== CONT  TestAccVPCDataSource_basic
=== CONT  TestAccVPCSecurityGroup_basic
=== CONT  TestAccVPCSubnet_basic
=== CONT  TestAccVPCSecurityGroupRule_race
=== CONT  TestAccVPCRouteTable_basic
=== CONT  TestAccVPCSecurityGroup_vpcAllEgress
=== CONT  TestAccVPC_tenancy
=== CONT  TestAccVPCSecurityGroup_egressMode
=== CONT  TestAccVPCRouteTableAssociation_Subnet_basic
=== CONT  TestAccVPCSecurityGroupRule_protocolChange
--- PASS: TestAccVPCSubnet_basic (21.15s)
--- PASS: TestAccVPCRouteTable_basic (22.57s)
--- PASS: TestAccVPCSecurityGroup_basic (23.77s)
--- PASS: TestAccVPCSecurityGroup_vpcAllEgress (24.21s)
--- PASS: TestAccVPCRouteTableAssociation_Subnet_basic (25.13s)
--- PASS: TestAccVPCDataSource_basic (29.65s)
--- PASS: TestAccVPCSecurityGroup_egressMode (45.19s)
--- PASS: TestAccVPC_tenancy (45.91s)
--- PASS: TestAccVPCSecurityGroupRule_protocolChange (52.27s)
--- PASS: TestAccVPCSecurityGroupRule_race (154.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	167.125s
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== CONT  TestAccECSService_basic
=== CONT  TestAccECSTaskDefinition_basic
=== CONT  TestAccECSService_basicImport
--- PASS: TestAccECSTaskDefinition_basic (25.43s)
--- PASS: TestAccECSService_basic (80.92s)
--- PASS: TestAccECSService_basicImport (186.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	192.388s
=== RUN   TestAccELBV2TargetGroup_basic
=== PAUSE TestAccELBV2TargetGroup_basic
=== CONT  TestAccELBV2TargetGroup_basic
--- PASS: TestAccELBV2TargetGroup_basic (20.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	37.370s
=== RUN   TestAccKMSKey_basic
=== PAUSE TestAccKMSKey_basic
=== CONT  TestAccKMSKey_basic
--- PASS: TestAccKMSKey_basic (25.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	34.328s
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaPermission_basic
=== PAUSE TestAccLambdaPermission_basic
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaPermission_basic
--- PASS: TestAccLambdaPermission_basic (31.03s)
--- PASS: TestAccLambdaFunction_basic (41.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	54.005s
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_basic
=== PAUSE TestAccMetaRegionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_endpoint
=== PAUSE TestAccMetaRegionDataSource_endpoint
=== RUN   TestAccMetaRegionDataSource_endpointAndName
=== PAUSE TestAccMetaRegionDataSource_endpointAndName
=== CONT  TestAccMetaPartitionDataSource_basic
=== CONT  TestAccMetaRegionDataSource_endpoint
=== CONT  TestAccMetaRegionDataSource_endpointAndName
=== CONT  TestAccMetaRegionDataSource_basic
--- PASS: TestAccMetaPartitionDataSource_basic (10.87s)
--- PASS: TestAccMetaRegionDataSource_basic (10.88s)
--- PASS: TestAccMetaRegionDataSource_endpoint (12.20s)
--- PASS: TestAccMetaRegionDataSource_endpointAndName (12.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	17.451s
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53ZoneDataSource_name
=== PAUSE TestAccRoute53ZoneDataSource_name
=== RUN   TestAccRoute53ZoneDataSource_name_idEmptyString
=== PAUSE TestAccRoute53ZoneDataSource_name_idEmptyString
=== CONT  TestAccRoute53Record_basic
=== CONT  TestAccRoute53ZoneDataSource_name
=== CONT  TestAccRoute53Record_Latency_basic
=== CONT  TestAccRoute53ZoneDataSource_name_idEmptyString
--- PASS: TestAccRoute53ZoneDataSource_name_idEmptyString (89.56s)
--- PASS: TestAccRoute53ZoneDataSource_name (95.66s)
--- PASS: TestAccRoute53Record_basic (172.82s)
--- PASS: TestAccRoute53Record_Latency_basic (191.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	200.106s
=== RUN   TestAccS3BucketACL_updateACL
=== PAUSE TestAccS3BucketACL_updateACL
=== RUN   TestAccS3BucketPolicy_basic
=== PAUSE TestAccS3BucketPolicy_basic
=== RUN   TestAccS3BucketPublicAccessBlock_basic
=== PAUSE TestAccS3BucketPublicAccessBlock_basic
=== RUN   TestAccS3Bucket_Basic_basic
=== PAUSE TestAccS3Bucket_Basic_basic
=== RUN   TestAccS3Bucket_Security_corsUpdate
=== PAUSE TestAccS3Bucket_Security_corsUpdate
=== CONT  TestAccS3BucketACL_updateACL
=== CONT  TestAccS3Bucket_Basic_basic
=== CONT  TestAccS3BucketPublicAccessBlock_basic
=== CONT  TestAccS3BucketPolicy_basic
=== CONT  TestAccS3Bucket_Security_corsUpdate
--- PASS: TestAccS3Bucket_Basic_basic (20.72s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (20.82s)
--- PASS: TestAccS3BucketPolicy_basic (20.91s)
--- PASS: TestAccS3BucketACL_updateACL (33.89s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (35.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	50.566s
=== RUN   TestAccSecretsManagerSecret_basic
=== PAUSE TestAccSecretsManagerSecret_basic
=== RUN   TestAccSecretsManagerSecret_basicReplica
=== PAUSE TestAccSecretsManagerSecret_basicReplica
=== CONT  TestAccSecretsManagerSecret_basic
=== CONT  TestAccSecretsManagerSecret_basicReplica
--- PASS: TestAccSecretsManagerSecret_basic (15.04s)
--- PASS: TestAccSecretsManagerSecret_basicReplica (18.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	40.863s
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (9.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	28.482s

YakDriver
YakDriver approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a mess! I'll be curious to see if this is the real culprit.

@jar-b jar-b merged commit 51537f1 into main Sep 10, 2024
50 checks passed
@jar-b jar-b deleted the f-go1.22.6-downgrade branch September 10, 2024 22:59
@github-actions github-actions bot added this to the v5.67.0 milestone Sep 10, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 10, 2024
Update CHANGELOG.md for #39256
59a0f6e
@ewbankkit ewbankkit mentioned this pull request Sep 12, 2024
Closed
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024
This was referenced Sep 13, 2024
Closed
Closed
@ewbankkit ewbankkit mentioned this pull request Sep 24, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/connect Issues and PRs that pertain to the connect service. service/docdb Issues and PRs that pertain to the docdb service. service/kafka Issues and PRs that pertain to the kafka service. service/lakeformation Issues and PRs that pertain to the lakeformation service. service/neptune Issues and PRs that pertain to the neptune service. service/rds Issues and PRs that pertain to the rds service. service/route53 Issues and PRs that pertain to the route53 service. service/ssm Issues and PRs that pertain to the ssm service. skaff Issues and pull requested related to the skaff tool tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.67.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jar-b @ewbankkit @YakDriver